From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5713DC433EF for ; Tue, 25 Jan 2022 21:12:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fCyhgR9ZfSU33v8G7e4eiMlFQvSnkVjOH6+d8B3Hs/8=; b=JlbKwfErErihha vIenRxARJG95zd7IIvXWFkOZ8RyZnDQz7pLdB3x6eTj7+QjjnzJCg64EkMbC5017qKnC8raJ6l5vs toyoNlZiUg1liPrUWIUVyl1CkoGSjh9eRUFvjjICaj6a2ZqhOW9OJhVA5LMTUlWZoeM9IU0d8ckO1 T/vDQDuKKWKsZJeL7gZ9EGF1tSbsmG9v6/5MmOLns5GFo6Usb/ZVGNBYHNSDHy9aF/H9GiC1uvb1p dKghnW4lXnz3/5QeDQRsUDF8PQWT9Z6ByIRiqJPN3apcQXjQGHWB9C6Xva8VLYkxKVKKrnrOQNC2g JAHnqe6ackvB9M7DwdIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCT5V-009ZQf-IJ; Tue, 25 Jan 2022 21:10:49 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCT5S-009ZQC-CB for linux-arm-kernel@lists.infradead.org; Tue, 25 Jan 2022 21:10:47 +0000 Received: by mail-pg1-x52d.google.com with SMTP id i8so19271193pgt.13 for ; Tue, 25 Jan 2022 13:10:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oTajAjIFl5J5w/Rcv1Jq4D73n55d0RoAmCIghJOGibE=; b=ZKQNRGS2URon4bqAWx+sEDzRBBpV7Xe9BsY8G3Bdj8hiy3srRL2yAOY3wK3xdUHbhQ 0GtR6dOnpon+k8KnmSACtLufwTDy8gBHWQiYf1LxuujlpoIUIvFaithyoKebbgqHAIQt 3OZ+maPPLrzfTBfnzn5AE1b9pD2OhRxS81rImxOS8w3w6bbeV2gqEsWDYyZgUd4RHk/O ksrFBe9LlcwVzOiS0aUVrPn9lht/QyihBJGQsf4n9LXqyuOmIKcOOYjjiY0r4a8Frtm0 Oh5+AWbbeo7rLoq6Is1010UTApCBKXhUIR18eR8fHEwLOJ8PzQAsxxp7brbXxAStC6+s g27A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oTajAjIFl5J5w/Rcv1Jq4D73n55d0RoAmCIghJOGibE=; b=Z1MQEnxhiRxwu6xAzgUxjLif5ufWfq96O5SN3YZt3JVI1Na3ntd0ZFQu7QRNJemElI R9rAK793HS+1B5c3LgGPYFemEuibmlahw7x1BOsl25pkS+rDyyrNyKgrRuLAdXrZ71a8 2xBzWWSLSLkdEHfL865JiLpMbvNFYV1oVH1k6dcp5zMYvZRwfPLGdcXMJbnbDDHKPyAy eJesSGH6GoTb2fR9QXFZYx0fsUtwDnZ2pMzAPHn/WzR8lSWnp81y/GBpxvg1X0Z3aBY6 BovrWRDwSm6DEpme3fnL8CvneCpdzlj7Iuj3IpjAc4BbZraDgAxriZN2xAwIjeJ/zq/T z7FA== X-Gm-Message-State: AOAM531xiTPN8EBtY9+Jkmq350OxAw3x+8SXNoF4UP0642w6OsSWyaOl ZC/hl3qkip8CuL9emSqiTVG5XQ== X-Google-Smtp-Source: ABdhPJwUGuw/olo0NQ+3jI3fshHSfEURm9sit3pjcxyIdakH1k4Of92wXKR2ERTDKbgL+HE+ZoRYzw== X-Received: by 2002:a05:6a00:994:b0:4c9:d2a4:c5af with SMTP id u20-20020a056a00099400b004c9d2a4c5afmr9093566pfg.73.1643145044900; Tue, 25 Jan 2022 13:10:44 -0800 (PST) Received: from google.com ([2620:15c:211:202:b678:e713:1931:1231]) by smtp.gmail.com with ESMTPSA id l17sm7899369pfu.61.2022.01.25.13.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 13:10:43 -0800 (PST) Date: Tue, 25 Jan 2022 13:10:34 -0800 From: Nick Desaulniers To: Alexander Sverdlin Cc: linux-arm-kernel@lists.infradead.org, Hartley Sweeten , Russell King , Nikita Shubin , Arnd Bergmann , linux-kernel@vger.kernel.org, kernel test robot , stable@vger.kernel.org Subject: Re: [PATCH] ep93xx: clock: Fix UAF in ep93xx_clk_register_gate() Message-ID: References: <20220120133739.4170298-1-alexander.sverdlin@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220120133739.4170298-1-alexander.sverdlin@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220125_131046_440944_7B706713 X-CRM114-Status: GOOD ( 20.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 20, 2022 at 02:37:38PM +0100, Alexander Sverdlin wrote: > arch/arm/mach-ep93xx/clock.c:151:2: note: Taking true branch > if (IS_ERR(clk)) > ^ > arch/arm/mach-ep93xx/clock.c:152:3: note: Memory is released > kfree(psc); > ^~~~~~~~~~ > arch/arm/mach-ep93xx/clock.c:154:2: note: Use of memory after it is freed > return &psc->hw; > ^ ~~~~~~~~ > > Link: https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/B5YCO2NJEXINCYE26Y255LCVMO55BGWW/ > Reported-by: kernel test robot > Fixes: 9645ccc7bd7a ("ep93xx: clock: convert in-place to COMMON_CLK") > Cc: stable@vger.kernel.org > Signed-off-by: Alexander Sverdlin > --- > arch/arm/mach-ep93xx/clock.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-ep93xx/clock.c b/arch/arm/mach-ep93xx/clock.c > index cc75087134d3..4aee14f18123 100644 > --- a/arch/arm/mach-ep93xx/clock.c > +++ b/arch/arm/mach-ep93xx/clock.c > @@ -148,8 +148,10 @@ static struct clk_hw *ep93xx_clk_register_gate(const char *name, > psc->lock = &clk_lock; > > clk = clk_register(NULL, &psc->hw); > - if (IS_ERR(clk)) > + if (IS_ERR(clk)) { > kfree(psc); > + return (void *)clk; Prefer ERR_CAST to the raw cast. I think that's nicer when we're already using the IS_ERR macros. > + } > > return &psc->hw; > } > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 295F1C433EF for ; Tue, 25 Jan 2022 21:11:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233004AbiAYVKx (ORCPT ); Tue, 25 Jan 2022 16:10:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232969AbiAYVKp (ORCPT ); Tue, 25 Jan 2022 16:10:45 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1160C06173B for ; Tue, 25 Jan 2022 13:10:45 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id a8so15557348pfa.6 for ; Tue, 25 Jan 2022 13:10:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oTajAjIFl5J5w/Rcv1Jq4D73n55d0RoAmCIghJOGibE=; b=ZKQNRGS2URon4bqAWx+sEDzRBBpV7Xe9BsY8G3Bdj8hiy3srRL2yAOY3wK3xdUHbhQ 0GtR6dOnpon+k8KnmSACtLufwTDy8gBHWQiYf1LxuujlpoIUIvFaithyoKebbgqHAIQt 3OZ+maPPLrzfTBfnzn5AE1b9pD2OhRxS81rImxOS8w3w6bbeV2gqEsWDYyZgUd4RHk/O ksrFBe9LlcwVzOiS0aUVrPn9lht/QyihBJGQsf4n9LXqyuOmIKcOOYjjiY0r4a8Frtm0 Oh5+AWbbeo7rLoq6Is1010UTApCBKXhUIR18eR8fHEwLOJ8PzQAsxxp7brbXxAStC6+s g27A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oTajAjIFl5J5w/Rcv1Jq4D73n55d0RoAmCIghJOGibE=; b=hwt2q97sJ8LXL5uZjUMA6huyQcLQSPGkvW6BaWEaat7UAs+PqXF4LDPO38CQui44vK WR0T8vG2wft/4rZ4m3qGBAOrq7GMfHngog2uNRKjGrs1s242f6wcrWInA/S3alBwQu0Q xIHmJ3hlIsdwdsa0sOh4Cj07n0SFVxfDqGYup9jcjCKoNNME/668JqRGvXdx+MWT25VA L8Ix0hBizUoNRhqCRrJTlqw8beM60WzGOEmTuqR8gDCrPJUAR98Y7SLdM+A9EcBnuEOl SCOqJk0u+/tKPCL5DjOn9k3kb3J0dBA7iu6KUiP1Ch1ehHWwkL4W8j0rAJTruus8XNMf 6efA== X-Gm-Message-State: AOAM533OW4D3v1jFVqzNzquVvZexyctv2XRcWYHOgZUrkW7TUdv9yhAF 6UmBL474SM99OB36MHjOhSE6Eg== X-Google-Smtp-Source: ABdhPJwUGuw/olo0NQ+3jI3fshHSfEURm9sit3pjcxyIdakH1k4Of92wXKR2ERTDKbgL+HE+ZoRYzw== X-Received: by 2002:a05:6a00:994:b0:4c9:d2a4:c5af with SMTP id u20-20020a056a00099400b004c9d2a4c5afmr9093566pfg.73.1643145044900; Tue, 25 Jan 2022 13:10:44 -0800 (PST) Received: from google.com ([2620:15c:211:202:b678:e713:1931:1231]) by smtp.gmail.com with ESMTPSA id l17sm7899369pfu.61.2022.01.25.13.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 13:10:43 -0800 (PST) Date: Tue, 25 Jan 2022 13:10:34 -0800 From: Nick Desaulniers To: Alexander Sverdlin Cc: linux-arm-kernel@lists.infradead.org, Hartley Sweeten , Russell King , Nikita Shubin , Arnd Bergmann , linux-kernel@vger.kernel.org, kernel test robot , stable@vger.kernel.org Subject: Re: [PATCH] ep93xx: clock: Fix UAF in ep93xx_clk_register_gate() Message-ID: References: <20220120133739.4170298-1-alexander.sverdlin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220120133739.4170298-1-alexander.sverdlin@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 20, 2022 at 02:37:38PM +0100, Alexander Sverdlin wrote: > arch/arm/mach-ep93xx/clock.c:151:2: note: Taking true branch > if (IS_ERR(clk)) > ^ > arch/arm/mach-ep93xx/clock.c:152:3: note: Memory is released > kfree(psc); > ^~~~~~~~~~ > arch/arm/mach-ep93xx/clock.c:154:2: note: Use of memory after it is freed > return &psc->hw; > ^ ~~~~~~~~ > > Link: https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/B5YCO2NJEXINCYE26Y255LCVMO55BGWW/ > Reported-by: kernel test robot > Fixes: 9645ccc7bd7a ("ep93xx: clock: convert in-place to COMMON_CLK") > Cc: stable@vger.kernel.org > Signed-off-by: Alexander Sverdlin > --- > arch/arm/mach-ep93xx/clock.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-ep93xx/clock.c b/arch/arm/mach-ep93xx/clock.c > index cc75087134d3..4aee14f18123 100644 > --- a/arch/arm/mach-ep93xx/clock.c > +++ b/arch/arm/mach-ep93xx/clock.c > @@ -148,8 +148,10 @@ static struct clk_hw *ep93xx_clk_register_gate(const char *name, > psc->lock = &clk_lock; > > clk = clk_register(NULL, &psc->hw); > - if (IS_ERR(clk)) > + if (IS_ERR(clk)) { > kfree(psc); > + return (void *)clk; Prefer ERR_CAST to the raw cast. I think that's nicer when we're already using the IS_ERR macros. > + } > > return &psc->hw; > } > -- > 2.34.1 >