From: Tony Lu <tonylu@linux.alibaba.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: kgraul@linux.ibm.com, kuba@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [RFC PATCH net-next 0/6] net/smc: Spread workload over multiple cores
Date: Wed, 26 Jan 2022 15:23:22 +0800 [thread overview]
Message-ID: <YfD26mhGkM9DFBV+@TonyMac-Alibaba> (raw)
In-Reply-To: <YePesYRnrKCh1vFy@unreal>
On Sun, Jan 16, 2022 at 11:00:33AM +0200, Leon Romanovsky wrote:
>
> Please CC RDMA mailing list next time.
>
> Why didn't you use already existed APIs in drivers/infiniband/core/cq.c?
> ib_cq_pool_get() will do most if not all of your open-coded CQ spreading
> logic.
I am working on replacing with ib_cq_pool_get(), this need ib_poll_context
to indicate the poller which provides by ib_poll_handler(). It's okay
for now, but for the callback function. When it polled a ib_wc, it
would call wc->wr_cqe->done(cq, wc), which is the union with wr_id. The
wr_id is heavily used in SMC.
In this patch set, I am not going to change the logic which is out of cq
allocation. So I have to use original interface to allocate cq this
time.
I am glad to hear your advice, if I missed information or misunderstood.
Thanks,
Tony Lu
next prev parent reply other threads:[~2022-01-26 7:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 5:48 [RFC PATCH net-next 0/6] net/smc: Spread workload over multiple cores Tony Lu
2022-01-14 5:48 ` [RFC PATCH net-next 1/6] net/smc: Spread CQs to differents completion vectors Tony Lu
2022-01-14 5:48 ` [RFC PATCH net-next 2/6] net/smc: Prepare for multiple CQs per IB devices Tony Lu
2022-01-14 5:48 ` [RFC PATCH net-next 3/6] net/smc: Introduce smc_ib_cq to bind link and cq Tony Lu
2022-01-14 5:48 ` [RFC PATCH net-next 4/6] net/smc: Multiple CQs per IB devices Tony Lu
2022-01-14 5:48 ` [RFC PATCH net-next 5/6] net/smc: Unbind buffer size from clcsock and make it tunable Tony Lu
2022-01-14 9:13 ` kernel test robot
2022-01-14 9:43 ` kernel test robot
2022-01-14 5:48 ` [RFC PATCH net-next 6/6] net/smc: Introduce tunable linkgroup max connections Tony Lu
2022-01-16 9:00 ` [RFC PATCH net-next 0/6] net/smc: Spread workload over multiple cores Leon Romanovsky
2022-01-16 17:47 ` Tony Lu
2022-01-26 7:23 ` Tony Lu [this message]
2022-01-26 15:28 ` Jason Gunthorpe
2022-01-27 3:14 ` Tony Lu
2022-01-27 6:21 ` Leon Romanovsky
2022-01-27 7:59 ` Tony Lu
2022-01-27 8:47 ` Leon Romanovsky
2022-01-27 9:14 ` Tony Lu
2022-01-27 9:25 ` Leon Romanovsky
2022-01-27 9:50 ` Tony Lu
2022-01-27 14:52 ` Karsten Graul
2022-01-28 6:55 ` Tony Lu
2022-02-01 16:50 ` Karsten Graul
2022-02-09 9:49 ` Tony Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfD26mhGkM9DFBV+@TonyMac-Alibaba \
--to=tonylu@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.