All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, pure.logic@nexus-software.ie,
	greg@kroah.com, robh@kernel.org, linux-kernel@vger.kernel.org,
	quic_tsoni@quicinc.com, quic_psodagud@quicinc.com,
	quic_satyap@quicinc.com, quic_pheragu@quicinc.com,
	quic_rjendra@quicinc.com, quic_sibis@quicinc.com,
	quic_saipraka@quicinc.com
Subject: Re: [PATCH V4 2/6] bindings: usb: dwc3: Update dwc3 properties for EUD connector
Date: Tue, 25 Jan 2022 22:21:20 -0600	[thread overview]
Message-ID: <YfDMQIFiCfzQy91y@builder.lan> (raw)
In-Reply-To: <7ddaf7dc192c5f03f70d27297551e758a39a4ab5.1642768837.git.quic_schowdhu@quicinc.com>

On Fri 21 Jan 07:53 CST 2022, Souradeep Chowdhury wrote:

> Add the ports property for dwc3 node. This port can be used
> by the Embedded USB Debugger for role switching the controller
> from device to host mode and vice versa.
> 
> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index d29ffcd..ccb1236 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -332,6 +332,16 @@ properties:
>      items:
>        enum: [1, 4, 8, 16, 32, 64, 128, 256]
>  
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +    description:
> +      This port is to be attached to the endpoint of the Embedded USB Debugger.

More generally this is used together with the already documented
usb-role-switch property to connect the dwc3 to the Type-C connector.

Which makes me feel that we don't actually need ports/port, but could do
with just port? Perhaps I'm missing some usecase?


I'm somewhat confused to why this isn't already documented...

Regards,
Bjorn

> +
> +    properties:
> +      port@0:
> +        $ref: /schemas/graph.yaml#/properties/port
> +        description: Connector endpoint of Embedded USB debugger.
> +
>  unevaluatedProperties: false
>  
>  required:
> -- 
> 2.7.4
> 

  reply	other threads:[~2022-01-26  4:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-21 13:53 [PATCH V4 0/6] Add Embedded USB Debugger (EUD) driver Souradeep Chowdhury
2022-01-21 13:53 ` [PATCH V4 1/6] dt-bindings: Add the yaml bindings for EUD Souradeep Chowdhury
2022-01-26  4:22   ` Bjorn Andersson
2022-01-21 13:53 ` [PATCH V4 2/6] bindings: usb: dwc3: Update dwc3 properties for EUD connector Souradeep Chowdhury
2022-01-26  4:21   ` Bjorn Andersson [this message]
2022-01-27 10:58     ` Souradeep Chowdhury
2022-01-21 13:53 ` [PATCH V4 3/6] soc: qcom: eud: Add driver support for Embedded USB Debugger(EUD) Souradeep Chowdhury
2022-01-26  4:47   ` Bjorn Andersson
2022-01-27 12:01     ` Souradeep Chowdhury
2022-01-28 16:11       ` Bjorn Andersson
2022-01-31  5:49         ` Souradeep Chowdhury
2022-01-26  9:30   ` Greg KH
2022-01-27 12:04     ` Souradeep Chowdhury
2022-01-21 13:53 ` [PATCH V4 4/6] arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector Souradeep Chowdhury
2022-01-26  4:28   ` Bjorn Andersson
2022-01-27 11:00     ` Souradeep Chowdhury
2022-01-21 13:53 ` [PATCH V4 5/6] arm64: dts: qcom: sc7280: Set the default dr_mode for usb2 Souradeep Chowdhury
2022-01-26  4:29   ` Bjorn Andersson
2022-01-21 13:53 ` [PATCH V4 6/6] MAINTAINERS: Add maintainer entry for EUD Souradeep Chowdhury
2022-01-26  4:29   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfDMQIFiCfzQy91y@builder.lan \
    --to=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=greg@kroah.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pure.logic@nexus-software.ie \
    --cc=quic_pheragu@quicinc.com \
    --cc=quic_psodagud@quicinc.com \
    --cc=quic_rjendra@quicinc.com \
    --cc=quic_saipraka@quicinc.com \
    --cc=quic_satyap@quicinc.com \
    --cc=quic_schowdhu@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=quic_tsoni@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.