From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Wander Costa <wcosta@redhat.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jon Hunter <jonathanh@nvidia.com>,
Jiri Slaby <jirislaby@kernel.org>,
Wander Lairson Costa <wander@redhat.com>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
Johan Hovold <johan@kernel.org>, Andrew Jeffery <andrew@aj.id.au>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] tty: serial: Use fifo in 8250 console driver
Date: Wed, 26 Jan 2022 09:52:26 +0100 [thread overview]
Message-ID: <YfELyq5AmxiZxjme@kroah.com> (raw)
In-Reply-To: <CAAq0SU=U3UY+DUdd1fjj25Yt_QZriShZTSFTsq5B4tPnOYhQvQ@mail.gmail.com>
On Tue, Jan 25, 2022 at 03:40:36PM -0300, Wander Costa wrote:
> On Tue, Jan 25, 2022 at 1:56 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Tue, Jan 25, 2022 at 06:53:48PM +0200, Andy Shevchenko wrote:
> > > On Tue, Jan 25, 2022 at 12:40:27PM +0000, Jon Hunter wrote:
> > > > On 25/01/2022 10:29, Wander Costa wrote:
> >
> > ...
> >
> > > > Andy, does this work for X86?
> > >
> > > Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > >
> > > No, it does NOT fix an issue (I see it on a handful x86) with the legacy UART
> > > (means the 8250_pnp is in use). And I believe the same will be the case on LPSS
> > > ones (8250_dw / 8250_lpss) and HSU (8250_mid), because the patch influences on
> > > all of them.
> >
> > Shall I send a revert and we can continue with a new approach later on?
> >
>
> Tomorrow (or maybe after tomorrow) I am going to post the fixes I
> already have, and an additional patch adding a build option
> (disabled to default) so people maybe if they want to use the FIFO on
> console write. But I understand if people decide to go
> ahead and revert the patch.
Let me revert this for now. And no new config options please, this
should "just work".
thanks,
greg k-h
next prev parent reply other threads:[~2022-01-26 8:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 20:14 [PATCH] tty: serial: Use fifo in 8250 console driver wander
[not found] ` <CAHp75VeZBp4gKvGBDzaD=EpGRDZ1-wTvD8K9Ui6Q59kDjmkXmQ@mail.gmail.com>
2021-11-01 15:22 ` Wander Costa
2021-11-01 15:32 ` Andy Shevchenko
2021-11-10 12:10 ` Wander Costa
2021-11-12 11:58 ` David Laight
2022-01-25 8:39 ` Jon Hunter
2022-01-25 8:50 ` Greg Kroah-Hartman
2022-01-25 9:03 ` Jon Hunter
2022-01-25 9:08 ` Jiri Slaby
2022-01-25 9:36 ` Jiri Slaby
2022-01-25 10:06 ` Jon Hunter
2022-01-25 10:29 ` Wander Costa
2022-01-25 12:40 ` Jon Hunter
2022-01-25 16:53 ` Andy Shevchenko
2022-01-25 16:54 ` Andy Shevchenko
2022-01-25 18:40 ` Wander Costa
2022-01-26 8:52 ` Greg Kroah-Hartman [this message]
2022-01-26 12:09 ` Andy Shevchenko
2022-01-26 13:23 ` Wander Costa
2022-01-26 13:34 ` Andy Shevchenko
2022-01-27 18:10 ` Theodore Y. Ts'o
2022-01-25 10:18 ` Wander Costa
2022-01-25 10:38 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfELyq5AmxiZxjme@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew@aj.id.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=wander@redhat.com \
--cc=wcosta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.