From: Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: liugaoxiang@huawei.com, dev@dpdk.org,
Gaoxiang Liu <gaoxiangliu0@163.com>
Subject: Re: [PATCH] mbuf: delete dynamic fields copy in hdr copy
Date: Wed, 26 Jan 2022 14:13:34 +0100 [thread overview]
Message-ID: <YfFI/lkFEJoKNu4f@platinum> (raw)
In-Reply-To: <1737658.3VsfAaAtOV@thomas>
Hi,
On Tue, Jan 11, 2022 at 05:45:49PM +0100, Thomas Monjalon wrote:
> 14/12/2021 08:56, Gaoxiang Liu:
> > Because dynamic fields are registered by the DPDK application,
> > so it is up to the application to decide whether to copy the value of
> > dynamic fields.
> > So delete dynamic fields copy in __rte_pktmbuf_copy_hdr.
> > It's more flexible for the DPDK application,
> > and is useful for improving performance.
>
> Yes, removing operations will improve the performance,
> but it looks wrong.
> This is copying all dynamic fields, not matter which one is registered.
> We cannot ask the application to manage dynamic fields copy,
> especially if the copy is done inside a library.
+1
Dynamic fields/flags can be registered by applications, libraries,
drivers, ...
There is no entity that is aware of which field/flag has to be copied,
so the only possibility is to copy all of them.
prev parent reply other threads:[~2022-01-26 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 7:56 [PATCH] mbuf: delete dynamic fields copy in hdr copy Gaoxiang Liu
2022-01-11 16:45 ` Thomas Monjalon
2022-01-26 13:13 ` Olivier Matz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfFI/lkFEJoKNu4f@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=gaoxiangliu0@163.com \
--cc=liugaoxiang@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.