From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>,
linux-sgx@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
stable@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Jethro Beekman <jethro@fortanix.com>,
Sean Christopherson <seanjc@google.com>
Subject: Re: [PATCH v3] x86/sgx: Free backing memory after faulting the enclave page
Date: Wed, 26 Jan 2022 15:31:59 +0200 [thread overview]
Message-ID: <YfFNT4P27vdxNo7G@iki.fi> (raw)
In-Reply-To: <b01342c0-97c8-a29e-d172-d53d051b683c@intel.com>
On Mon, Jan 24, 2022 at 09:17:32AM -0800, Dave Hansen wrote:
> On 1/12/22 22:08, Reinette Chatre wrote:
> > ------------[ cut here ]------------
> > ELDU returned 9 (0x9)
> > WARNING: CPU: 6 PID: 2470 at arch/x86/kernel/cpu/sgx/encl.c:77 sgx_encl_eldu+0x37c/0x3f0
>
> Could we flesh out that error message, please?
>
> That "return" is a code from "Information and Error Codes" in the SGX SDM
> chapter. It's also spelled out in 'enum sgx_return_code'. So, at least,
> this should probably say:
>
> ELDU sgx_return_code: 9 (0x9)
>
> *That* is at least greppable.
Yes, I'm all for adding sgx_ prefix to everything but should it rather
be "sgx: ELDU ..." like most of everything else?
/Jarkko
next prev parent reply other threads:[~2022-01-26 13:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 14:05 [PATCH v3] x86/sgx: Free backing memory after faulting the enclave page Jarkko Sakkinen
2022-01-13 6:08 ` Reinette Chatre
2022-01-14 21:25 ` Jarkko Sakkinen
2022-01-17 8:30 ` Jarkko Sakkinen
2022-01-24 17:17 ` Dave Hansen
2022-01-26 13:31 ` Jarkko Sakkinen [this message]
2022-01-27 7:01 ` Jarkko Sakkinen
2022-01-31 23:30 ` Dave Hansen
2022-02-20 18:52 ` Jarkko Sakkinen
2022-02-20 18:58 ` Dave Hansen
2022-02-20 20:09 ` Jarkko Sakkinen
2022-02-20 20:42 ` Jarkko Sakkinen
2022-02-22 0:15 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfFNT4P27vdxNo7G@iki.fi \
--to=jarkko@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jethro@fortanix.com \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.