From: Andrew Lunn <andrew@lunn.ch>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
Madalin Bucur <madalin.bucur@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 5/5] dt-bindings: net: xgmac_mdio: Add "clock-frequency" and "suppress-preamble"
Date: Wed, 26 Jan 2022 14:36:52 +0100 [thread overview]
Message-ID: <YfFOdGa7iVFQK7EZ@lunn.ch> (raw)
In-Reply-To: <20220126101432.822818-6-tobias@waldekranz.com>
On Wed, Jan 26, 2022 at 11:14:32AM +0100, Tobias Waldekranz wrote:
> The driver now supports the standard "clock-frequency" and
> "suppress-preamble" properties, do document them in the binding
> description.
>
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
However, you could convert to yaml as well, if you wanted.
> +- clocks
> + Usage: optional
> + Value type: <phandle>
> + Definition: A reference to the input clock of the controller
> + from which the MDC frequency is derived.
That answers my question. However, in the presence of a
'clock-frequency' property it cannot be optional, so -ENODEV seems
reasonable if it is missing. Potentially you also need to handle
-EPROBE_DEFER, although it seems quiet unlikely for an internal SoC
clock.
Andrew
prev parent reply other threads:[~2022-01-26 13:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220126101432.822818-1-tobias@waldekranz.com>
2022-01-26 10:14 ` [PATCH net-next 1/5] dt-bindings: net: xgmac_mdio: Remove unsupported "bus-frequency" Tobias Waldekranz
2022-01-26 13:31 ` Andrew Lunn
2022-01-26 10:14 ` [PATCH net-next 2/5] net/fsl: xgmac_mdio: Use managed device resources Tobias Waldekranz
2022-01-26 13:08 ` Andrew Lunn
2022-01-26 10:14 ` [PATCH net-next 3/5] net/fsl: xgmac_mdio: Support preamble suppression Tobias Waldekranz
2022-01-26 13:08 ` Andrew Lunn
2022-01-26 10:14 ` [PATCH net-next 4/5] net/fsl: xgmac_mdio: Support setting the MDC frequency Tobias Waldekranz
2022-01-26 13:07 ` Andrew Lunn
2022-01-26 13:30 ` Tobias Waldekranz
2022-01-26 14:02 ` Andrew Lunn
2022-01-26 10:14 ` [PATCH net-next 5/5] dt-bindings: net: xgmac_mdio: Add "clock-frequency" and "suppress-preamble" Tobias Waldekranz
2022-01-26 13:36 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfFOdGa7iVFQK7EZ@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.