From: Greg KH <gregkh@linuxfoundation.org>
To: "Aleksa Vučković" <aleksav013@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] drivers: dio: fixed spaces to tabs coding style issue
Date: Wed, 26 Jan 2022 18:52:29 +0100 [thread overview]
Message-ID: <YfGKXeHFSn+NK6fK@kroah.com> (raw)
In-Reply-To: <20220125103310.13893-1-aleksav013@gmail.com>
On Tue, Jan 25, 2022 at 11:33:07AM +0100, Aleksa Vučković wrote:
> Converting spaces to tabs.
>
> Signed-off-by: Aleksa Vučković <aleksav013@gmail.com>
> ---
> drivers/dio/dio.c | 120 +++++++++++++++++++++++-----------------------
> 1 file changed, 60 insertions(+), 60 deletions(-)
Your patches add coding style issues, not a good idea when trying to do
code cleanup.
Always run checkpatch on your patches before submitting them. As-is, I
can not take these.
thanks,
greg k-h
prev parent reply other threads:[~2022-01-26 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 10:33 [PATCH 1/4] drivers: dio: fixed spaces to tabs coding style issue Aleksa Vučković
2022-01-25 10:33 ` [PATCH 2/4] drivers: dio: Fixed unwanted spaces " Aleksa Vučković
2022-01-25 10:33 ` [PATCH 3/4] drivers: dio: Fixed braces " Aleksa Vučković
2022-01-25 10:33 ` [PATCH 4/4] drivers: dio: Fixed spaces " Aleksa Vučković
2022-01-26 17:52 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfGKXeHFSn+NK6fK@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aleksav013@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.