From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F382C433EF for ; Thu, 27 Jan 2022 06:35:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236800AbiA0Gf5 (ORCPT ); Thu, 27 Jan 2022 01:35:57 -0500 Received: from mga17.intel.com ([192.55.52.151]:55342 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236813AbiA0Gf4 (ORCPT ); Thu, 27 Jan 2022 01:35:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643265356; x=1674801356; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qfCEG17eUg1nUtn5Bjyg0zcAkUJsBlQnqzVAjVIbB6I=; b=XXP7IbrkI9V1VOrSDVgU7kEFa4uvcu3eTeQz/NLhMlt1mggrUpwvXOze 1IEn49C+gJe2OUaxP9CDH6O8MPG5U1ootk6poAlgTt+9kkTjpjdBo9YXm sUPTWk/DkyvMHp9xcuALH2K6Sv1KLf/uzcogBXhGlJG8x0f18DRAoH/v7 ZtMA6VY24IqA2SbpueKLpp3Gxy5Uh1jra5HzpIf0Xa6WcLlFQf0GUJLlH M5TCGNH3+9E/sJvilcrL+zSZNd7cKW+kZ3Md/ileNXXsmhV+WEPBJOjD5 wOhWC4slpGRYew4cvkm4q5DIYciwX6udKnUdG3ITRZJh85BnVGpUyaB5r g==; X-IronPort-AV: E=McAfee;i="6200,9189,10239"; a="227437977" X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="227437977" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2022 22:35:55 -0800 X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="477753942" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.162]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2022 22:35:51 -0800 Received: by lahna (sSMTP sendmail emulation); Thu, 27 Jan 2022 08:35:27 +0200 Date: Thu, 27 Jan 2022 08:35:27 +0200 From: Mika Westerberg To: Kai-Heng Feng Cc: bhelgaas@google.com, koba.ko@canonical.com, Russell Currey , Oliver O'Halloran , Lalithambika Krishnakumar , Joerg Roedel , Lu Baolu , linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] PCI/AER: Disable AER when link is in L2/L3 ready, L2 and L3 state Message-ID: References: <20220126071853.1940111-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Jan 27, 2022 at 08:29:22AM +0200, Mika Westerberg wrote: > > For example, should we convert commit a697f072f5da8 ("PCI: Disable PTM > > during suspend to save power") to PM hooks in PTM service? > > Yes, I think that's the right thing to do. I wonder how it was not using > the PM hooks in the first place. Actually no. The reason it is not using PM hooks is that PTM is not a port "service" so it needs to be dealt in the core. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6462FC433F5 for ; Thu, 27 Jan 2022 06:37:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JkrVk6vhGz30gk for ; Thu, 27 Jan 2022 17:37:34 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=nSaQA61T; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=mika.westerberg@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=nSaQA61T; dkim-atps=neutral Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JkrV20d9Gz2xY3 for ; Thu, 27 Jan 2022 17:36:57 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643265418; x=1674801418; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qfCEG17eUg1nUtn5Bjyg0zcAkUJsBlQnqzVAjVIbB6I=; b=nSaQA61TbwMY4YkSv2MZVPM3YQYVIMKlfXPwVcIEh9FLwQeMWytKW9Rl RX0W7NsI4pZh9mS/ZvkOzFJZD84G1idx/UE9M1IMOPm9JAMho/AeyH8Dd tu4fWB2+xtnCh7U9xQF/4yLZY546TKRe/RQUbzJXdkahwbsMfyXGKs76i ZT/ncWcGFb6xhUcfEO/BzVq1ttH7Tmc1IcFdTsqbVnvwnOfKba7IE7ObV a2OKf9oNrjvsVKenNjovpHakEcuaLY+X2T0GTB4QvELXEYp9QhQVFr7S4 amQoOAGbDW/R7HF1+ca4pTRitJ1h+ODUAkSwPaYtTvAdTOiWGsEushrqd g==; X-IronPort-AV: E=McAfee;i="6200,9189,10239"; a="234139050" X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="234139050" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2022 22:35:55 -0800 X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="477753942" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.162]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2022 22:35:51 -0800 Received: by lahna (sSMTP sendmail emulation); Thu, 27 Jan 2022 08:35:27 +0200 Date: Thu, 27 Jan 2022 08:35:27 +0200 From: Mika Westerberg To: Kai-Heng Feng Subject: Re: [PATCH 1/2] PCI/AER: Disable AER when link is in L2/L3 ready, L2 and L3 state Message-ID: References: <20220126071853.1940111-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg Roedel , Lalithambika Krishnakumar , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, koba.ko@canonical.com, Oliver O'Halloran , bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org, Lu Baolu Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Jan 27, 2022 at 08:29:22AM +0200, Mika Westerberg wrote: > > For example, should we convert commit a697f072f5da8 ("PCI: Disable PTM > > during suspend to save power") to PM hooks in PTM service? > > Yes, I think that's the right thing to do. I wonder how it was not using > the PM hooks in the first place. Actually no. The reason it is not using PM hooks is that PTM is not a port "service" so it needs to be dealt in the core.