From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 946E1C433EF for ; Thu, 27 Jan 2022 16:53:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643302392; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bi1jDGk5Oolvd5+1NAnhk5yxxGSghfmVYHG4suC9V5E=; b=X/QXvKR7cVpZc0cdft1OKx6DyMDOmooNjKyEgS8tZH9MKblQPHAibnRKwphswfmSeYOVx8 N1zePdzfIKJjsRzssaAR5oK3Rd+lbYeaRBp9vYKL57hCOyO9E4WYQeaKTG5svP5+7PqnH0 VIEgN4aPNfYzT+FQBNVX2a7f5wGdd8k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-570-HqHdhmo7OnWsLxxjORuv5Q-1; Thu, 27 Jan 2022 11:53:08 -0500 X-MC-Unique: HqHdhmo7OnWsLxxjORuv5Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B39942FD1F; Thu, 27 Jan 2022 16:53:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D38A7A40A; Thu, 27 Jan 2022 16:53:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E9EE51809CB8; Thu, 27 Jan 2022 16:52:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20RGqtAa018736 for ; Thu, 27 Jan 2022 11:52:55 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4F8D614582F9; Thu, 27 Jan 2022 16:52:55 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B73614582FA for ; Thu, 27 Jan 2022 16:52:55 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3273928EB2C4 for ; Thu, 27 Jan 2022 16:52:55 +0000 (UTC) Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-16-NsgEeC8_PYevo0bub8KUVg-1; Thu, 27 Jan 2022 11:52:53 -0500 X-MC-Unique: NsgEeC8_PYevo0bub8KUVg-1 Received: by mail-qv1-f69.google.com with SMTP id kc19-20020a056214411300b00422b7cdea6eso3644251qvb.19 for ; Thu, 27 Jan 2022 08:52:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AGOKQqcuQhkDwTPU+rhG3/lUwVIbdjyWIj81munfXW0=; b=ma/YTtdHUwZL2IBM/151auJpUD6FSqOG4/gTEOvj5We72ZQwDvMjL6Pl61KPDj8GSp VplBVRkWFp9ZT7AkMswNSROabZGFgL/1+iRXgoz6WfLW2pVYpXdiQ6p7/QOc9ZHaABYq 7OU9cB9900qWWG7zC5vbF8+1AVxs5Dkote3pLb7THpcKTjV70cj22z09auPADTGRn2G5 llTvAgIuWxMiLQtiuWJliQ1f1/UQovMHTr+X1rnHvc8Yp9Q6lV5N5m/kNhs1PiVXp0gl c+VDN+JtoqD4opny8z99uqYWeju6oysfVmYH3OabFj9JDq8D0wOYu94K9W15+2/ZOZa3 z+Gw== X-Gm-Message-State: AOAM533wXxteUfAV3V6gq3uRblZvn3Hyu7TfWiWzqwWLAUNKJOArE0ZF yoxOliG2/G8tosCoZ2pPth+jRFOcqJvNnILRaqwTSITrZVx+rz+p36jZJ5NGZXP7AMh1uSYbODc QGiJj36Oupjay5w== X-Received: by 2002:a0c:fa09:: with SMTP id q9mr4322355qvn.21.1643302373427; Thu, 27 Jan 2022 08:52:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJw2rtqqWw8vSSkq/pAGCHoYHXJ1BiURlAQlul/eODmSBNf8OGMbqxmxG8mMS7PpEMI9YH9jUw== X-Received: by 2002:a0c:fa09:: with SMTP id q9mr4322338qvn.21.1643302373224; Thu, 27 Jan 2022 08:52:53 -0800 (PST) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id y15sm826432qtx.28.2022.01.27.08.52.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jan 2022 08:52:52 -0800 (PST) Date: Thu, 27 Jan 2022 11:52:51 -0500 From: Mike Snitzer To: Christoph Hellwig Message-ID: References: <20220127063546.1314111-1-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20220127063546.1314111-1-hch@lst.de> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Philipp Reisner , linux-block@vger.kernel.org, dm-devel@redhat.com, Lars Ellenberg , Pavel Begunkov , drbd-dev@lists.linbit.com Subject: Re: [dm-devel] improve the bio cloning interface X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Jan 27 2022 at 1:35P -0500, Christoph Hellwig wrote: > Hi Jens, > > this series changes the bio cloning interface to match the rest changes > to the bio allocation interface and passes the block_device and operation > to the cloning helpers. In addition it renames the cloning helpers to > be more descriptive. > > To get there it requires a bit of refactoring in the device mapper code. I'd like to take a closer look, do you happen to have this series available in a git branch? The changes generally look fine. Any chance you could forecast what you're planning for follow-on changes? Or is it best to just wait for you to produce those follow-on changes? Thanks, Mike -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10AD3C433F5 for ; Thu, 27 Jan 2022 16:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244023AbiA0Qw4 (ORCPT ); Thu, 27 Jan 2022 11:52:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:45149 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234331AbiA0Qw4 (ORCPT ); Thu, 27 Jan 2022 11:52:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643302375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AGOKQqcuQhkDwTPU+rhG3/lUwVIbdjyWIj81munfXW0=; b=VmRpdIyd0xvMY5AG/PvMJ/LgB5XpiN9VoyU1eK07v8Qcv2mLjq3PAYKzlXy6rbI9lRes52 pb5Kv/kv8KZycePenDYmxBNn6NWaDK7E9Rjb1TA2izv/3Nw3mRD+8B/GFzCzGMmToFhhNC rab+AKj8XSjkSmDJEFmSWfZkGTRLP5M= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-208-xW7JUHUMNIGcQq2PtTfKMg-1; Thu, 27 Jan 2022 11:52:53 -0500 X-MC-Unique: xW7JUHUMNIGcQq2PtTfKMg-1 Received: by mail-qk1-f197.google.com with SMTP id g3-20020a05620a108300b0047e16fc0d6cso2813111qkk.3 for ; Thu, 27 Jan 2022 08:52:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AGOKQqcuQhkDwTPU+rhG3/lUwVIbdjyWIj81munfXW0=; b=TMgZbhpvKaIbJpHk3uV5P1QYDkhf8Pekm5qo8En5qbhxNsXj6fH4f4ctbX+PXVLWmM /OSMcjDojzrbFnHt9EUT9pBfjgMEAz5nyXkfkR7UvAHEP+6hS1hwoj87LG1eYKjw3hzZ x+SdRqi/7Xnd2LK1J5wDeQ7m4Mq0AehABTOht/bd7rImRcUwceNlpIRPZWoeJQWZBFmT 6auZiJbLNKLx8Wy5Z4XkU+bz89Gut20hcBp3UPDsgC9Hdz6dmHrFMBwkNMQUL4hdhLXv FLT/sK6ERcmETZlXEemWaqb4B7g6P/NFiv0ijl21ENl8/r8bH9ASLg7DR4Cnf4SgkYx7 Fp9g== X-Gm-Message-State: AOAM5334WUAMc8Y7bjmf4H6VrjnJWNN6pq/VFoln2mHTs/2LiAqINo/2 5hUtdi41kqelWTLl1V14cJ1KaC8vKbBOe+2y+RGSvTIraEWrbYoDtA15ooVu7qXOFadJNjLV1kz HqTyk3Be/Ybjgi0GAAUD2qA== X-Received: by 2002:a0c:fa09:: with SMTP id q9mr4322350qvn.21.1643302373426; Thu, 27 Jan 2022 08:52:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJw2rtqqWw8vSSkq/pAGCHoYHXJ1BiURlAQlul/eODmSBNf8OGMbqxmxG8mMS7PpEMI9YH9jUw== X-Received: by 2002:a0c:fa09:: with SMTP id q9mr4322338qvn.21.1643302373224; Thu, 27 Jan 2022 08:52:53 -0800 (PST) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id y15sm826432qtx.28.2022.01.27.08.52.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jan 2022 08:52:52 -0800 (PST) Date: Thu, 27 Jan 2022 11:52:51 -0500 From: Mike Snitzer To: Christoph Hellwig Cc: Jens Axboe , Pavel Begunkov , Philipp Reisner , Lars Ellenberg , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com Subject: Re: improve the bio cloning interface Message-ID: References: <20220127063546.1314111-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220127063546.1314111-1-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jan 27 2022 at 1:35P -0500, Christoph Hellwig wrote: > Hi Jens, > > this series changes the bio cloning interface to match the rest changes > to the bio allocation interface and passes the block_device and operation > to the cloning helpers. In addition it renames the cloning helpers to > be more descriptive. > > To get there it requires a bit of refactoring in the device mapper code. I'd like to take a closer look, do you happen to have this series available in a git branch? The changes generally look fine. Any chance you could forecast what you're planning for follow-on changes? Or is it best to just wait for you to produce those follow-on changes? Thanks, Mike From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 5EBF8420012 for ; Thu, 27 Jan 2022 17:59:04 +0100 (CET) Received: by mail-qk1-f197.google.com with SMTP id u12-20020a05620a0c4c00b00475a9324977so2773498qki.13 for ; Thu, 27 Jan 2022 08:52:53 -0800 (PST) Date: Thu, 27 Jan 2022 11:52:51 -0500 From: Mike Snitzer To: Christoph Hellwig Message-ID: References: <20220127063546.1314111-1-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20220127063546.1314111-1-hch@lst.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Cc: Jens Axboe , Philipp Reisner , linux-block@vger.kernel.org, dm-devel@redhat.com, Lars Ellenberg , Pavel Begunkov , drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] improve the bio cloning interface List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Jan 27 2022 at 1:35P -0500, Christoph Hellwig wrote: > Hi Jens, > > this series changes the bio cloning interface to match the rest changes > to the bio allocation interface and passes the block_device and operation > to the cloning helpers. In addition it renames the cloning helpers to > be more descriptive. > > To get there it requires a bit of refactoring in the device mapper code. I'd like to take a closer look, do you happen to have this series available in a git branch? The changes generally look fine. Any chance you could forecast what you're planning for follow-on changes? Or is it best to just wait for you to produce those follow-on changes? Thanks, Mike