From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 507CCC433F5 for ; Thu, 27 Jan 2022 17:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643303478; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=xc60YqqJvVwHR1CLrLxkttcuDaMoe4SSeB0tgGpTF48=; b=UZ440mnfz5NhYBa2+ovQflnUrflQvmnIUXozLCViPVIG8SCHwvkZJc7Oze+9IRK6qaJWCe 3nQAyPo3YTh88nXGPjLBk2itRH6PQ1QHTxnOshjCxePvTniGcUJzVN+455QrBbNusE8iKR gxNdznzArJACNbuW8aCyoY7YellJJ/U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-669-K-nHQibmNxS8m_cdEwSw5w-1; Thu, 27 Jan 2022 12:11:16 -0500 X-MC-Unique: K-nHQibmNxS8m_cdEwSw5w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 94FB48519E4; Thu, 27 Jan 2022 17:11:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A082753E3; Thu, 27 Jan 2022 17:11:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0DAAE1806D1C; Thu, 27 Jan 2022 17:11:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20RHB9ax020142 for ; Thu, 27 Jan 2022 12:11:09 -0500 Received: by smtp.corp.redhat.com (Postfix) id 833A3C27FA3; Thu, 27 Jan 2022 17:11:09 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F91EC27FA0 for ; Thu, 27 Jan 2022 17:11:09 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 649C180B716 for ; Thu, 27 Jan 2022 17:11:09 +0000 (UTC) Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-277-sRmsXwn6Nl-75hN28tJVCw-1; Thu, 27 Jan 2022 12:11:08 -0500 X-MC-Unique: sRmsXwn6Nl-75hN28tJVCw-1 Received: by mail-qv1-f70.google.com with SMTP id u15-20020a0cec8f000000b00425d89d8be0so1248168qvo.20 for ; Thu, 27 Jan 2022 09:11:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hISkPgWXBvxaPJR1A6cjvL239jVaZB/M99kE10NpdT4=; b=L2ShbuabA6kwT01j/JHIYdUH0xAtWLt3+s4+FlBp6PVpDIRbLBitn4CsdGvQjymejA 363XTVKKk7oXmFbknyfQ/WbxZQrhYttbN7WIsvzCRbYpllztrg8O8TsUWDkzSTGdvqkc ApaUhO8BUlkCIsKWVbwilYMd3xQqQscoto9Cdiy3FboQq1FWR+lQALSrQFfHOY/sIvGT 5YRjVruHJ2o67HDmmPOC5HmcjdPhbis1YQKvV4Qu4UiLhu3qbdTHu3tdNV5Jyy3R0Pqf 1LXU1pEn7rxeeg8BSHHY5Zjb9rHMFe0PRdjUorglxOZec0SAWlx5zIsPNCDbURNScwY5 98NQ== X-Gm-Message-State: AOAM531ApfvIS0f7NTrORg5XCzHIQ5tjrhWACby2Q9rZOEYpRhurw2M3 mzEVPT+KpR5NPk4E6NIKspnHqrxux8BGIU0N8CsaQn4awQY2pt1ZUHAtP50ilzP71XMJFluDYXy Nx4Yrqk6tyaYffw== X-Received: by 2002:a05:6214:c2a:: with SMTP id a10mr4419663qvd.42.1643303467585; Thu, 27 Jan 2022 09:11:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQanMj7Y00ur/yzuLmY8gwfKPDXJeoixdwOU4KzNAVApl7lAtazZ8/rD9LIFjZrTulwd1nlg== X-Received: by 2002:a05:6214:c2a:: with SMTP id a10mr4419637qvd.42.1643303467335; Thu, 27 Jan 2022 09:11:07 -0800 (PST) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id h6sm1661870qtx.43.2022.01.27.09.11.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jan 2022 09:11:06 -0800 (PST) Date: Thu, 27 Jan 2022 12:11:06 -0500 From: Mike Snitzer To: Christoph Hellwig Message-ID: References: <20220124091107.642561-1-hch@lst.de> <20220124091107.642561-8-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20220124091107.642561-8-hch@lst.de> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-loop: dm-devel@redhat.com Cc: Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, Philipp Reisner , Ryusuke Konishi , Konstantin Komarov , Roger Pau =?iso-8859-1?Q?Monn=E9?= , dm-devel@redhat.com, "Md . Haris Iqbal " , Lars Ellenberg , linux-fsdevel@vger.kernel.org, xen-devel@lists.xenproject.org, Andrew Morton , ntfs3@lists.linux.dev, Jack Wang , Pavel Begunkov , drbd-dev@lists.linbit.com Subject: Re: [dm-devel] [PATCH 07/19] dm-snap: use blkdev_issue_flush instead of open coding it X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Jan 24 2022 at 4:10P -0500, Christoph Hellwig wrote: > Use blkdev_issue_flush, which uses an on-stack bio instead of an > opencoded version with a bio embedded into struct dm_snapshot. > > Signed-off-by: Christoph Hellwig Acked-by: Mike Snitzer -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 626BAC433F5 for ; Thu, 27 Jan 2022 17:11:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244369AbiA0RLK (ORCPT ); Thu, 27 Jan 2022 12:11:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30001 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244361AbiA0RLK (ORCPT ); Thu, 27 Jan 2022 12:11:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643303469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hISkPgWXBvxaPJR1A6cjvL239jVaZB/M99kE10NpdT4=; b=T+O7ZF/7JwGOGUIvTZg6eaQYi/o72n7QCPHbJSfgPmX6HDEXWnmZUPSVEdm8lDarNlmoJQ GhtzkmbItddRzZOso6KBieqZ7OBdv9/4kj0uaa5kTqtOwbux3JqkjCuyDbpdZkqKk5FAVM VrNTQbAElD3bR/3I/u1QNS555vRbMQw= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-534-zdxg7gxnOXCEHM9P2a_qGA-1; Thu, 27 Jan 2022 12:11:08 -0500 X-MC-Unique: zdxg7gxnOXCEHM9P2a_qGA-1 Received: by mail-qv1-f71.google.com with SMTP id d5-20020a0cffa5000000b004257627bf5fso3564598qvv.23 for ; Thu, 27 Jan 2022 09:11:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hISkPgWXBvxaPJR1A6cjvL239jVaZB/M99kE10NpdT4=; b=XtIckbp6X4g2C5s+J+pEU5Z8swksJC1IcKPfO/c+ne9x0I48/kj1UQPb5vGRqHLIff NgMjtjPqZXSh5dKLgwpBXqi1ogjgCRHfntjjzK54flAYSsVNLQgbYX88qNiCHWJvgE3I jB/0zqc7u7AZVu2DW5d+cVRZ0G5DFPq21fa0W53gObMLCD2fM8rmg3fwsQUyQkhYDv8o EB/YYEYrby2AeA4ApXPLNewx+vpXhXnTgLlDD5dx9sgrvLcV6LbVbSOAV50qrl1gWPrx eJ931FgRdbVMMbiBzoXsmoySeVkxxPqUsT2ery4b0UsFyu8as38BKlPm0/tGt40irlJE YANg== X-Gm-Message-State: AOAM532bBt4DuDNQ0f4u8l060l5ibELt+SsYa+i1+nqzrtOOgNRMvcoI wASHQzcr6MTKUuecykoG+l07irr59jhAryCvtaJbh6oxdmtZbucKlsEUggc0yHblbyEQ2VWM+ay Q77Y8NUPPuGNHtCEnetxNRA== X-Received: by 2002:a05:6214:c2a:: with SMTP id a10mr4419661qvd.42.1643303467585; Thu, 27 Jan 2022 09:11:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQanMj7Y00ur/yzuLmY8gwfKPDXJeoixdwOU4KzNAVApl7lAtazZ8/rD9LIFjZrTulwd1nlg== X-Received: by 2002:a05:6214:c2a:: with SMTP id a10mr4419637qvd.42.1643303467335; Thu, 27 Jan 2022 09:11:07 -0800 (PST) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id h6sm1661870qtx.43.2022.01.27.09.11.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jan 2022 09:11:06 -0800 (PST) Date: Thu, 27 Jan 2022 12:11:06 -0500 From: Mike Snitzer To: Christoph Hellwig Cc: Jens Axboe , Pavel Begunkov , Ryusuke Konishi , Konstantin Komarov , Andrew Morton , "Md . Haris Iqbal " , Jack Wang , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Philipp Reisner , Lars Ellenberg , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, xen-devel@lists.xenproject.org, drbd-dev@lists.linbit.com Subject: Re: [PATCH 07/19] dm-snap: use blkdev_issue_flush instead of open coding it Message-ID: References: <20220124091107.642561-1-hch@lst.de> <20220124091107.642561-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220124091107.642561-8-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Jan 24 2022 at 4:10P -0500, Christoph Hellwig wrote: > Use blkdev_issue_flush, which uses an on-stack bio instead of an > opencoded version with a bio embedded into struct dm_snapshot. > > Signed-off-by: Christoph Hellwig Acked-by: Mike Snitzer From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH 07/19] dm-snap: use blkdev_issue_flush instead of open coding it Date: Thu, 27 Jan 2022 12:11:06 -0500 Message-ID: References: <20220124091107.642561-1-hch@lst.de> <20220124091107.642561-8-hch@lst.de> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643303469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hISkPgWXBvxaPJR1A6cjvL239jVaZB/M99kE10NpdT4=; b=T+O7ZF/7JwGOGUIvTZg6eaQYi/o72n7QCPHbJSfgPmX6HDEXWnmZUPSVEdm8lDarNlmoJQ GhtzkmbItddRzZOso6KBieqZ7OBdv9/4kj0uaa5kTqtOwbux3JqkjCuyDbpdZkqKk5FAVM VrNTQbAElD3bR/3I/u1QNS555vRbMQw= Content-Disposition: inline In-Reply-To: <20220124091107.642561-8-hch-jcswGhMUV9g@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Jens Axboe , Pavel Begunkov , Ryusuke Konishi , Konstantin Komarov , Andrew Morton , "Md . Haris Iqbal " , Jack Wang , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Philipp Reisner , Lars Ellenberg , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ntfs3-cunTk1MwBs/YUNznpcFYbw@public.gmane.org, xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org On Mon, Jan 24 2022 at 4:10P -0500, Christoph Hellwig wrote: > Use blkdev_issue_flush, which uses an on-stack bio instead of an > opencoded version with a bio embedded into struct dm_snapshot. > > Signed-off-by: Christoph Hellwig Acked-by: Mike Snitzer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 0AC7F42A590 for ; Thu, 27 Jan 2022 18:11:09 +0100 (CET) Received: by mail-qk1-f200.google.com with SMTP id q5-20020a05620a0d8500b004738c1b48beso2845230qkl.7 for ; Thu, 27 Jan 2022 09:11:08 -0800 (PST) Date: Thu, 27 Jan 2022 12:11:06 -0500 From: Mike Snitzer To: Christoph Hellwig Message-ID: References: <20220124091107.642561-1-hch@lst.de> <20220124091107.642561-8-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20220124091107.642561-8-hch@lst.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Cc: Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, Philipp Reisner , Ryusuke Konishi , Konstantin Komarov , Roger Pau =?iso-8859-1?Q?Monn=E9?= , dm-devel@redhat.com, "Md . Haris Iqbal " , Lars Ellenberg , linux-fsdevel@vger.kernel.org, xen-devel@lists.xenproject.org, Andrew Morton , ntfs3@lists.linux.dev, Jack Wang , Pavel Begunkov , drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH 07/19] dm-snap: use blkdev_issue_flush instead of open coding it List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jan 24 2022 at 4:10P -0500, Christoph Hellwig wrote: > Use blkdev_issue_flush, which uses an on-stack bio instead of an > opencoded version with a bio embedded into struct dm_snapshot. > > Signed-off-by: Christoph Hellwig Acked-by: Mike Snitzer