Re: [Buildroot] [PATCH v2 1/1] package/ltp-testsuite: bump version to 20220121

[Petr Vorel <petr.vorel@gmail.com>]

Hi Baruch,

> Hi Petr,

> On Thu, Jan 27 2022, Petr Vorel wrote:
> > LTP now builds metadata directory as host target.
> > It's mandatory, therefore adding HOST_CFLAGS and HOST_LDFLAGS to make
> > (adding to configure does not work) to avoid adding -mlongcalls
> > -mauto-litpools for some targets (e.g. bootlin-xtensa-uclibc).

> > Drop patches from this release.

> > Refresh 0001-lapi-Add-sysinfo.h-to-fix-build-with-MUSL-libc.patch
> > (still safe to carry it).

> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> > ---
> > Changes v1->v2:
> > * Add missin g HOST_LDFLAGS to fix br-arm-full-static (cannot find -lc
> > when compiling host target)

> [...]
...
> > @@ -70,6 +70,10 @@ LTP_TESTSUITE_CONF_ENV += \
> >  	LIBS="$(LTP_TESTSUITE_LIBS)" \
> >  	SYSROOT="$(STAGING_DIR)"

> > +LTP_TESTSUITE_MAKE_ENV += \
> > +	HOST_CFLAGS="$(HOST_CFLAGS)" \
> > +	HOST_LDFLAGS="$(HOST_LDFLAGS)"

> I think you should have TARGET_* on the right side of the assignment,
> since this is a target package.
No, it must be HOST_* because the whole exercise is needed to allow one bit of
LTP code built for as host target. I tried to explain this in the commit
message, but clearly I wasn't clear :).


I've tested it on complete build that it's working like this. But using TARGET_*
as you suggest HOST_CFLAGS would have the same options as CFLAGS, which I'm
trying to avoid (that's the default if we don't set anything [1]).

With TARGET_* (or nothing set at all) it fails at least on these 2 builds:

                      br-arm-full-static [5/6]: FAILED
                   bootlin-xtensa-uclibc [24/45]: FAILED
* br-arm-full-static
make -C "metadata" \
	-f "br-test-pkg/br-arm-full-static/build/ltp-testsuite-20220121/metadata/Makefile" all
make[1]: Entering directory 'br-test-pkg/br-arm-full-static/build/ltp-testsuite-20220121/metadata'
/usr/bin/gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Os -g0 -static -Ibr-test-pkg/br-arm-full-static/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/tirpc  -g -O2 -fno-strict-aliasing -pipe -Wall -W -Wold-style-definition -static metaparse.c  -o metaparse
/usr/lib64/gcc/x86_64-suse-linux/11/../../../../x86_64-suse-linux/bin/ld: cannot find -lc
collect2: error: ld returned 1 exit status
make[1]: *** [../include/mk/rules.mk:27: metaparse] Error 1
make[1]: Leaving directory 'br-test-pkg/br-arm-full-static/build/ltp-testsuite-20220121/metadata'
make: *** [Makefile:106: metadata-all] Error 2

* bootlin-xtensa-uclibc
make -C "metadata" \
	-f "br-test-pkg/bootlin-xtensa-uclibc/build/ltp-testsuite-20220121/metadata/Makefile" all
make[1]: Entering directory 'br-test-pkg/bootlin-xtensa-uclibc/build/ltp-testsuite-20220121/metadata'
/usr/bin/gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -mlongcalls -mauto-litpools -Os -g0 -Ibr-test-pkg/bootlin-xtensa-uclibc/host/bin/../xtensa-buildroot-linux-uclibc/sysroot/usr/include/tirpc  -g -O2 -fno-strict-aliasing -pipe -Wall -W -Wold-style-definition  metaparse.c  -o metaparse
gcc: error: unrecognized command-line option ‘-mlongcalls’
gcc: error: unrecognized command-line option ‘-mauto-litpools’
make[1]: *** [../include/mk/rules.mk:27: metaparse] Error 1
make[1]: Leaving directory 'br-test-pkg/bootlin-xtensa-uclibc/build/ltp-testsuite-20220121/metadata'


Kind regards,
Petr

[1] https://lore.kernel.org/ltp/YfJ6fIbFvN7rD0SR@pevik/

> baruch
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot