From: Prashant Malani <pmalani@chromium.org>
To: Dustin Howett <dustin@howett.net>
Cc: linux-kernel@vger.kernel.org, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Tzung-Bi Shih <tzungbi@google.com>,
Michael Niksa <michael.niksa@live.com>,
aaboagye@chromium.org
Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_lpcs: reserve the MEC LPC I/O ports first
Date: Thu, 27 Jan 2022 19:25:55 +0000 [thread overview]
Message-ID: <YfLxw9r6VvbxijRM@chromium.org> (raw)
In-Reply-To: <CA+BfgNKS_uGZVh5K=O5Q-Brj-wWyg+gn1Nx4-Gr5OVb46ZFi=A@mail.gmail.com>
+Aseda,
On Jan 27 13:18, Dustin Howett wrote:
> On Thu, Jan 27, 2022 at 12:55 PM Prashant Malani <pmalani@chromium.org> wrote:
> >
> > Hi Dustin,
> >
> > I can't find this update in the EC code base [1]. Is there any reason
> > you are not adding this, or is the change in flight (or in some other
> > location)?
> >
> > [1] https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/main/include/ec_commands.h
> >
>
> Hey Prashant,
>
> The host communication adapters in the EC repo don't support the MEC
> protocol at all,
> so it did not seem necessary to bring these changes over. I'd be happy
What source do Framework laptop ECs (MECs?) compile their EC firmware
from?
> to do so, of
> course, if that is desirable.
>
> My understanding (well, my guess) is that protocol support was never
> added because
> it is already implemented here in cros_ec_lpcs. Userland I/O port
> access is(?) less desirable
> than having this driver handle it.
Yeah, I wasn't thinking about userland i/o port access, but just having
this behaviour/different I/O port mapping described in the EC code base
too.
next prev parent reply other threads:[~2022-01-27 19:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 18:00 [PATCH v2 0/2] platform/chrome: add support for the Framework Laptop Dustin L. Howett
2022-01-26 18:00 ` [PATCH v2 1/2] platform/chrome: cros_ec_lpcs: detect " Dustin L. Howett
2022-01-26 18:00 ` [PATCH v2 2/2] platform/chrome: cros_ec_lpcs: reserve the MEC LPC I/O ports first Dustin L. Howett
2022-01-27 18:55 ` Prashant Malani
2022-01-27 19:18 ` Dustin Howett
2022-01-27 19:25 ` Prashant Malani [this message]
2022-01-28 3:15 ` Dustin Howett
[not found] ` <CAJnPg5+bU68s2hq75aewap2gyW3YB+gpamKmuB-VfcpGf5krwA@mail.gmail.com>
2022-02-02 19:47 ` Prashant Malani
2022-01-27 19:30 ` Prashant Malani
2022-01-27 2:31 ` [PATCH v2 0/2] platform/chrome: add support for the Framework Laptop Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfLxw9r6VvbxijRM@chromium.org \
--to=pmalani@chromium.org \
--cc=aaboagye@chromium.org \
--cc=bleung@chromium.org \
--cc=dustin@howett.net \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.niksa@live.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.