* [PATCH] drm/amdgpu: fix a potential GPU hang on cyan skillfish
@ 2022-01-28 10:43 Lang Yu
2022-01-28 12:12 ` Lazar, Lijo
2022-01-29 7:42 ` Huang Rui
0 siblings, 2 replies; 3+ messages in thread
From: Lang Yu @ 2022-01-28 10:43 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher, Lang Yu, Lijo Lazar, Huang Rui
We observed a GPU hang when querying GMC CG state(i.e.,
cat amdgpu_pm_info) on cyan skillfish. Acctually, cyan
skillfish doesn't support any CG features.
Just prevent cyan skillfish from accessing GMC CG registers.
Signed-off-by: Lang Yu <Lang.Yu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
index 73ab0eebe4e2..bddaf2417344 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
@@ -1156,6 +1156,9 @@ static void gmc_v10_0_get_clockgating_state(void *handle, u32 *flags)
{
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
+ if (adev->ip_versions[GC_HWIP][0] == IP_VERSION(10, 1, 3))
+ return;
+
adev->mmhub.funcs->get_clockgating(adev, flags);
if (adev->ip_versions[ATHUB_HWIP][0] >= IP_VERSION(2, 1, 0))
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amdgpu: fix a potential GPU hang on cyan skillfish
2022-01-28 10:43 [PATCH] drm/amdgpu: fix a potential GPU hang on cyan skillfish Lang Yu
@ 2022-01-28 12:12 ` Lazar, Lijo
2022-01-29 7:42 ` Huang Rui
1 sibling, 0 replies; 3+ messages in thread
From: Lazar, Lijo @ 2022-01-28 12:12 UTC (permalink / raw)
To: Lang Yu, amd-gfx; +Cc: Alex Deucher, Huang Rui
On 1/28/2022 4:13 PM, Lang Yu wrote:
> We observed a GPU hang when querying GMC CG state(i.e.,
> cat amdgpu_pm_info) on cyan skillfish. Acctually, cyan
> skillfish doesn't support any CG features.
>
> Just prevent cyan skillfish from accessing GMC CG registers.
>
> Signed-off-by: Lang Yu <Lang.Yu@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> index 73ab0eebe4e2..bddaf2417344 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> @@ -1156,6 +1156,9 @@ static void gmc_v10_0_get_clockgating_state(void *handle, u32 *flags)
> {
> struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
> + if (adev->ip_versions[GC_HWIP][0] == IP_VERSION(10, 1, 3))
> + return;
> +
> adev->mmhub.funcs->get_clockgating(adev, flags);
>
> if (adev->ip_versions[ATHUB_HWIP][0] >= IP_VERSION(2, 1, 0))
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amdgpu: fix a potential GPU hang on cyan skillfish
2022-01-28 10:43 [PATCH] drm/amdgpu: fix a potential GPU hang on cyan skillfish Lang Yu
2022-01-28 12:12 ` Lazar, Lijo
@ 2022-01-29 7:42 ` Huang Rui
1 sibling, 0 replies; 3+ messages in thread
From: Huang Rui @ 2022-01-29 7:42 UTC (permalink / raw)
To: Yu, Lang; +Cc: Deucher, Alexander, Lazar, Lijo, amd-gfx@lists.freedesktop.org
On Fri, Jan 28, 2022 at 06:43:23PM +0800, Yu, Lang wrote:
> We observed a GPU hang when querying GMC CG state(i.e.,
> cat amdgpu_pm_info) on cyan skillfish. Acctually, cyan
> skillfish doesn't support any CG features.
>
> Just prevent cyan skillfish from accessing GMC CG registers.
>
> Signed-off-by: Lang Yu <Lang.Yu@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> index 73ab0eebe4e2..bddaf2417344 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> @@ -1156,6 +1156,9 @@ static void gmc_v10_0_get_clockgating_state(void *handle, u32 *flags)
> {
> struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
> + if (adev->ip_versions[GC_HWIP][0] == IP_VERSION(10, 1, 3))
> + return;
> +
> adev->mmhub.funcs->get_clockgating(adev, flags);
>
> if (adev->ip_versions[ATHUB_HWIP][0] >= IP_VERSION(2, 1, 0))
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-29 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-28 10:43 [PATCH] drm/amdgpu: fix a potential GPU hang on cyan skillfish Lang Yu
2022-01-28 12:12 ` Lazar, Lijo
2022-01-29 7:42 ` Huang Rui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.