From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEF77C433F5 for ; Mon, 31 Jan 2022 16:27:07 +0000 (UTC) Received: from localhost ([::1]:60998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEZWE-0003hu-QG for qemu-devel@archiver.kernel.org; Mon, 31 Jan 2022 11:27:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEZDN-0001Ei-8i for qemu-devel@nongnu.org; Mon, 31 Jan 2022 11:07:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:20479) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEZDK-0005g4-RK for qemu-devel@nongnu.org; Mon, 31 Jan 2022 11:07:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643645253; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=OwqFUsfQV0t9IAyBXxvMNyzoldvIxcZ7KP2k5LQKjp8=; b=BrK2N9KzocseU1reWVQubDjj0b2qu6DoHyfRWeuOhlTJdCfC/CZCVgUV8NB/ULGX8NYIKO W0DHE+JDtfjAKhAwMiwzOP8D46cZ1JiwWBVsmvWKtqP675WkVp3x0QqlIJa+MBF9IRRbW1 h+Uf20jHkFrx/vukJzDVk9UQHVunaX0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-475-Rz9ZN5dxMvOplPYG7hH2Sg-1; Mon, 31 Jan 2022 11:07:24 -0500 X-MC-Unique: Rz9ZN5dxMvOplPYG7hH2Sg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 098ED51085; Mon, 31 Jan 2022 16:07:23 +0000 (UTC) Received: from redhat.com (unknown [10.39.195.62]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 751DF70F53; Mon, 31 Jan 2022 16:07:20 +0000 (UTC) Date: Mon, 31 Jan 2022 16:07:17 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Stefan Reiter Subject: Re: [PATCH v7 4/4] qapi/monitor: only allow 'keep' SetPasswordAction for VNC and deprecate Message-ID: References: <20211021100135.4146766-1-s.reiter@proxmox.com> <20211021100135.4146766-5-s.reiter@proxmox.com> MIME-Version: 1.0 In-Reply-To: <20211021100135.4146766-5-s.reiter@proxmox.com> User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.088, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Wolfgang Bumiller , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Markus Armbruster , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Gerd Hoffmann , Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Eric Blake , Thomas Lamprecht Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Oct 21, 2021 at 12:01:35PM +0200, Stefan Reiter wrote: > VNC only supports 'keep' here, enforce this via a seperate > SetPasswordActionVnc enum and mark the option 'deprecated' (as it is > useless with only one value possible). > > Also add a deprecation note to docs. IMHO we should just implement 'fail' and 'disconnect' in the VNC server. Consistency across SPICE and VNC is more user friendly than restricting the available options, and all three policies are useful behaviours for VNC. So I'm not in favour of adding this deprecation. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|