From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: David Heidelberg <david@ixit.cz>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
~okias/devicetree@lists.sr.ht, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: fix timer node clock-frequency
Date: Mon, 31 Jan 2022 15:47:26 -0600 [thread overview]
Message-ID: <YfhY7vwTfRhJ2UWx@builder.lan> (raw)
In-Reply-To: <20211224234631.109315-1-david@ixit.cz>
On Fri 24 Dec 17:46 CST 2021, David Heidelberg wrote:
> Clock frequency is read by driver a single uint32,
> so the second value was never processed.
>
I'm not familiar with the reasoning behind this, but the binding says
that we should have > 1 clock-frequency specified.
Regards,
Bjorn
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm/boot/dts/qcom-apq8064.dtsi | 3 +--
> arch/arm/boot/dts/qcom-ipq8064.dtsi | 3 +--
> arch/arm/boot/dts/qcom-mdm9615.dtsi | 3 +--
> arch/arm/boot/dts/qcom-msm8660.dtsi | 3 +--
> arch/arm/boot/dts/qcom-msm8960.dtsi | 3 +--
> 5 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index 2d539d77bad4..3d5d9ffb66af 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -380,8 +380,7 @@ timer@200a000 {
> <1 2 0x301>,
> <1 3 0x301>;
> reg = <0x0200a000 0x100>;
> - clock-frequency = <27000000>,
> - <32768>;
> + clock-frequency = <27000000>;
> cpu-offset = <0x80000>;
> };
>
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index 996f4458d9fc..d663521bdd02 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -458,8 +458,7 @@ IRQ_TYPE_EDGE_RISING)>,
> <GIC_PPI 5 (GIC_CPU_MASK_SIMPLE(2) |
> IRQ_TYPE_EDGE_RISING)>;
> reg = <0x0200a000 0x100>;
> - clock-frequency = <25000000>,
> - <32768>;
> + clock-frequency = <25000000>;
> clocks = <&sleep_clk>;
> clock-names = "sleep";
> cpu-offset = <0x80000>;
> diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
> index c32415f0e66d..8b58f80093e8 100644
> --- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
> +++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
> @@ -120,8 +120,7 @@ timer@200a000 {
> <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_EDGE_RISING)>,
> <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_EDGE_RISING)>;
> reg = <0x0200a000 0x100>;
> - clock-frequency = <27000000>,
> - <32768>;
> + clock-frequency = <27000000>;
> cpu-offset = <0x80000>;
> };
>
> diff --git a/arch/arm/boot/dts/qcom-msm8660.dtsi b/arch/arm/boot/dts/qcom-msm8660.dtsi
> index 1e8aab357f9c..b16060b65593 100644
> --- a/arch/arm/boot/dts/qcom-msm8660.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8660.dtsi
> @@ -105,8 +105,7 @@ timer@2000000 {
> <1 1 0x301>,
> <1 2 0x301>;
> reg = <0x02000000 0x100>;
> - clock-frequency = <27000000>,
> - <32768>;
> + clock-frequency = <27000000>;
> cpu-offset = <0x40000>;
> };
>
> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
> index 2a0ec97a264f..ca093b89c9ea 100644
> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
> @@ -99,8 +99,7 @@ timer@200a000 {
> <1 2 0x301>,
> <1 3 0x301>;
> reg = <0x0200a000 0x100>;
> - clock-frequency = <27000000>,
> - <32768>;
> + clock-frequency = <27000000>;
> cpu-offset = <0x80000>;
> };
>
> --
> 2.34.1
>
prev parent reply other threads:[~2022-01-31 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 23:46 [PATCH] ARM: dts: qcom: fix timer node clock-frequency David Heidelberg
2022-01-31 21:47 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfhY7vwTfRhJ2UWx@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.