All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: hdegoede@redhat.com, andriy.shevchenko@linux.intel.com,
	srinivas.pandruvada@intel.com, mgross@linux.intel.com,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	Mark Gross <markgross@kernel.org>
Subject: Re: [PATCH 1/3] platform/x86: Add Intel Software Defined Silicon driver
Date: Tue, 1 Feb 2022 09:49:00 +0100	[thread overview]
Message-ID: <Yfjz/CRUxeVGKaaQ@kroah.com> (raw)
In-Reply-To: <20220201030424.1068816-2-david.e.box@linux.intel.com>

On Mon, Jan 31, 2022 at 07:04:22PM -0800, David E. Box wrote:
> +static struct bin_attribute bin_attr_provision_akc;
> +static struct bin_attribute bin_attr_provision_cap;

<snip>

> +static BIN_ATTR_WO(provision_akc, SDSI_SIZE_WRITE_MSG);

You the structure twice, why?


  parent reply	other threads:[~2022-02-01  8:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01  3:04 [PATCH 0/3] Intel Software Defined Silicon David E. Box
2022-02-01  3:04 ` [PATCH 1/3] platform/x86: Add Intel Software Defined Silicon driver David E. Box
2022-02-01  8:45   ` Greg KH
2022-02-01 12:32     ` David E. Box
2022-02-01  8:46   ` Greg KH
2022-02-01  8:49   ` Greg KH [this message]
2022-02-04  5:07     ` David E. Box
2022-02-01  3:04 ` [PATCH 2/3] tools arch x86: Add Intel SDSi provisioning tool David E. Box
2022-02-01  3:04 ` [PATCH 3/3] selftests: sdsi: test sysfs setup David E. Box
2022-02-01  8:44 ` [PATCH 0/3] Intel Software Defined Silicon Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yfjz/CRUxeVGKaaQ@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=david.e.box@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=mgross@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=srinivas.pandruvada@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.