From: Matthias Kaehlcke <mka@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Shaik Sajida Bhanu <sbhanu@codeaurora.org>,
swboyd@chromium.org, Andy Gross <agross@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] arm64: dts: qcom: sc7280-idp: No need for "input-enable" on sw_ctrl
Date: Tue, 1 Feb 2022 10:27:43 -0800 [thread overview]
Message-ID: <Yfl7nwX+aq9YORsg@google.com> (raw)
In-Reply-To: <20220131161034.5.Ibaf8a803802beb089cc6266b37e6156cff3ddaec@changeid>
On Mon, Jan 31, 2022 at 04:10:42PM -0800, Douglas Anderson wrote:
> Specifying "input-enable" on a MSM GPIO is a no-op for the most
> part. The only thing it really does is to explicitly force the output
> of a GPIO to be disabled right at the point of a pinctrl
> transition. We don't need to do this and we don't typically specify
> "input-enable" unless there's a good reason to. Remove it.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2022-02-01 18:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 0:10 [PATCH 0/5] arm64: dts: qcom: sc7x80: A smattering of misc dts cleanups Douglas Anderson
2022-02-01 0:10 ` [PATCH 1/5] arm64: dts: qcom: sc7180-trogdor: Add "-regulator" suffix to pp3300_hub Douglas Anderson
2022-02-01 17:57 ` Matthias Kaehlcke
2022-02-01 0:10 ` [PATCH 2/5] arm64: dts: qcom: sc7280-herobrine: Consistently add "-regulator" suffix Douglas Anderson
2022-02-01 17:58 ` Matthias Kaehlcke
2022-02-01 0:10 ` [PATCH 3/5] arm64: dts: qcom: sc7280: Properly sort sdc pinctrl lines Douglas Anderson
2022-02-01 18:02 ` Matthias Kaehlcke
2022-02-01 0:10 ` [PATCH 4/5] arm64: dts: qcom: sc7280: Clean up sdc1 / sdc2 pinctrl Douglas Anderson
2022-02-01 0:25 ` Doug Anderson
2022-02-01 0:33 ` Bjorn Andersson
2022-02-01 0:34 ` Doug Anderson
2022-02-02 21:28 ` Doug Anderson
2022-02-01 0:10 ` [PATCH 5/5] arm64: dts: qcom: sc7280-idp: No need for "input-enable" on sw_ctrl Douglas Anderson
2022-02-01 18:27 ` Matthias Kaehlcke [this message]
2022-02-04 22:00 ` [PATCH 0/5] arm64: dts: qcom: sc7x80: A smattering of misc dts cleanups patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yfl7nwX+aq9YORsg@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sbhanu@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.