From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] Add tst_dev_block_size utility
Date: Tue, 1 Feb 2022 15:16:10 +0100 [thread overview]
Message-ID: <YflAqso2mcKddn4s@yuki> (raw)
In-Reply-To: <20220201122932.29272-1-andrea.cervesato@suse.de>
Hi!
Pushed with a few fixes for the test, thanks.
Actually the LOOP_SET_BLOCK_SIZE ioctl() may fail with EAGAIN if there
are dirty blocks on the loop device and as a matter of the fact it did
fail for me in a few cases when I executed the test several times. I
guess that it all boils down to how the backing file is preallocated,
and there are several different options for that...
Anyways I fixed that part by adding the LTP retry wrapper around the
ioctl() which makes the test succeed repeatedly.
+ removed the mode for SAFE_OPEN() which is useless without O_CREAT
+ removed needs_tmpdir which is implied by needs_device
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-02-01 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 12:29 [LTP] [PATCH v3] Add tst_dev_block_size utility Andrea Cervesato
2022-02-01 14:16 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YflAqso2mcKddn4s@yuki \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.