From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60BD1C433F5 for ; Tue, 1 Feb 2022 16:43:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C625349EE6; Tue, 1 Feb 2022 11:43:16 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@armlinux.org.uk Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3FHqvv1ZsyLu; Tue, 1 Feb 2022 11:43:15 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A1C8C49EBB; Tue, 1 Feb 2022 11:43:15 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2756749EBB for ; Tue, 1 Feb 2022 11:43:14 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rEqA3FHpPP5V for ; Tue, 1 Feb 2022 11:43:11 -0500 (EST) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9E21B40FAC for ; Tue, 1 Feb 2022 11:43:11 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MVe/2dgTXbUfj0/u/HAqWp9cqwu+WGAL6D0gWo7O6Dg=; b=KY00SYrK3RWXYJeG1jBng1R4AS TLvUpMHmCeajHE6g/ewYpYnIEr+kRn3GyW6ReAEjCpSyPeeUCCa/fhL2LfMh7D+rJ1lPZBCprTKCf bl5Q2fRzQ/Laqf2N7tsqtn8KjuJvBJhU74hhf3AnQVdcIaNbjL98SlDKjNKNMtSZ0Tz9eAVG8sb3f SDrg2QVvnFz5FHOHqBLOQMMc3P6RiPk+8ymIfD6jkSJpJFBBL8OfGyIOKEmZHH+s/hBrEQv55JGYt 6FXsgwkazpKften8yKud8Z6E+XSEI4K2i5zDKSCMEk52XRuvhzPzKfk91m7QTkSReGMXG5JX5OxSl oD5HsE6A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56972) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEwFD-0000pN-MB; Tue, 01 Feb 2022 16:43:03 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nEwFB-0002E7-Aq; Tue, 01 Feb 2022 16:43:01 +0000 Date: Tue, 1 Feb 2022 16:43:01 +0000 From: "Russell King (Oracle)" To: Marc Zyngier Subject: Re: [PATCH v6 14/64] KVM: arm64: nv: Handle SPSR_EL2 specially Message-ID: References: <20220128121912.509006-1-maz@kernel.org> <20220128121912.509006-15-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220128121912.509006-15-maz@kernel.org> Cc: kernel-team@android.com, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Chase Conklin , kvmarm@lists.cs.columbia.edu, mihai.carabas@oracle.com, Ganapatrao Kulkarni , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Jan 28, 2022 at 12:18:22PM +0000, Marc Zyngier wrote: > SPSR_EL2 needs special attention when running nested on ARMv8.3: > > If taking an exception while running at vEL2 (actually EL1), the > HW will update the SPSR_EL1 register with the EL1 mode. We need > to track this in order to make sure that accesses to the virtual > view of SPSR_EL2 is correct. > > To do so, we place an illegal value in SPSR_EL1.M, and patch it > accordingly if required when accessing it. > > Reviewed-by: Alexandru Elisei > Signed-off-by: Marc Zyngier Reviewed-by: Russell King (Oracle) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96523C433F5 for ; Tue, 1 Feb 2022 16:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f6rf4zO/6lXN72VPLOoyAvQQW+Kkn8oIqWf4qlp3Bmc=; b=j6laKgCyL2wgFc wyth9QTMIRKLsSF6FNo9P07oGl3CXagArLjnqb1+Lq+ydexIb+4jarBv3dT6RT7dk2FKYkTolHZct dylFiMtw50PU9KWRbH+Om4zKoGZBf+jOU8DzFnrbB5070VD4sufSS1tYTEI6qodSRsXaQ4f4ltlYo o63WvMZ7cOX0AGK8Vj8EMG5PFoyzl8aeoMD0nFGN1CGui+MqecQsNbFKn8qeFC5gIUCm5SedlrnLH zQulJH/p7RsIvXPzvqoGN2w+InwMJS6ZpNPzI1J8Opqe+intjovXIgP17RVv6hG/KYT94nBxbd5iv 3ORr9aid/kjo0+zSj0Tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEwFP-00D1Ud-QW; Tue, 01 Feb 2022 16:43:15 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEwFM-00D1To-54 for linux-arm-kernel@lists.infradead.org; Tue, 01 Feb 2022 16:43:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MVe/2dgTXbUfj0/u/HAqWp9cqwu+WGAL6D0gWo7O6Dg=; b=KY00SYrK3RWXYJeG1jBng1R4AS TLvUpMHmCeajHE6g/ewYpYnIEr+kRn3GyW6ReAEjCpSyPeeUCCa/fhL2LfMh7D+rJ1lPZBCprTKCf bl5Q2fRzQ/Laqf2N7tsqtn8KjuJvBJhU74hhf3AnQVdcIaNbjL98SlDKjNKNMtSZ0Tz9eAVG8sb3f SDrg2QVvnFz5FHOHqBLOQMMc3P6RiPk+8ymIfD6jkSJpJFBBL8OfGyIOKEmZHH+s/hBrEQv55JGYt 6FXsgwkazpKften8yKud8Z6E+XSEI4K2i5zDKSCMEk52XRuvhzPzKfk91m7QTkSReGMXG5JX5OxSl oD5HsE6A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56972) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEwFD-0000pN-MB; Tue, 01 Feb 2022 16:43:03 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nEwFB-0002E7-Aq; Tue, 01 Feb 2022 16:43:01 +0000 Date: Tue, 1 Feb 2022 16:43:01 +0000 From: "Russell King (Oracle)" To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Jintack Lim , Haibo Xu , Ganapatrao Kulkarni , Chase Conklin , James Morse , Suzuki K Poulose , Alexandru Elisei , karl.heubaum@oracle.com, mihai.carabas@oracle.com, miguel.luis@oracle.com, kernel-team@android.com Subject: Re: [PATCH v6 14/64] KVM: arm64: nv: Handle SPSR_EL2 specially Message-ID: References: <20220128121912.509006-1-maz@kernel.org> <20220128121912.509006-15-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220128121912.509006-15-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220201_084312_223871_0FCE9D5A X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 28, 2022 at 12:18:22PM +0000, Marc Zyngier wrote: > SPSR_EL2 needs special attention when running nested on ARMv8.3: > > If taking an exception while running at vEL2 (actually EL1), the > HW will update the SPSR_EL1 register with the EL1 mode. We need > to track this in order to make sure that accesses to the virtual > view of SPSR_EL2 is correct. > > To do so, we place an illegal value in SPSR_EL1.M, and patch it > accordingly if required when accessing it. > > Reviewed-by: Alexandru Elisei > Signed-off-by: Marc Zyngier Reviewed-by: Russell King (Oracle) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16A53C433EF for ; Tue, 1 Feb 2022 16:43:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241191AbiBAQnO (ORCPT ); Tue, 1 Feb 2022 11:43:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241161AbiBAQnN (ORCPT ); Tue, 1 Feb 2022 11:43:13 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A77EC061714 for ; Tue, 1 Feb 2022 08:43:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MVe/2dgTXbUfj0/u/HAqWp9cqwu+WGAL6D0gWo7O6Dg=; b=KY00SYrK3RWXYJeG1jBng1R4AS TLvUpMHmCeajHE6g/ewYpYnIEr+kRn3GyW6ReAEjCpSyPeeUCCa/fhL2LfMh7D+rJ1lPZBCprTKCf bl5Q2fRzQ/Laqf2N7tsqtn8KjuJvBJhU74hhf3AnQVdcIaNbjL98SlDKjNKNMtSZ0Tz9eAVG8sb3f SDrg2QVvnFz5FHOHqBLOQMMc3P6RiPk+8ymIfD6jkSJpJFBBL8OfGyIOKEmZHH+s/hBrEQv55JGYt 6FXsgwkazpKften8yKud8Z6E+XSEI4K2i5zDKSCMEk52XRuvhzPzKfk91m7QTkSReGMXG5JX5OxSl oD5HsE6A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56972) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEwFD-0000pN-MB; Tue, 01 Feb 2022 16:43:03 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nEwFB-0002E7-Aq; Tue, 01 Feb 2022 16:43:01 +0000 Date: Tue, 1 Feb 2022 16:43:01 +0000 From: "Russell King (Oracle)" To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Jintack Lim , Haibo Xu , Ganapatrao Kulkarni , Chase Conklin , James Morse , Suzuki K Poulose , Alexandru Elisei , karl.heubaum@oracle.com, mihai.carabas@oracle.com, miguel.luis@oracle.com, kernel-team@android.com Subject: Re: [PATCH v6 14/64] KVM: arm64: nv: Handle SPSR_EL2 specially Message-ID: References: <20220128121912.509006-1-maz@kernel.org> <20220128121912.509006-15-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220128121912.509006-15-maz@kernel.org> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Jan 28, 2022 at 12:18:22PM +0000, Marc Zyngier wrote: > SPSR_EL2 needs special attention when running nested on ARMv8.3: > > If taking an exception while running at vEL2 (actually EL1), the > HW will update the SPSR_EL1 register with the EL1 mode. We need > to track this in order to make sure that accesses to the virtual > view of SPSR_EL2 is correct. > > To do so, we place an illegal value in SPSR_EL1.M, and patch it > accordingly if required when accessing it. > > Reviewed-by: Alexandru Elisei > Signed-off-by: Marc Zyngier Reviewed-by: Russell King (Oracle) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!