From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD330C433EF for ; Wed, 2 Feb 2022 07:57:06 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 7DBC03C98A4 for ; Wed, 2 Feb 2022 08:57:04 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id DAB013C8DAA for ; Wed, 2 Feb 2022 08:56:50 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 6659610005AF for ; Wed, 2 Feb 2022 08:56:50 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8257A1F380; Wed, 2 Feb 2022 07:56:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1643788609; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aajBBszOkGHhpEyCZBPhONOO0eR8XiZlNPtkzJBwHIY=; b=WMR4hnvPPJIWaC41ktB4wYKAdWQtzDb873GB6CGZLRVo4XQxi2ui2GGPZ5XNcncnrF3fA4 GzJxxzsCBepjAYzqK73WrEwJ5wDZcWdEBMusnpY+ThRbclttumLd2EmBugIDrX6XnBeg5h ziOjuPHqwsZzK5JuKkmOb8PJc38N6y8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1643788609; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aajBBszOkGHhpEyCZBPhONOO0eR8XiZlNPtkzJBwHIY=; b=nGqtceW1gtGKM1aNwo2VnyyiRTguUzueWM6NpQ/pdFjNd3z8E4lihaJ7XC8nIAwNf045ot Mg2xZXb7vOzLCMDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 563D713B92; Wed, 2 Feb 2022 07:56:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id srAhE0E5+mH1FgAAMHmgww (envelope-from ); Wed, 02 Feb 2022 07:56:49 +0000 Date: Wed, 2 Feb 2022 08:56:47 +0100 From: Petr Vorel To: Andrea Cervesato Message-ID: References: <20220201142230.20243-1-andrea.cervesato@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220201142230.20243-1-andrea.cervesato@suse.de> X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v1] Extract libclone from testcases/kernel/containers X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: Richard Palethorpe , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Andrea, [ Cc Richie, Li ] https://lore.kernel.org/ltp/20220201142230.20243-1-andrea.cervesato@suse.de/ > libclone has been added to the libs folder and updated with the new > LTP API. This library will be used by containers tests, which will be > updated to the new LTP API as well. I suppose you want to use it for containers (still use legacy API), which already use it. I remember Richie not considering libclone.h as a good source and suggesting to use SAFE_CLONE() for simple cases. https://lore.kernel.org/ltp/878s7k59tk.fsf@suse.de/ We probably need some wrapper for containers, but we should recheck, whether we want to take a different approach. Code in the functions is really a bit weird. ... > +#ifndef SYS_unshare > +#ifdef __NR_unshare > +#define SYS_unshare __NR_unshare > +#elif __i386__ > +#define SYS_unshare 310 > +#elif __ia64__ > +#define SYS_unshare 1296 > +#elif __x86_64__ > +#define SYS_unshare 272 > +#elif __s390x__ || __s390__ > +#define SYS_unshare 303 > +#elif __powerpc__ > +#define SYS_unshare 282 > +#else > +#error "unshare not supported on this architecure." > +#endif > +#endif nit: we usually put space before define for a readability. #ifndef SYS_unshare #ifdef __NR_unshare # define SYS_unshare __NR_unshare #elif __i386__ # define SYS_unshare 310 #elif __ia64__ # define SYS_unshare 1296 ... Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp