Re: [PATCH 1/2] examples/l3fwd: use single set of variables throughout the code

[Bruce Richardson <bruce.richardson@intel.com>]

On Wed, Feb 02, 2022 at 06:04:02AM +0000, Honnappa Nagarahalli wrote:
> nb_rxd and nb_txd are used in polling mode and event mode of
> operation. nb_rxd and nb_txd are already global. Make them
> visible to all parts of the application.
> 
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> DTS test cases require changing the RX and TX queue depths.
> Currently, this is achieved by patching the DPDK code. This patch set
> provides a mechanism to configure the queue depths while launching
> the application. With this change DTS test cases do not need
> to modify the DPDK code.
> 

Good change. DTS should not need to be patching DPDK code.

Series-Acked-by: Bruce Richardson <bruce.richardson@intel.com>

>  examples/l3fwd/l3fwd.h       | 4 ++++
>  examples/l3fwd/l3fwd_event.c | 2 --
>  examples/l3fwd/main.c        | 5 ++---
>  3 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h
> index 38ca19133c..4ccdb28b4a 100644
> --- a/examples/l3fwd/l3fwd.h
> +++ b/examples/l3fwd/l3fwd.h
> @@ -81,6 +81,10 @@ struct lcore_conf {
>  
>  extern volatile bool force_quit;
>  
> +/* RX and TX queue depths */
> +extern uint16_t nb_rxd;
> +extern uint16_t nb_txd;
> +
>  /* ethernet addresses of ports */
>  extern uint64_t dest_eth_addr[RTE_MAX_ETHPORTS];
>  extern struct rte_ether_addr ports_eth_addr[RTE_MAX_ETHPORTS];
> diff --git a/examples/l3fwd/l3fwd_event.c b/examples/l3fwd/l3fwd_event.c
> index dd9eafa9b9..7a401290f8 100644
> --- a/examples/l3fwd/l3fwd_event.c
> +++ b/examples/l3fwd/l3fwd_event.c
> @@ -43,8 +43,6 @@ l3fwd_eth_dev_port_setup(struct rte_eth_conf *port_conf)
>  {
>  	struct l3fwd_event_resources *evt_rsrc = l3fwd_get_eventdev_rsrc();
>  	uint16_t nb_ports = rte_eth_dev_count_avail();
> -	uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT;
> -	uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT;
>  	unsigned int nb_lcores = rte_lcore_count();
>  	struct rte_eth_conf local_port_conf;
>  	struct rte_eth_dev_info dev_info;
> diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
> index eb68ffc5aa..acd186ab7d 100644
> --- a/examples/l3fwd/main.c
> +++ b/examples/l3fwd/main.c
> @@ -53,9 +53,8 @@
>  
>  #define MAX_LCORE_PARAMS 1024
>  
> -/* Static global variables used within this file. */
> -static uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT;
> -static uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT;
> +uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT;
> +uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT;
>  
>  /**< Ports set in promiscuous mode off by default. */
>  static int promiscuous_on;
> -- 
> 2.25.1
>