From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 260EBC433EF for ; Wed, 16 Feb 2022 22:14:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232115AbiBPWOP (ORCPT ); Wed, 16 Feb 2022 17:14:15 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:39304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236041AbiBPWOO (ORCPT ); Wed, 16 Feb 2022 17:14:14 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2FD32AED8B for ; Wed, 16 Feb 2022 14:14:01 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id qe15so3758315pjb.3 for ; Wed, 16 Feb 2022 14:14:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4VcCHzkbx92lKzN5iSgXZZP1r2m6Tf5NY9ub+af1qNE=; b=alnOtElqFTR7tub9zwA5y2rQNa2AuphIVynD+IFhZH5iTb2z4/Tz/fN30KE3MZ/Hs0 wPLl+MGfJqBc2Fp0hgok4YyGs29o6EMznRGh17e/uDhTHstLK+SUCtPhefSOr1rcfQHw GzRNELKEkw8tlB/4BtEPzfOVB6f2wrBZyKp1o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4VcCHzkbx92lKzN5iSgXZZP1r2m6Tf5NY9ub+af1qNE=; b=3UeJOEMjZZhlxKRLP4gl8/Zah7ME7ZdEjuSU9Bmxg5BpEF2B4cVjUyrzsExyTw7NMm zG7BFDJ4ltCPugJwfzek4dUbHWBQBFP0YV6meF4TIVLMw58Zd74wr5LWsijKjfyA/9/k V10EXTP+s3YIY53px+tm9Puzb3meVZEuMrnCSlt4PgxILPqAKFquDMM9wrpUL2X2/bP4 MiMPuYH5yUNlpn2qseIlhimvlS+tUPA7Rm4f6S1cc0tRgonuMlsTXSqJo++u19Hl2Y8D puTeV+tf285SYmVNt0UxMJFed1pxLiF6eMlpPSSXtRFQ/3396Ob6Jnlbm7F1S9IM3pjf 1a+w== X-Gm-Message-State: AOAM530jjdO3LxxfO3+dx7b2F1iOe7QevOnRp40EoGkFclwyNXIpwOHD 3SEgjAsuGff4u7AcBJgLINIAwQ== X-Google-Smtp-Source: ABdhPJwFkhpu+gfz4+Q3Zh6Blan0TvjKrac1gpFy9X+Ca8I2pJuSpvGTKbw6B6DwuXIf8uZU8jEMeg== X-Received: by 2002:a17:902:ab92:b0:14d:8c80:dbff with SMTP id f18-20020a170902ab9200b0014d8c80dbffmr20543plr.89.1645049641286; Wed, 16 Feb 2022 14:14:01 -0800 (PST) Received: from localhost ([2620:15c:202:201:20:e0d2:8c14:1e68]) by smtp.gmail.com with UTF8SMTPSA id mz16sm55296pjb.53.2022.02.16.14.13.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Feb 2022 14:14:00 -0800 (PST) Date: Wed, 16 Feb 2022 14:13:58 -0800 From: Matthias Kaehlcke To: Doug Anderson Cc: Lukasz Luba , LKML , Linux PM , amit daniel kachhap , Daniel Lezcano , Viresh Kumar , "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , Dietmar Eggemann , Pierre.Gondois@arm.com, Stephen Boyd , Rajendra Nayak , Bjorn Andersson Subject: Re: [PATCH 1/2] thermal: cooling: Check Energy Model type in cpufreq_cooling and devfreq_cooling Message-ID: References: <20220207073036.14901-1-lukasz.luba@arm.com> <20220207073036.14901-2-lukasz.luba@arm.com> <4a7d4e94-1461-5bac-5798-29998af9793a@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, Feb 16, 2022 at 09:33:50AM -0800, Doug Anderson wrote: > Hi, > > On Wed, Feb 16, 2022 at 7:35 AM Lukasz Luba wrote: > > > > Hi Matthias, > > > > On 2/9/22 10:17 PM, Matthias Kaehlcke wrote: > > > On Wed, Feb 09, 2022 at 11:16:36AM +0000, Lukasz Luba wrote: > > >> > > >> > > >> On 2/8/22 5:25 PM, Matthias Kaehlcke wrote: > > >>> On Tue, Feb 08, 2022 at 09:32:28AM +0000, Lukasz Luba wrote: > > >>>> > > >>>> > > > > [snip] > > > > >>>> Could you point me to those devices please? > > >>> > > >>> arch/arm64/boot/dts/qcom/sc7180-trogdor-* > > >>> > > >>> Though as per above they shouldn't be impacted by your change, since the > > >>> CPUs always pretend to use milli-Watts. > > >>> > > >>> [skipped some questions/answers since sc7180 isn't actually impacted by > > >>> the change] > > >> > > >> Thank you Matthias. I will investigate your setup to get better > > >> understanding. > > > > > > Thanks! > > > > > > > I've checked those DT files and related code. > > As you already said, this patch is safe for them. > > So we can apply it IMO. > > > > > > -------------Off-topic------------------ > > Not in $subject comments: > > > > AFAICS based on two files which define thermal zones: > > sc7180-trogdor-homestar.dtsi > > sc7180-trogdor-coachz.dtsi > > > > only the 'big' cores are used as cooling devices in the > > 'skin_temp_thermal' - the CPU6 and CPU7. > > > > I assume you don't want to model at all the power usage > > from the Little cluster (which is quite big: 6 CPUs), do you? > > I can see that the Little CPUs have small dyn-power-coeff > > ~30% of the big and lower max freq, but still might be worth > > to add them to IPA. You might give them more 'weight', to > > make sure they receive more power during power split. In experiments we saw that including the little cores as cooling devices for 'skin_temp_thermal' didn't have a significant impact on thermals, so we left them out. > > You also don't have GPU cooling device in that thermal zone. > > Based on my experience if your GPU is a power hungry one, > > e.g. 2-4Watts, you might get better results when you model > > this 'hot' device (which impacts your temp sensor reported value). > > I think the two boards you point at (homestar and coachz) are just the > two that override the default defined in the SoC dtsi file. If you > look in sc7180.dtsi you'll see 'gpuss1-thermal' which has a cooling > map. You can also see the cooling maps for the littles. Yep, plus thermal zones with cooling maps for the big cores. > I guess we don't have a `dynamic-power-coefficient` for the GPU, > though? Seems like we should, but I haven't dug through all the code > here... To my knowledge the SC7x80 GPU doesn't register an energy model, which is one of the reasons the GPU wasn't included as cooling device for 'skin_temp_thermal'.