From: Sean Christopherson <seanjc@google.com>
To: Cathy Avery <cavery@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests v3 PATCH 3/3] vmx: Correctly refresh EPTP value in EPT accessed and dirty flag test
Date: Thu, 17 Feb 2022 00:57:22 +0000 [thread overview]
Message-ID: <Yg2dcnDN1BnLcP2p@google.com> (raw)
In-Reply-To: <20220216170149.25792-4-cavery@redhat.com>
On Wed, Feb 16, 2022, Cathy Avery wrote:
> If ept_ad is not supported by the processor or has been
> turned off via kvm module param, test_ept_eptp() will
> incorrectly leave EPTP_AD_FLAG set in variable eptp
> causing the following failures of subsequent
> test_vmx_valid_controls calls:
>
> FAIL: Enable-EPT enabled; reserved bits [11:7] 0: vmlaunch succeeds
> FAIL: Enable-EPT enabled; reserved bits [63:N] 0: vmlaunch succeeds
>
> Use the saved EPTP to restore the EPTP after each sub-test instead of
> manually unwinding what was done by the sub-test, which is error prone
> and hard to follow.
>
> Signed-off-by: Cathy Avery <cavery@redhat.com>
> ---
Reviewed-by: Sean Christopherson <seanjc@google.com>
Thanks much for seeing this through!
prev parent reply other threads:[~2022-02-17 0:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 17:01 [kvm-unit-tests v3 PATCH 0/3] vmx: Fix EPT accessed and dirty flag test Cathy Avery
2022-02-16 17:01 ` [kvm-unit-tests v3 PATCH 1/3] vmx: Cleanup test_vmx_vmlaunch to generate clearer and more consolidated test reports Cathy Avery
2022-02-17 0:56 ` Sean Christopherson
2022-02-16 17:01 ` [kvm-unit-tests v3 PATCH 2/3] vmx: Explicitly setup a dummy EPTP in EPT accessed and dirty flag test Cathy Avery
2022-02-17 0:56 ` Sean Christopherson
2022-02-16 17:01 ` [kvm-unit-tests v3 PATCH 3/3] vmx: Correctly refresh EPTP value " Cathy Avery
2022-02-17 0:57 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg2dcnDN1BnLcP2p@google.com \
--to=seanjc@google.com \
--cc=cavery@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.