From: Greg KH <gregkh@linuxfoundation.org>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: bostroesser@gmail.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, xiaoguang.wang@linux.alibaba.com,
xlpang@linux.alibaba.com
Subject: Re: [PATCH 1/2] uio: add ioctl to uio
Date: Thu, 17 Feb 2022 07:13:44 +0100 [thread overview]
Message-ID: <Yg3nmK7iWp7FuoOa@kroah.com> (raw)
In-Reply-To: <1645064962-94123-1-git-send-email-kanie@linux.alibaba.com>
On Thu, Feb 17, 2022 at 10:29:21AM +0800, Guixin Liu wrote:
> In TCMU, if backstore holds its own userspace buffer, for read cmd, the
> data needs to be copied from userspace buffer to tcmu data area first,
> and then needs to be copied from tcmu data area to scsi sgl pages again.
>
> To solve this problem, add ioctl to uio to let userspace backstore can
> copy data between scsi sgl pages and its own buffer directly.
>
> Reviewed-by: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
> drivers/uio/uio.c | 22 ++++++++++++++++++++++
> include/linux/uio_driver.h | 1 +
No, sorry, thie uio driver will not be adding ioctls to them. If you
need an ioctl, then you should not be using the UIO api but rather use a
custom character driver instead.
thanks,
greg k-h
next prev parent reply other threads:[~2022-02-17 6:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 2:29 [PATCH 1/2] uio: add ioctl to uio Guixin Liu
2022-02-17 2:29 ` [PATCH 2/2] scsi:target:tcmu: reduce once copy by using uio ioctl Guixin Liu
2022-02-17 6:45 ` kernel test robot
2022-02-17 6:45 ` kernel test robot
2022-02-17 8:07 ` kernel test robot
2022-02-17 8:07 ` kernel test robot
2022-02-17 10:15 ` Greg KH
2022-02-17 11:13 ` Xiaoguang Wang
2022-02-17 12:28 ` Greg KH
2022-02-17 11:10 ` [RFC PATCH] scsi:target:tcmu: tcmu_ioctl_copy_between_sgl_and_iovec() can be static kernel test robot
2022-02-17 11:10 ` kernel test robot
2022-02-17 11:12 ` [PATCH 2/2] scsi:target:tcmu: reduce once copy by using uio ioctl kernel test robot
2022-02-17 11:12 ` kernel test robot
2022-02-21 17:09 ` Bodo Stroesser
2022-02-28 8:52 ` Xiaoguang Wang
2022-02-28 10:47 ` Greg KH
2022-02-17 6:13 ` Greg KH [this message]
[not found] ` <362edb61-b8ad-495e-2346-8020355c0938@linux.alibaba.com>
2022-02-17 12:30 ` [PATCH 1/2] uio: add ioctl to uio Greg KH
2022-02-17 12:30 ` Xiaoguang Wang
2022-02-17 6:55 ` kernel test robot
2022-02-17 6:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg3nmK7iWp7FuoOa@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bostroesser@gmail.com \
--cc=kanie@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
--cc=xiaoguang.wang@linux.alibaba.com \
--cc=xlpang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.