From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDD5EC433EF for ; Fri, 18 Feb 2022 10:33:27 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 227683CA0E1 for ; Fri, 18 Feb 2022 11:33:26 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 5407D3C9DE5 for ; Fri, 18 Feb 2022 11:33:17 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id DB5301402F90 for ; Fri, 18 Feb 2022 11:33:16 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2A9C9219A4; Fri, 18 Feb 2022 10:33:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1645180396; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=soDYZP0IpPPaViOgxdpmExK51zTXIsgENkFDygMNXW8=; b=qu9wakJpff5rCRaTVGbnHD+M7wPFqbU0bYtm83GmTFuv5Fg/m5S4p1UYXF+zW2h3KHIs39 SFoC6RmO6D763BHbJwzSzBRPhpweDTjmsXJVFkFCHp2xVWkHQKqRktItGNcjNOuuEW5sfy XvVJUAUrQAgYySJ78Jpyl0JwqAY92Yg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1645180396; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=soDYZP0IpPPaViOgxdpmExK51zTXIsgENkFDygMNXW8=; b=f0MEY/y03BIWOQAjG5s/oUg0lVW4rnY7VoZ3u7BRHOInE4dnny0RQVdJUQY52pyMldIiPm y1EkmkgojrQkr4CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0D91113C47; Fri, 18 Feb 2022 10:33:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HoSVAux1D2JzDQAAMHmgww (envelope-from ); Fri, 18 Feb 2022 10:33:16 +0000 Date: Fri, 18 Feb 2022 11:35:24 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20220217142730.19726-1-chrubis@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] test_macros: TST_EXP_EXPR() add auto stringification X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > It occured to me that this is probably not the best result though, since > > in the case of the failure it does not print the expected and actual > > value. So maybe it would be better to add TST_EXP_EQ() macro instead. I > > will send a patch later on. > > I wonder can't we have both - print stringified parameters and also their > values? Would it be too confusing? Couldn't be done unless you know the types beforehand. I've send another patch that adds TST_EXP_EQ_*() macros please have a look at that one instead. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp