All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: William Mahon <wmahon@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>,
	William Mahon <wmahon@google.com>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Jiri Kosina <jikos@kernel.org>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: Add mapping for KEY_APP_LAUNCHER
Date: Thu, 17 Feb 2022 22:48:23 -0800	[thread overview]
Message-ID: <Yg9BN1wU87t5ddoC@google.com> (raw)
In-Reply-To: <93e5dc0bbeb0b44c9b225946b3ab81d3af3a1789.camel@hadess.net>

On Thu, Feb 17, 2022 at 11:35:24AM +0100, Bastien Nocera wrote:
> On Thu, 2022-02-17 at 05:33 +0000, William Mahon wrote:
> > The App Launcher key is used to bring up the Launcher menu.
> > 
> > This patch adds a new key definition KEY_APP_LAUNCHER and maps
> > 0x0c02a28
>  
> Is this a typo? It's not the same format as in your other patch.
> 
> KEY_DASHBOARD as used in the Mac keyboard drivers looks like a good
> match for KEY_APP_LAUNCHER. If not, it would be good to explain why in
> the commit message.
> 
> See 437184ae8bd1ef923a40b009e37801deae66ad55 for the KEY_DASHBOARD
> addition.

I agree that the spirit of KEY_DASHBOARD is what I think we want here,
but IMO neither KEY_DASHBOARD nor KEY_APP_LAUNCHER are good names for
this. Maybe we could use KEY_ALL_APPLICATIONS (and alias
KEY_KEY_DASHBOARD to it for compatibility)?

Thanks.

-- 
Dmitry

      reply	other threads:[~2022-02-18  6:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-17  5:33 [PATCH] HID: Add mapping for KEY_APP_LAUNCHER William Mahon
2022-02-17 10:35 ` Bastien Nocera
2022-02-18  6:48   ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yg9BN1wU87t5ddoC@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=hadess@hadess.net \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wmahon@chromium.org \
    --cc=wmahon@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.