From: Petr Vorel <pvorel@suse.cz>
To: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 2/5] lapi/kcmp.h: Replace GPL with SPDX-License-Identifier
Date: Fri, 18 Feb 2022 09:28:14 +0100 [thread overview]
Message-ID: <Yg9YnujePndAfIC1@pevik> (raw)
In-Reply-To: <620F00F6.9000108@fujitsu.com>
Hi Xu,
> >> int kcmp(int pid1, int pid2, int type, int fd1, int fd2)
> > $ make check-pidfd_getfd01
> > ../../../../include/lapi/kcmp.h:34:5: warning: Symbol 'kcmp' has no prototype or library ('tst_') prefix. Should it be static?
> > Could you please mark this as static inline?
> Of course, in fact, I have changed, but forgot to add it into the final
> version.
+1
> > Not sure if this should be with the same commit as SPDX.
> IMO, I will add it into the same commit and mention that we also replace
> GPL with SPDX. Title maybe changed into "lapi/kcmp.h: Simplify code ".
+1
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-18 8:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 10:04 [LTP] [PATCH 1/5] kcmp.h: move it to ltp include/lapi directory Yang Xu
2022-02-16 10:04 ` [LTP] [PATCH 2/5] lapi/kcmp.h: Replace GPL with SPDX-License-Identifier Yang Xu
2022-02-16 14:05 ` Petr Vorel
2022-02-17 18:52 ` Petr Vorel
2022-02-18 2:13 ` xuyang2018.jy
2022-02-18 8:28 ` Petr Vorel [this message]
2022-02-16 10:04 ` [LTP] [PATCH 3/5] pidfd_getfd.h: add fallback Yang Xu
2022-02-16 14:09 ` Petr Vorel
2022-02-18 2:14 ` xuyang2018.jy
2022-02-16 10:04 ` [LTP] [PATCH 4/5] Add pidfd_getfd01 test Yang Xu
2022-02-17 19:20 ` Petr Vorel
2022-02-18 3:24 ` xuyang2018.jy
2022-02-18 7:02 ` Petr Vorel
2022-02-21 10:03 ` Richard Palethorpe
2022-02-21 12:42 ` Petr Vorel
2022-02-21 13:49 ` Richard Palethorpe
2022-02-18 8:57 ` Petr Vorel
2022-02-18 9:56 ` xuyang2018.jy
2022-02-18 10:15 ` Petr Vorel
2022-02-22 2:29 ` xuyang2018.jy
2022-02-17 19:28 ` Petr Vorel
2022-02-18 3:37 ` xuyang2018.jy
2022-02-18 6:59 ` Petr Vorel
2022-02-16 10:04 ` [LTP] [PATCH 5/5] syscalls/pidfd_getfd02: add basic error test Yang Xu
2022-02-17 19:56 ` Petr Vorel
2022-02-18 3:49 ` xuyang2018.jy
2022-02-18 6:50 ` Petr Vorel
2022-02-18 7:03 ` xuyang2018.jy
2022-02-18 10:58 ` Petr Vorel
2022-02-22 2:49 ` xuyang2018.jy
2022-02-16 14:02 ` [LTP] [PATCH 1/5] kcmp.h: move it to ltp include/lapi directory Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg9YnujePndAfIC1@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.