All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] getrusage03: skip on small RAM system
Date: Mon, 7 Feb 2022 08:40:55 +0100	[thread overview]
Message-ID: <YgDNB9v0x82mExVE@pevik> (raw)
In-Reply-To: <20220207040447.2803113-1-liwang@redhat.com>

Hi Li,

> Notes:
>     Ps. I also think we might need .min_mem_[avai|total] field but
>         not sure if it is really necessary to add that.
Is it just a single test? Than maybe not worth of it, but generally I'm for
adding tags like this into the library - it encapsulates code and gives us a
documentation in docparse.

...
> +static void setup(void)
> +{
> +	long long mem_avail = tst_available_mem();
> +
> +	if (mem_avail < 512L*1024)
> +		tst_brk(TCONF, "Needed > 512MB availabe, only have: %ld kB", mem_avail);
typo: s/availabe/available/

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Thanks!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-02-07  7:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07  4:04 [LTP] [PATCH] getrusage03: skip on small RAM system Li Wang
2022-02-07  7:40 ` Petr Vorel [this message]
2022-02-07 10:08   ` Li Wang
2022-02-07 11:12     ` Petr Vorel
2022-02-07  9:16 ` Jan Stancek
2022-02-07 12:09   ` Li Wang
2022-02-07 13:16   ` Cyril Hrubis
2022-02-08  3:27     ` Li Wang
2022-02-07 13:19 ` Cyril Hrubis
2022-02-08  3:21   ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgDNB9v0x82mExVE@pevik \
    --to=pvorel@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.