From: Bruce Richardson <bruce.richardson@intel.com>
To: Weiguo Li <liwg06@foxmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 0/6] fix the curly braces mismatch problem
Date: Mon, 7 Feb 2022 13:39:27 +0000 [thread overview]
Message-ID: <YgEhD850V3tkjljI@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <tencent_B21E8153B988159D816FB6917D11F3185A07@qq.com>
On Mon, Feb 07, 2022 at 07:44:29PM +0800, Weiguo Li wrote:
> On Mon, 7 Feb 2022 09:29:58 +0000, Bruce Richardson wrote:
> > Any headers that have filenames not starting with "rte_" are internal
> > headers, and so should have the guards removed. Therefore, I think that
> > most patches in this set should just be removing guards. From my tests with
> > building our public headers in C++ files, resulting in series[1], I only
> > found one public header with an incorrect guard.
> >
> > /Bruce
> >
> > [1]http://patches.dpdk.org/project/dpdk/list/?series=21466
> >
>
> Hi Bruce,
>
> Thanks for your tip!
>
> BTW it's strange that some file include these headers by angle-brackets.
>
> I'll update this patch set later.
>
Thanks.
BTW: if you do find any headers that are being exposed as public headers,
but don't have "rte_" in the filename, please flag them as needing fixing
too. There shouldn't be any, but just in case....
next prev parent reply other threads:[~2022-02-07 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 0:44 [PATCH 0/6] fix the curly braces mismatch problem Weiguo Li
2022-02-07 9:29 ` Bruce Richardson
2022-02-07 11:44 ` Weiguo Li
2022-02-07 13:39 ` Bruce Richardson [this message]
2022-02-08 16:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgEhD850V3tkjljI@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=liwg06@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.