From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 005E9C433F5 for ; Mon, 7 Feb 2022 22:06:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232342AbiBGWG3 (ORCPT ); Mon, 7 Feb 2022 17:06:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230345AbiBGWG3 (ORCPT ); Mon, 7 Feb 2022 17:06:29 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CF8BC061355 for ; Mon, 7 Feb 2022 14:06:28 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 76DCF499; Mon, 7 Feb 2022 23:06:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1644271583; bh=Clwp51CH0IHZXB2aOgZ5eSr/0soriHZwgobPgYX8lig=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rnGcND/pzbgGiLbE3sB/uQkTy0TuIi1084zvlw65nldf7vI573qdX1DhgNn0/XAle H+PlHy936zr5QefWfubEQX68QwFWUGX5FHRMjllxuvmKewxwX5ADpDSlGEn8Semkc1 Thzoj9khvMMgMl1pPUDV4Isu4t9T0MDf0sj0JEd8= Date: Tue, 8 Feb 2022 00:06:21 +0200 From: Laurent Pinchart To: Maxime Ripard Cc: Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, Maarten Lankhorst , Thomas Zimmermann , Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , linux-renesas-soc@vger.kernel.org, Kieran Bingham Subject: Re: [PATCH 16/23] drm/rcar: plane: Remove redundant zpos initialisation Message-ID: References: <20220207163515.1038648-1-maxime@cerno.tech> <20220207163515.1038648-17-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220207163515.1038648-17-maxime@cerno.tech> Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hello Maxime, Thank you for the patch. On Mon, Feb 07, 2022 at 05:35:08PM +0100, Maxime Ripard wrote: > The rcar-du KMS driver will call drm_plane_create_zpos_property() with an > init value depending on the plane type. > > Since the initial value wasn't carried over in the state, the driver had > to set it again in rcar_du_plane_reset() and rcar_du_vsp_plane_reset(). > However, the helpers have been adjusted to set it properly at reset, so > this is not needed anymore. > > Cc: linux-renesas-soc@vger.kernel.org > Cc: Kieran Bingham > Cc: Laurent Pinchart > Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 1 - > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > index 862197be1e01..9dda5e06457d 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > @@ -696,7 +696,6 @@ static void rcar_du_plane_reset(struct drm_plane *plane) > state->hwindex = -1; > state->source = RCAR_DU_PLANE_MEMORY; > state->colorkey = RCAR_DU_COLORKEY_NONE; > - state->state.zpos = plane->type == DRM_PLANE_TYPE_PRIMARY ? 0 : 1; > } > > static int rcar_du_plane_atomic_set_property(struct drm_plane *plane, > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > index b7fc5b069cbc..719c60034952 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > @@ -362,7 +362,6 @@ static void rcar_du_vsp_plane_reset(struct drm_plane *plane) > return; > > __drm_atomic_helper_plane_reset(plane, &state->state); > - state->state.zpos = plane->type == DRM_PLANE_TYPE_PRIMARY ? 0 : 1; > } > > static const struct drm_plane_funcs rcar_du_vsp_plane_funcs = { -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C2E9C433EF for ; Mon, 7 Feb 2022 22:06:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 358AA10E2DE; Mon, 7 Feb 2022 22:06:26 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id E9EB910E2DE for ; Mon, 7 Feb 2022 22:06:24 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 76DCF499; Mon, 7 Feb 2022 23:06:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1644271583; bh=Clwp51CH0IHZXB2aOgZ5eSr/0soriHZwgobPgYX8lig=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rnGcND/pzbgGiLbE3sB/uQkTy0TuIi1084zvlw65nldf7vI573qdX1DhgNn0/XAle H+PlHy936zr5QefWfubEQX68QwFWUGX5FHRMjllxuvmKewxwX5ADpDSlGEn8Semkc1 Thzoj9khvMMgMl1pPUDV4Isu4t9T0MDf0sj0JEd8= Date: Tue, 8 Feb 2022 00:06:21 +0200 From: Laurent Pinchart To: Maxime Ripard Subject: Re: [PATCH 16/23] drm/rcar: plane: Remove redundant zpos initialisation Message-ID: References: <20220207163515.1038648-1-maxime@cerno.tech> <20220207163515.1038648-17-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220207163515.1038648-17-maxime@cerno.tech> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Tim Gover , Dave Stevenson , David Airlie , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham , Thomas Zimmermann , Daniel Vetter , Phil Elwell Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Maxime, Thank you for the patch. On Mon, Feb 07, 2022 at 05:35:08PM +0100, Maxime Ripard wrote: > The rcar-du KMS driver will call drm_plane_create_zpos_property() with an > init value depending on the plane type. > > Since the initial value wasn't carried over in the state, the driver had > to set it again in rcar_du_plane_reset() and rcar_du_vsp_plane_reset(). > However, the helpers have been adjusted to set it properly at reset, so > this is not needed anymore. > > Cc: linux-renesas-soc@vger.kernel.org > Cc: Kieran Bingham > Cc: Laurent Pinchart > Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 1 - > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > index 862197be1e01..9dda5e06457d 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > @@ -696,7 +696,6 @@ static void rcar_du_plane_reset(struct drm_plane *plane) > state->hwindex = -1; > state->source = RCAR_DU_PLANE_MEMORY; > state->colorkey = RCAR_DU_COLORKEY_NONE; > - state->state.zpos = plane->type == DRM_PLANE_TYPE_PRIMARY ? 0 : 1; > } > > static int rcar_du_plane_atomic_set_property(struct drm_plane *plane, > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > index b7fc5b069cbc..719c60034952 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > @@ -362,7 +362,6 @@ static void rcar_du_vsp_plane_reset(struct drm_plane *plane) > return; > > __drm_atomic_helper_plane_reset(plane, &state->state); > - state->state.zpos = plane->type == DRM_PLANE_TYPE_PRIMARY ? 0 : 1; > } > > static const struct drm_plane_funcs rcar_du_vsp_plane_funcs = { -- Regards, Laurent Pinchart