From: Rob Herring <robh@kernel.org>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: pavel@ucw.cz, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2] leds: remove ide-disk trigger
Date: Mon, 7 Feb 2022 17:30:11 -0600 [thread overview]
Message-ID: <YgGrg7NgHnK5chrE@robh.at.kernel.org> (raw)
In-Reply-To: <20220125210537.54036-1-clabbe@baylibre.com>
On Tue, Jan 25, 2022 at 09:05:37PM +0000, Corentin Labbe wrote:
> No user of ide-disk remains, so remove this deprecated trigger.
Strictly speaking, this would break someone if they didn't update their
DT. But it only looks like only a few platforms used this and they were
fixed in 2016. The commit message should say all this so I don't have to
go research it.
With that,
Acked-by: Rob Herring <robh@kernel.org>
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> Changes since v1:
> - remove also DEFINE_LED_TRIGGER(ledtrig_ide)
>
> Documentation/devicetree/bindings/leds/common.yaml | 3 ---
> drivers/leds/trigger/ledtrig-disk.c | 4 ----
> 2 files changed, 7 deletions(-)
prev parent reply other threads:[~2022-02-08 1:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 21:05 [PATCH v2] leds: remove ide-disk trigger Corentin Labbe
2022-02-07 23:30 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgGrg7NgHnK5chrE@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.