From: Oscar Salvador <osalvador@suse.de>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] mm/memory_hotplug: remove obsolete comment of __add_pages
Date: Tue, 8 Feb 2022 11:15:04 +0100 [thread overview]
Message-ID: <YgJCqAToVBk2G3fq@localhost.localdomain> (raw)
In-Reply-To: <20220207133643.23427-2-linmiaohe@huawei.com>
On Mon, Feb 07, 2022 at 09:36:40PM +0800, Miaohe Lin wrote:
> Since commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded
> memory to zones until online"), there is no need to pass in the zone.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Yeah, I am with David here, "Reasonably generic function for adding
memory" does not really tell me much about that function.
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2022-02-08 10:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 13:36 [PATCH 0/4] A few cleanup patches around memory_hotplug Miaohe Lin
2022-02-07 13:36 ` [PATCH 1/4] mm/memory_hotplug: remove obsolete comment of __add_pages Miaohe Lin
2022-02-07 14:41 ` David Hildenbrand
2022-02-07 20:12 ` Andrew Morton
2022-02-08 10:15 ` Oscar Salvador [this message]
2022-02-08 10:56 ` Miaohe Lin
2022-02-07 13:36 ` [PATCH 2/4] mm/memory_hotplug: avoid calling zone_intersects() for ZONE_NORMAL Miaohe Lin
2022-02-07 14:50 ` David Hildenbrand
2022-02-08 10:06 ` Oscar Salvador
2022-02-07 13:36 ` [PATCH 3/4] mm/memory_hotplug: clean up try_offline_node Miaohe Lin
2022-02-07 14:46 ` David Hildenbrand
2022-02-08 10:08 ` Oscar Salvador
2022-02-07 13:36 ` [PATCH 4/4] mm/memory_hotplug: fix misplaced comment in offline_pages Miaohe Lin
2022-02-07 14:45 ` David Hildenbrand
2022-02-08 10:12 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgJCqAToVBk2G3fq@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.