From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Tue, 8 Feb 2022 12:28:29 +0100 Subject: [PATCH v7 07/13] peci: Add sysfs interface for PECI bus In-Reply-To: References: <20220202144838.163875-1-iwona.winiarska@intel.com> <20220202144838.163875-8-iwona.winiarska@intel.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Feb 08, 2022 at 11:15:30AM +0000, Joel Stanley wrote: > On Tue, 8 Feb 2022 at 11:08, Greg Kroah-Hartman > wrote: > > > > On Wed, Feb 02, 2022 at 03:48:32PM +0100, Iwona Winiarska wrote: > > > PECI devices may not be discoverable at the time when PECI controller is > > > being added (e.g. BMC can boot up when the Host system is still in S5). > > > Since we currently don't have the capabilities to figure out the Host > > > system state inside the PECI subsystem itself, we have to rely on > > > userspace to do it for us. > > > > > > In the future, PECI subsystem may be expanded with mechanisms that allow > > > us to avoid depending on userspace interaction (e.g. CPU presence could > > > be detected using GPIO, and the information on whether it's discoverable > > > could be obtained over IPMI). > > > Unfortunately, those methods may ultimately not be available (support > > > will vary from platform to platform), which means that we still need > > > platform independent method triggered by userspace. > > > > > > Signed-off-by: Iwona Winiarska > > > --- > > > Documentation/ABI/testing/sysfs-bus-peci | 16 +++++ > > > drivers/peci/Makefile | 2 +- > > > drivers/peci/core.c | 3 +- > > > drivers/peci/device.c | 1 + > > > drivers/peci/internal.h | 5 ++ > > > drivers/peci/sysfs.c | 82 ++++++++++++++++++++++++ > > > 6 files changed, 107 insertions(+), 2 deletions(-) > > > create mode 100644 Documentation/ABI/testing/sysfs-bus-peci > > > create mode 100644 drivers/peci/sysfs.c > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-peci b/Documentation/ABI/testing/sysfs-bus-peci > > > new file mode 100644 > > > index 000000000000..56c2b2216bbd > > > --- /dev/null > > > +++ b/Documentation/ABI/testing/sysfs-bus-peci > > > @@ -0,0 +1,16 @@ > > > +What: /sys/bus/peci/rescan > > > +Date: July 2021 > > > +KernelVersion: 5.15 > > > > 5.15 was a long time ago :( > > > > > > Other than this nit, these all look semi-sane to me. What tree are you > > wanting these to go through, mine? If so, can you fix this up (both > > places in this file) and resend? > > Yes, I recommend Iwona send these through your tree. > > Thanks for taking another look over them. Thanks to Iwona and Intel > for doing this work. Can you provide an ack or reviewed-by for them when they are reposted so I know this? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B75D1C433F5 for ; Tue, 8 Feb 2022 11:32:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240433AbiBHLcq (ORCPT ); Tue, 8 Feb 2022 06:32:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357032AbiBHL2j (ORCPT ); Tue, 8 Feb 2022 06:28:39 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F3CEC03FEF3; Tue, 8 Feb 2022 03:28:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CD374B81A4A; Tue, 8 Feb 2022 11:28:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2927C004E1; Tue, 8 Feb 2022 11:28:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1644319711; bh=S/OkajaK//lhGgvpH8Fw06Nx4ATm9sAyJIS5raQ2bvQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t0ybZeeHBJKmL5e5GBklD/SFNg2ORM9tj6Uo94eWeAyDaZznYCaSGBMNaoKafm9Rx o26RX7aXd2Niprs6HcmE6Xc+k1+wpuIvcCGKjthZfKnrVjNwbyTlR6uWsSW7lg2Sgn rVoqZL/xTG2Nwq7Q4um8qFYpeVKRyLKz3iFMsY8o= Date: Tue, 8 Feb 2022 12:28:29 +0100 From: Greg Kroah-Hartman To: Joel Stanley Cc: Iwona Winiarska , Linux Kernel Mailing List , OpenBMC Maillist , devicetree , linux-aspeed , Linux ARM , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, Rob Herring , Andrew Jeffery , Jean Delvare , Guenter Roeck , Arnd Bergmann , Olof Johansson , Jonathan Corbet , Borislav Petkov , Pierre-Louis Bossart , Tony Luck , Andy Shevchenko , Dan Williams , Randy Dunlap , Zev Weiss , David Muller , Dave Hansen , Billy Tsai Subject: Re: [PATCH v7 07/13] peci: Add sysfs interface for PECI bus Message-ID: References: <20220202144838.163875-1-iwona.winiarska@intel.com> <20220202144838.163875-8-iwona.winiarska@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Feb 08, 2022 at 11:15:30AM +0000, Joel Stanley wrote: > On Tue, 8 Feb 2022 at 11:08, Greg Kroah-Hartman > wrote: > > > > On Wed, Feb 02, 2022 at 03:48:32PM +0100, Iwona Winiarska wrote: > > > PECI devices may not be discoverable at the time when PECI controller is > > > being added (e.g. BMC can boot up when the Host system is still in S5). > > > Since we currently don't have the capabilities to figure out the Host > > > system state inside the PECI subsystem itself, we have to rely on > > > userspace to do it for us. > > > > > > In the future, PECI subsystem may be expanded with mechanisms that allow > > > us to avoid depending on userspace interaction (e.g. CPU presence could > > > be detected using GPIO, and the information on whether it's discoverable > > > could be obtained over IPMI). > > > Unfortunately, those methods may ultimately not be available (support > > > will vary from platform to platform), which means that we still need > > > platform independent method triggered by userspace. > > > > > > Signed-off-by: Iwona Winiarska > > > --- > > > Documentation/ABI/testing/sysfs-bus-peci | 16 +++++ > > > drivers/peci/Makefile | 2 +- > > > drivers/peci/core.c | 3 +- > > > drivers/peci/device.c | 1 + > > > drivers/peci/internal.h | 5 ++ > > > drivers/peci/sysfs.c | 82 ++++++++++++++++++++++++ > > > 6 files changed, 107 insertions(+), 2 deletions(-) > > > create mode 100644 Documentation/ABI/testing/sysfs-bus-peci > > > create mode 100644 drivers/peci/sysfs.c > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-peci b/Documentation/ABI/testing/sysfs-bus-peci > > > new file mode 100644 > > > index 000000000000..56c2b2216bbd > > > --- /dev/null > > > +++ b/Documentation/ABI/testing/sysfs-bus-peci > > > @@ -0,0 +1,16 @@ > > > +What: /sys/bus/peci/rescan > > > +Date: July 2021 > > > +KernelVersion: 5.15 > > > > 5.15 was a long time ago :( > > > > > > Other than this nit, these all look semi-sane to me. What tree are you > > wanting these to go through, mine? If so, can you fix this up (both > > places in this file) and resend? > > Yes, I recommend Iwona send these through your tree. > > Thanks for taking another look over them. Thanks to Iwona and Intel > for doing this work. Can you provide an ack or reviewed-by for them when they are reposted so I know this? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABA11C433F5 for ; Tue, 8 Feb 2022 11:29:16 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JtLPk5CJHz3bT6 for ; Tue, 8 Feb 2022 22:29:14 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=t0ybZeeH; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=t0ybZeeH; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JtLNz5KScz2xXX; Tue, 8 Feb 2022 22:28:34 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD7D7615EF; Tue, 8 Feb 2022 11:28:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2927C004E1; Tue, 8 Feb 2022 11:28:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1644319711; bh=S/OkajaK//lhGgvpH8Fw06Nx4ATm9sAyJIS5raQ2bvQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t0ybZeeHBJKmL5e5GBklD/SFNg2ORM9tj6Uo94eWeAyDaZznYCaSGBMNaoKafm9Rx o26RX7aXd2Niprs6HcmE6Xc+k1+wpuIvcCGKjthZfKnrVjNwbyTlR6uWsSW7lg2Sgn rVoqZL/xTG2Nwq7Q4um8qFYpeVKRyLKz3iFMsY8o= Date: Tue, 8 Feb 2022 12:28:29 +0100 From: Greg Kroah-Hartman To: Joel Stanley Subject: Re: [PATCH v7 07/13] peci: Add sysfs interface for PECI bus Message-ID: References: <20220202144838.163875-1-iwona.winiarska@intel.com> <20220202144838.163875-8-iwona.winiarska@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed , linux-doc@vger.kernel.org, Dave Hansen , Zev Weiss , Jonathan Corbet , Iwona Winiarska , OpenBMC Maillist , Pierre-Louis Bossart , Guenter Roeck , devicetree , Jean Delvare , Arnd Bergmann , Billy Tsai , Rob Herring , Borislav Petkov , Dan Williams , Andy Shevchenko , Linux ARM , linux-hwmon@vger.kernel.org, Tony Luck , Andrew Jeffery , Randy Dunlap , Linux Kernel Mailing List , Olof Johansson Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Tue, Feb 08, 2022 at 11:15:30AM +0000, Joel Stanley wrote: > On Tue, 8 Feb 2022 at 11:08, Greg Kroah-Hartman > wrote: > > > > On Wed, Feb 02, 2022 at 03:48:32PM +0100, Iwona Winiarska wrote: > > > PECI devices may not be discoverable at the time when PECI controller is > > > being added (e.g. BMC can boot up when the Host system is still in S5). > > > Since we currently don't have the capabilities to figure out the Host > > > system state inside the PECI subsystem itself, we have to rely on > > > userspace to do it for us. > > > > > > In the future, PECI subsystem may be expanded with mechanisms that allow > > > us to avoid depending on userspace interaction (e.g. CPU presence could > > > be detected using GPIO, and the information on whether it's discoverable > > > could be obtained over IPMI). > > > Unfortunately, those methods may ultimately not be available (support > > > will vary from platform to platform), which means that we still need > > > platform independent method triggered by userspace. > > > > > > Signed-off-by: Iwona Winiarska > > > --- > > > Documentation/ABI/testing/sysfs-bus-peci | 16 +++++ > > > drivers/peci/Makefile | 2 +- > > > drivers/peci/core.c | 3 +- > > > drivers/peci/device.c | 1 + > > > drivers/peci/internal.h | 5 ++ > > > drivers/peci/sysfs.c | 82 ++++++++++++++++++++++++ > > > 6 files changed, 107 insertions(+), 2 deletions(-) > > > create mode 100644 Documentation/ABI/testing/sysfs-bus-peci > > > create mode 100644 drivers/peci/sysfs.c > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-peci b/Documentation/ABI/testing/sysfs-bus-peci > > > new file mode 100644 > > > index 000000000000..56c2b2216bbd > > > --- /dev/null > > > +++ b/Documentation/ABI/testing/sysfs-bus-peci > > > @@ -0,0 +1,16 @@ > > > +What: /sys/bus/peci/rescan > > > +Date: July 2021 > > > +KernelVersion: 5.15 > > > > 5.15 was a long time ago :( > > > > > > Other than this nit, these all look semi-sane to me. What tree are you > > wanting these to go through, mine? If so, can you fix this up (both > > places in this file) and resend? > > Yes, I recommend Iwona send these through your tree. > > Thanks for taking another look over them. Thanks to Iwona and Intel > for doing this work. Can you provide an ack or reviewed-by for them when they are reposted so I know this? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6B8CC433F5 for ; Tue, 8 Feb 2022 11:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ji4R7W5AUd6EQlLvIrIJ05Kg/03DzblRb9+/hb2o6F4=; b=UUEJ2hTveF4IgN Bb3yNlaZLLeQA95Cwb2KoxYvRhmWe1KNQT6fUgWDHiMrjLt4s0/SOU1bBYjdGJGjKtk3WJAO4SuD8 tMoPFCrETMRFqMDVOesE2wx14Hqri8b3R2Mo7A66hB2EOMz5mlD5lLFA7wPHxgiG+dE3D2nRxY1iT 5fuIenvQ7RjKoKBNzqCsh2u48js8juXgWC029fW2ATH8ATvX2/LDMZx+1w6196DcgRCi/ZoVMEDRE iAkOcdWPwFStox3OBj15xL3TjfedUloPLJIGerJ24FwBAIAootprTMHUrg5IBU2mL3rAClMefOFIt tnXNUBCpusnO/qWiYwSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHOfk-00Dc7m-0R; Tue, 08 Feb 2022 11:28:36 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHOfg-00Dc6t-AH for linux-arm-kernel@lists.infradead.org; Tue, 08 Feb 2022 11:28:33 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD7D7615EF; Tue, 8 Feb 2022 11:28:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2927C004E1; Tue, 8 Feb 2022 11:28:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1644319711; bh=S/OkajaK//lhGgvpH8Fw06Nx4ATm9sAyJIS5raQ2bvQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t0ybZeeHBJKmL5e5GBklD/SFNg2ORM9tj6Uo94eWeAyDaZznYCaSGBMNaoKafm9Rx o26RX7aXd2Niprs6HcmE6Xc+k1+wpuIvcCGKjthZfKnrVjNwbyTlR6uWsSW7lg2Sgn rVoqZL/xTG2Nwq7Q4um8qFYpeVKRyLKz3iFMsY8o= Date: Tue, 8 Feb 2022 12:28:29 +0100 From: Greg Kroah-Hartman To: Joel Stanley Cc: Iwona Winiarska , Linux Kernel Mailing List , OpenBMC Maillist , devicetree , linux-aspeed , Linux ARM , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, Rob Herring , Andrew Jeffery , Jean Delvare , Guenter Roeck , Arnd Bergmann , Olof Johansson , Jonathan Corbet , Borislav Petkov , Pierre-Louis Bossart , Tony Luck , Andy Shevchenko , Dan Williams , Randy Dunlap , Zev Weiss , David Muller , Dave Hansen , Billy Tsai Subject: Re: [PATCH v7 07/13] peci: Add sysfs interface for PECI bus Message-ID: References: <20220202144838.163875-1-iwona.winiarska@intel.com> <20220202144838.163875-8-iwona.winiarska@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220208_032832_459305_9DFDEA2A X-CRM114-Status: GOOD ( 36.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 08, 2022 at 11:15:30AM +0000, Joel Stanley wrote: > On Tue, 8 Feb 2022 at 11:08, Greg Kroah-Hartman > wrote: > > > > On Wed, Feb 02, 2022 at 03:48:32PM +0100, Iwona Winiarska wrote: > > > PECI devices may not be discoverable at the time when PECI controller is > > > being added (e.g. BMC can boot up when the Host system is still in S5). > > > Since we currently don't have the capabilities to figure out the Host > > > system state inside the PECI subsystem itself, we have to rely on > > > userspace to do it for us. > > > > > > In the future, PECI subsystem may be expanded with mechanisms that allow > > > us to avoid depending on userspace interaction (e.g. CPU presence could > > > be detected using GPIO, and the information on whether it's discoverable > > > could be obtained over IPMI). > > > Unfortunately, those methods may ultimately not be available (support > > > will vary from platform to platform), which means that we still need > > > platform independent method triggered by userspace. > > > > > > Signed-off-by: Iwona Winiarska > > > --- > > > Documentation/ABI/testing/sysfs-bus-peci | 16 +++++ > > > drivers/peci/Makefile | 2 +- > > > drivers/peci/core.c | 3 +- > > > drivers/peci/device.c | 1 + > > > drivers/peci/internal.h | 5 ++ > > > drivers/peci/sysfs.c | 82 ++++++++++++++++++++++++ > > > 6 files changed, 107 insertions(+), 2 deletions(-) > > > create mode 100644 Documentation/ABI/testing/sysfs-bus-peci > > > create mode 100644 drivers/peci/sysfs.c > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-peci b/Documentation/ABI/testing/sysfs-bus-peci > > > new file mode 100644 > > > index 000000000000..56c2b2216bbd > > > --- /dev/null > > > +++ b/Documentation/ABI/testing/sysfs-bus-peci > > > @@ -0,0 +1,16 @@ > > > +What: /sys/bus/peci/rescan > > > +Date: July 2021 > > > +KernelVersion: 5.15 > > > > 5.15 was a long time ago :( > > > > > > Other than this nit, these all look semi-sane to me. What tree are you > > wanting these to go through, mine? If so, can you fix this up (both > > places in this file) and resend? > > Yes, I recommend Iwona send these through your tree. > > Thanks for taking another look over them. Thanks to Iwona and Intel > for doing this work. Can you provide an ack or reviewed-by for them when they are reposted so I know this? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel