From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4687769298607036984==" MIME-Version: 1.0 From: Mark Rutland To: kbuild-all@lists.01.org Subject: Re: [peterz-queue:sched/core 32/32] arch/arm64/include/asm/preempt.h:85:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_TRUE' Date: Tue, 08 Feb 2022 18:49:07 +0000 Message-ID: In-Reply-To: <202202081918.RDLHzFHh-lkp@intel.com> List-Id: --===============4687769298607036984== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, Feb 08, 2022 at 07:08:33PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git = sched/core > head: ac7695a93a578befdcf4900a90860bf19e057e1b > commit: ac7695a93a578befdcf4900a90860bf19e057e1b [32/32] arm64: support P= REEMPT_DYNAMIC > >> arch/arm64/include/asm/preempt.h:85:1: warning: data definition has no= type or storage class > 85 | DECLARE_STATIC_KEY_TRUE(sk_dynamic_irqentry_exit_cond_resched); > | ^~~~~~~~~~~~~~~~~~~~~~~ This is because I forgot to include , so GCC has no idea what `DECLARE_STATIC_KEY_TRUE` means. I'll go add that where needed and check that doesn't introduce a circular dependency. Thanks, Mark. --===============4687769298607036984==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01E8BC433EF for ; Tue, 8 Feb 2022 18:49:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385503AbiBHSt1 (ORCPT ); Tue, 8 Feb 2022 13:49:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385498AbiBHStO (ORCPT ); Tue, 8 Feb 2022 13:49:14 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 835D2C0612BA for ; Tue, 8 Feb 2022 10:49:13 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2C2701FB; Tue, 8 Feb 2022 10:49:13 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.89.190]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 53D813F73B; Tue, 8 Feb 2022 10:49:12 -0800 (PST) Date: Tue, 8 Feb 2022 18:49:07 +0000 From: Mark Rutland To: kernel test robot Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Peter Zijlstra Subject: Re: [peterz-queue:sched/core 32/32] arch/arm64/include/asm/preempt.h:85:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_TRUE' Message-ID: References: <202202081918.RDLHzFHh-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202202081918.RDLHzFHh-lkp@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 08, 2022 at 07:08:33PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core > head: ac7695a93a578befdcf4900a90860bf19e057e1b > commit: ac7695a93a578befdcf4900a90860bf19e057e1b [32/32] arm64: support PREEMPT_DYNAMIC > >> arch/arm64/include/asm/preempt.h:85:1: warning: data definition has no type or storage class > 85 | DECLARE_STATIC_KEY_TRUE(sk_dynamic_irqentry_exit_cond_resched); > | ^~~~~~~~~~~~~~~~~~~~~~~ This is because I forgot to include , so GCC has no idea what `DECLARE_STATIC_KEY_TRUE` means. I'll go add that where needed and check that doesn't introduce a circular dependency. Thanks, Mark.