From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 3/5] tst_test.sh: Add $TST_FORMAT_DEVICE and related vars
Date: Tue, 8 Feb 2022 18:58:46 +0100 [thread overview]
Message-ID: <YgKvVsFZZ9I3zBWi@yuki> (raw)
In-Reply-To: <YgKqKM32COAnmxfo@pevik>
Hi!
> Do you mean to swap here? i.e.:
> tst_mkfs "$TST_FS_TYPE" "$TST_DEV_FS_OPTS" "$TST_DEVICE" "$TST_DEV_EXTRA_OPTS"
>
> But in tst_mkfs it has always been the second parameter:
> local device=${2:-$TST_DEVICE}
>
> What am I missing?
The email that explains why we can't add dev_extra_ops to the tst_mkfs
the same way we do in C?
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-08 17:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 18:12 [LTP] [PATCH 0/5] shell: Add TST_FORMAT_DEVICE support Petr Vorel
2022-01-26 18:12 ` [LTP] [PATCH 1/5] tst_test.sh: Add $TST_DEFAULT_FS_TYPE Petr Vorel
2022-02-08 13:47 ` Cyril Hrubis
2022-02-08 18:20 ` Petr Vorel
2022-01-26 18:12 ` [LTP] [PATCH 2/5] tst_test.sh: tst_mkfs(): Add support for extra opts Petr Vorel
2022-02-08 14:06 ` Cyril Hrubis
2022-02-08 18:08 ` Petr Vorel
2022-02-08 18:28 ` Petr Vorel
2022-02-09 16:05 ` Petr Vorel
2022-02-09 16:13 ` Petr Vorel
2022-01-26 18:12 ` [LTP] [PATCH 3/5] tst_test.sh: Add $TST_FORMAT_DEVICE and related vars Petr Vorel
2022-02-08 14:13 ` Cyril Hrubis
2022-02-08 17:36 ` Petr Vorel
2022-02-08 17:58 ` Cyril Hrubis [this message]
2022-02-08 18:26 ` Petr Vorel
2022-01-26 18:12 ` [LTP] [PATCH 4/5] df01.sh: Use TST_FORMAT_DEVICE=1 Petr Vorel
2022-01-26 18:12 ` [LTP] [PATCH 5/5] shell: Add test for TST_FORMAT_DEVICE=1 Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgKvVsFZZ9I3zBWi@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.