From: Tzung-Bi Shih <tzungbi@google.com>
To: Prashant Malani <pmalani@chromium.org>
Cc: bleung@chromium.org, groeck@chromium.org,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH v2 2/6] platform/chrome: cros_ec: remove unused variable `was_wake_device`
Date: Wed, 9 Feb 2022 17:36:07 +0800 [thread overview]
Message-ID: <YgOLBzePK+EEbUk8@google.com> (raw)
In-Reply-To: <CACeCKadu_wunV8YfC8vjK2tkewseNDadbYGATc+-FX0DfUNUZQ@mail.gmail.com>
On Tue, Feb 08, 2022 at 09:58:41PM -0800, Prashant Malani wrote:
> On Tue, Feb 8, 2022 at 8:50 PM Tzung-Bi Shih <tzungbi@google.com> wrote:
> >
> > `was_wake_device` is unused. Remove it.
> nit: This commit message doesn't add anything to the patch (it is
> repeating the subject), so it
> should be fine to drop it.
Ack.
> > ---
> In the future, please add a change log for versions here. Quoting the
> patch submission guide [1]
>
> "One good use for the additional comments after the --- marker
> is...Other comments relevant
> only to the moment or the maintainer, not suitable for the permanent
> changelog, should also
> go here. A good example of such comments might be patch changelogs
> which describe what
> has changed between the v1 and v2 version of the patch."
>
> [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
They are in the cover letter. Will copy them to each patch.
next prev parent reply other threads:[~2022-02-09 9:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 4:50 [PATCH v2 0/6] platform/chrome: cros_ec: miscellaneous cleanups Tzung-Bi Shih
2022-02-09 4:50 ` [PATCH v2 1/6] platform/chrome: cros_ec: fix error handling in cros_ec_register() Tzung-Bi Shih
2022-02-09 5:38 ` Prashant Malani
2022-02-09 9:35 ` Tzung-Bi Shih
2022-02-09 4:50 ` [PATCH v2 2/6] platform/chrome: cros_ec: remove unused variable `was_wake_device` Tzung-Bi Shih
2022-02-09 5:58 ` Prashant Malani
2022-02-09 9:36 ` Tzung-Bi Shih [this message]
2022-02-09 4:50 ` [PATCH v2 3/6] platform/chrome: cros_ec: determine `wake_enabled` in cros_ec_suspend() Tzung-Bi Shih
2022-02-09 6:05 ` Prashant Malani
2022-02-09 9:36 ` Tzung-Bi Shih
2022-02-16 1:07 ` Prashant Malani
2022-02-16 4:13 ` Tzung-Bi Shih
2022-02-16 5:55 ` Prashant Malani
2022-02-16 7:33 ` Tzung-Bi Shih
2022-02-09 4:50 ` [PATCH v2 4/6] platform/chrome: cros_ec: don't initialize `err` in cros_ec_register() Tzung-Bi Shih
2022-02-09 6:08 ` Prashant Malani
2022-02-09 9:37 ` Tzung-Bi Shih
2022-02-09 4:50 ` [PATCH v2 5/6] platform/chrome: cros_ec: sort header inclusion alphabetically Tzung-Bi Shih
2022-02-09 4:50 ` [PATCH v2 6/6] platform/chrome: cros_ec: append newline to all logs Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgOLBzePK+EEbUk8@google.com \
--to=tzungbi@google.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.