From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: ctnetlink: use dump structure instead of raw args
Date: Wed, 9 Feb 2022 12:06:52 +0100 [thread overview]
Message-ID: <YgOgTLD43OzJguVK@salvia> (raw)
In-Reply-To: <20220209104659.GF25000@breakpoint.cc>
On Wed, Feb 09, 2022 at 11:46:59AM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > static int ctnetlink_done_list(struct netlink_callback *cb)
> > > {
> > > - if (cb->args[1])
> > > - nf_ct_put((struct nf_conn *)cb->args[1]);
> > > + struct ctnetlink_list_dump_ctx *ctx = (void *)cb->ctx;
> >
> > Where is cb->ctx initialized?
>
> Its zeroed in __netlink_dump_start, cb->ctx and cb->args are aliased
> via union inside netlink_callback struct.
Ah I see, it's all zero initially.
Thanks for explaining.
prev parent reply other threads:[~2022-02-09 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 12:11 [PATCH nf-next] netfilter: ctnetlink: use dump structure instead of raw args Florian Westphal
2022-02-09 10:43 ` Pablo Neira Ayuso
2022-02-09 10:46 ` Florian Westphal
2022-02-09 11:06 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgOgTLD43OzJguVK@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.