From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8523EC43217 for ; Wed, 9 Feb 2022 17:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w2Zw4Q8e8gKaQuCsJMb0IuwfuWo0FLHNCypcqk247ts=; b=EfBwy40wxOpXgX PbjQXMhek8hhAl/vh6BP94rbfItQ9rA7IXbPfhOBuSRTibROM7SJbl1O4zz+bRqyH1o6yHuOYv+Ss gxP/Hpn1WOauvgkS7uAKt6DWTPdYI1NYnsswBUZHUp8ZZKNCMweASO8CKBpICicljnNirbMpzuyQu JrWa1/sUkwqYAjD+xmnxo6PqamdcOUPPdzCsDSS3T0K+WtC0HhPQ6Vw7DN/CGBcOU2xHBxme5KUOM Gj4P8bOBvTmcLyU+KmlflCMdSqQ0uptOe3zV+FqhCPS+5Z5r2dY60WFavrY91Qgwu6k1aV7iny8mE pSXETOJtD/VeFzjKiLsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHr5T-0010GK-Gi; Wed, 09 Feb 2022 17:49:03 +0000 Received: from mail-oo1-f42.google.com ([209.85.161.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHr5F-00109w-E5; Wed, 09 Feb 2022 17:48:50 +0000 Received: by mail-oo1-f42.google.com with SMTP id p190-20020a4a2fc7000000b0031820de484aso3294958oop.9; Wed, 09 Feb 2022 09:48:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9Q2I/VP+XFwXy/Za9m82QJTmUqxQOQNrGnI8flFPCzE=; b=iSkbyGSUfsFhVga8k8ywlf7gK2hKK+6Oqy4OrQ+ZweEjVcZC6aDQV7fu9Y/abhE/8P HQZS5CQZdzfBiP99WJsfNDbNgM1pHJ3fXl17uEjmdwHDGOJKKh7L20jUZXRoARKWA+ur HfkzVELwhxG15u78eX2dgYD49NL5j05aDkVUqH4gw4BPe1xpvNqX8BaUFaR7YRvnRM7o GNcwGN085c1jEG5LjHKi2wgpJ72h90xYDgsmRoRISfrIcNDvD+o9cnhaJTUSWPd7TsE2 20ioxTeVqdjPXWYGxTfxN8+aG319+EJhiDK68Mvigd6bAIOnzYmGbNoFUyrnlDII6+nz nixg== X-Gm-Message-State: AOAM5308VYfqWbFdbuRrRhsvyXsO5a9XkUY/gqAcWx1nmDo9HVbHmjNK MBEFrpZcSNV7xL7TAJO2Aw== X-Google-Smtp-Source: ABdhPJxLVUkyLr5K9Jth1KPAM7TMJsJ9wGQtyn4evi3+a6WwLPinzkeFbOB9l+rfCrvEzu15f2MLgg== X-Received: by 2002:a05:6870:6296:: with SMTP id s22mr1124414oan.338.1644428928376; Wed, 09 Feb 2022 09:48:48 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id r41sm6103687oap.2.2022.02.09.09.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 09:48:47 -0800 (PST) Received: (nullmailer pid 581562 invoked by uid 1000); Wed, 09 Feb 2022 17:48:46 -0000 Date: Wed, 9 Feb 2022 11:48:46 -0600 From: Rob Herring To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Michael Riesch , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Daniel Vetter , dri-devel@lists.freedesktop.org, Peter Geis , Nicolas Frattaroli , Sascha Hauer , Ezequiel Garcia , linux-kernel@vger.kernel.org, Liang Chen , devicetree@vger.kernel.org, David Airlie , Alex Bee Subject: Re: [PATCH v5 1/5] dt-bindings: gpu: mali-bifrost: describe clocks for the rk356x gpu Message-ID: References: <20220209085110.3588035-1-michael.riesch@wolfvision.net> <1644420908.380944.391811.nullmailer@robh.at.kernel.org> <01b78d95-fdf3-060a-831d-dae2abbc7109@wolfvision.net> <3297396.uCXnvZdJcx@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3297396.uCXnvZdJcx@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_094849_502653_F676BBCB X-CRM114-Status: GOOD ( 26.15 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, Feb 09, 2022 at 05:28:05PM +0100, Heiko St=FCbner wrote: > Hi Michael, > = > Am Mittwoch, 9. Februar 2022, 16:46:28 CET schrieb Michael Riesch: > > Hi Rob, > > = > > On 2/9/22 16:35, Rob Herring wrote: > > > On Wed, 09 Feb 2022 09:51:06 +0100, Michael Riesch wrote: > > >> From: Alex Bee > > >> > > >> The Bifrost GPU in Rockchip RK356x SoCs has a core and a bus clock. > > >> Reflect this in the SoC specific part of the binding. > > >> > > >> Signed-off-by: Alex Bee > > >> [move the changes to the SoC section] > > >> Signed-off-by: Michael Riesch > > >> --- > > >> .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 15 ++++++++++++= +++ > > >> 1 file changed, 15 insertions(+) > > >> > > > = > > > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_ch= eck' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > = > > > yamllint warnings/errors: > > > ./Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml:173:12:= [warning] wrong indentation: expected 12 but found 11 (indentation) > > = > > D'oh! Sorry for the stupid mistake, I found that yamllint was indeed > > missing. > > = > > Lines 173 and 174 need an extra space. In the case that a v6 is required > > I'll fix this. But of course I wouldn't say no if this could be fixed > > when the patch is applied :-) > = > My guess is, Rob's bot filters out the easy wrongs, so I'm not sure if he > actually looks at these in person. I do because there are sometimes false positives. It's not a free = testing service. (Well, it might be free beer for you, but that's = because I'm buying. :) ) For just indentation I will still review them = (eventually). > So doing a v6 might actually be better for a Review :-) Resending just moves you to the back of the line (usually). = Rob _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F081C433F5 for ; Wed, 9 Feb 2022 17:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bv7/vkl2n4mbZFVfntAkuKhSTLMcwYy+ovTmGNaet6E=; b=rsoQ7Damfpl1nZ c0bH7wGXFZQydRL7aFgUprRqy9scnnPMqr/9Qb3IQx3lwFLW1fTUu/k38mO4XnFjS3B3e6e3V1Jin gcHZyGd8upCK/uGnPHYEVJNVmq993/Zpyql4vOh1UAbog2Sv8RpuupvpLnHR6v/Zqk7BKelwXF0YF ernuevg6hVT/iwGE9gkQyUXOzU5wI5uNG8sJgQ/MWVWEqTWH+qjQdsFjE27dhnq2okNiwYQ6Bkquy bj49QrhqOi6mNAAI8yiPzreJQpcK22MRID84ZC8WIYt3e+qD160H5mg2aRa18EF9KXg1GF/Fst6cR e9b8oMbvMs1EDVsHEopw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHr5J-0010BJ-9w; Wed, 09 Feb 2022 17:48:53 +0000 Received: from mail-oo1-f42.google.com ([209.85.161.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHr5F-00109w-E5; Wed, 09 Feb 2022 17:48:50 +0000 Received: by mail-oo1-f42.google.com with SMTP id p190-20020a4a2fc7000000b0031820de484aso3294958oop.9; Wed, 09 Feb 2022 09:48:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9Q2I/VP+XFwXy/Za9m82QJTmUqxQOQNrGnI8flFPCzE=; b=iSkbyGSUfsFhVga8k8ywlf7gK2hKK+6Oqy4OrQ+ZweEjVcZC6aDQV7fu9Y/abhE/8P HQZS5CQZdzfBiP99WJsfNDbNgM1pHJ3fXl17uEjmdwHDGOJKKh7L20jUZXRoARKWA+ur HfkzVELwhxG15u78eX2dgYD49NL5j05aDkVUqH4gw4BPe1xpvNqX8BaUFaR7YRvnRM7o GNcwGN085c1jEG5LjHKi2wgpJ72h90xYDgsmRoRISfrIcNDvD+o9cnhaJTUSWPd7TsE2 20ioxTeVqdjPXWYGxTfxN8+aG319+EJhiDK68Mvigd6bAIOnzYmGbNoFUyrnlDII6+nz nixg== X-Gm-Message-State: AOAM5308VYfqWbFdbuRrRhsvyXsO5a9XkUY/gqAcWx1nmDo9HVbHmjNK MBEFrpZcSNV7xL7TAJO2Aw== X-Google-Smtp-Source: ABdhPJxLVUkyLr5K9Jth1KPAM7TMJsJ9wGQtyn4evi3+a6WwLPinzkeFbOB9l+rfCrvEzu15f2MLgg== X-Received: by 2002:a05:6870:6296:: with SMTP id s22mr1124414oan.338.1644428928376; Wed, 09 Feb 2022 09:48:48 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id r41sm6103687oap.2.2022.02.09.09.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 09:48:47 -0800 (PST) Received: (nullmailer pid 581562 invoked by uid 1000); Wed, 09 Feb 2022 17:48:46 -0000 Date: Wed, 9 Feb 2022 11:48:46 -0600 From: Rob Herring To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Michael Riesch , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Daniel Vetter , dri-devel@lists.freedesktop.org, Peter Geis , Nicolas Frattaroli , Sascha Hauer , Ezequiel Garcia , linux-kernel@vger.kernel.org, Liang Chen , devicetree@vger.kernel.org, David Airlie , Alex Bee Subject: Re: [PATCH v5 1/5] dt-bindings: gpu: mali-bifrost: describe clocks for the rk356x gpu Message-ID: References: <20220209085110.3588035-1-michael.riesch@wolfvision.net> <1644420908.380944.391811.nullmailer@robh.at.kernel.org> <01b78d95-fdf3-060a-831d-dae2abbc7109@wolfvision.net> <3297396.uCXnvZdJcx@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3297396.uCXnvZdJcx@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_094849_502653_F676BBCB X-CRM114-Status: GOOD ( 26.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 09, 2022 at 05:28:05PM +0100, Heiko St=FCbner wrote: > Hi Michael, > = > Am Mittwoch, 9. Februar 2022, 16:46:28 CET schrieb Michael Riesch: > > Hi Rob, > > = > > On 2/9/22 16:35, Rob Herring wrote: > > > On Wed, 09 Feb 2022 09:51:06 +0100, Michael Riesch wrote: > > >> From: Alex Bee > > >> > > >> The Bifrost GPU in Rockchip RK356x SoCs has a core and a bus clock. > > >> Reflect this in the SoC specific part of the binding. > > >> > > >> Signed-off-by: Alex Bee > > >> [move the changes to the SoC section] > > >> Signed-off-by: Michael Riesch > > >> --- > > >> .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 15 ++++++++++++= +++ > > >> 1 file changed, 15 insertions(+) > > >> > > > = > > > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_ch= eck' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > = > > > yamllint warnings/errors: > > > ./Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml:173:12:= [warning] wrong indentation: expected 12 but found 11 (indentation) > > = > > D'oh! Sorry for the stupid mistake, I found that yamllint was indeed > > missing. > > = > > Lines 173 and 174 need an extra space. In the case that a v6 is required > > I'll fix this. But of course I wouldn't say no if this could be fixed > > when the patch is applied :-) > = > My guess is, Rob's bot filters out the easy wrongs, so I'm not sure if he > actually looks at these in person. I do because there are sometimes false positives. It's not a free = testing service. (Well, it might be free beer for you, but that's = because I'm buying. :) ) For just indentation I will still review them = (eventually). > So doing a v6 might actually be better for a Review :-) Resending just moves you to the back of the line (usually). = Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E73C433EF for ; Wed, 9 Feb 2022 17:48:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238445AbiBIRss (ORCPT ); Wed, 9 Feb 2022 12:48:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238447AbiBIRsq (ORCPT ); Wed, 9 Feb 2022 12:48:46 -0500 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B8A3C05CB88; Wed, 9 Feb 2022 09:48:49 -0800 (PST) Received: by mail-oo1-f48.google.com with SMTP id k13-20020a4a948d000000b003172f2f6bdfso3340639ooi.1; Wed, 09 Feb 2022 09:48:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9Q2I/VP+XFwXy/Za9m82QJTmUqxQOQNrGnI8flFPCzE=; b=XG5AIE+bpgmkBq4s9jP6uDrqIzghOy2TUAc63+GE/Xyimg/eypqRdscLKOg3NkV2i7 s6tYlf0AAI/v9qyKBHmtE2qjU2OaMulYd8DbHiw2zGFXp9KpAkGsdfjf6eLXAS0SKdrD ja6GTEkQhrcKKon6rrvPbafI318sPUGYgLDxepCq1STuKJW7M1f4RiUpRGoVQwzTM5iv Jd16d5nB2yRN3oPZyw9HQ50dfq5v0ltnk79+EfPo9PbZAEmr7gcs9PJQz0tw729XdIXr /qE8T2zKaOXeftJDLkwP6BlHx6oZegAOaWBnowImR4KVaAXU/+pQbtRr6WUwyZ5bngog s9hg== X-Gm-Message-State: AOAM532TLxFfuaXxcCxLGg0pWjs6N26+OSRDaUg4Qv/vBixLzh26xwUQ 8tJW9Jp0HwnzPpjjP5Dt0Q== X-Google-Smtp-Source: ABdhPJxLVUkyLr5K9Jth1KPAM7TMJsJ9wGQtyn4evi3+a6WwLPinzkeFbOB9l+rfCrvEzu15f2MLgg== X-Received: by 2002:a05:6870:6296:: with SMTP id s22mr1124414oan.338.1644428928376; Wed, 09 Feb 2022 09:48:48 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id r41sm6103687oap.2.2022.02.09.09.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 09:48:47 -0800 (PST) Received: (nullmailer pid 581562 invoked by uid 1000); Wed, 09 Feb 2022 17:48:46 -0000 Date: Wed, 9 Feb 2022 11:48:46 -0600 From: Rob Herring To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Michael Riesch , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Daniel Vetter , dri-devel@lists.freedesktop.org, Peter Geis , Nicolas Frattaroli , Sascha Hauer , Ezequiel Garcia , linux-kernel@vger.kernel.org, Liang Chen , devicetree@vger.kernel.org, David Airlie , Alex Bee Subject: Re: [PATCH v5 1/5] dt-bindings: gpu: mali-bifrost: describe clocks for the rk356x gpu Message-ID: References: <20220209085110.3588035-1-michael.riesch@wolfvision.net> <1644420908.380944.391811.nullmailer@robh.at.kernel.org> <01b78d95-fdf3-060a-831d-dae2abbc7109@wolfvision.net> <3297396.uCXnvZdJcx@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3297396.uCXnvZdJcx@diego> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Feb 09, 2022 at 05:28:05PM +0100, Heiko Stübner wrote: > Hi Michael, > > Am Mittwoch, 9. Februar 2022, 16:46:28 CET schrieb Michael Riesch: > > Hi Rob, > > > > On 2/9/22 16:35, Rob Herring wrote: > > > On Wed, 09 Feb 2022 09:51:06 +0100, Michael Riesch wrote: > > >> From: Alex Bee > > >> > > >> The Bifrost GPU in Rockchip RK356x SoCs has a core and a bus clock. > > >> Reflect this in the SoC specific part of the binding. > > >> > > >> Signed-off-by: Alex Bee > > >> [move the changes to the SoC section] > > >> Signed-off-by: Michael Riesch > > >> --- > > >> .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 15 +++++++++++++++ > > >> 1 file changed, 15 insertions(+) > > >> > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > yamllint warnings/errors: > > > ./Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml:173:12: [warning] wrong indentation: expected 12 but found 11 (indentation) > > > > D'oh! Sorry for the stupid mistake, I found that yamllint was indeed > > missing. > > > > Lines 173 and 174 need an extra space. In the case that a v6 is required > > I'll fix this. But of course I wouldn't say no if this could be fixed > > when the patch is applied :-) > > My guess is, Rob's bot filters out the easy wrongs, so I'm not sure if he > actually looks at these in person. I do because there are sometimes false positives. It's not a free testing service. (Well, it might be free beer for you, but that's because I'm buying. :) ) For just indentation I will still review them (eventually). > So doing a v6 might actually be better for a Review :-) Resending just moves you to the back of the line (usually). Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 091B8C433F5 for ; Wed, 9 Feb 2022 17:48:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4242510E2DB; Wed, 9 Feb 2022 17:48:51 +0000 (UTC) Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B56010E2DB for ; Wed, 9 Feb 2022 17:48:49 +0000 (UTC) Received: by mail-oo1-f44.google.com with SMTP id q145-20020a4a3397000000b002e85c7234b1so3308999ooq.8 for ; Wed, 09 Feb 2022 09:48:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9Q2I/VP+XFwXy/Za9m82QJTmUqxQOQNrGnI8flFPCzE=; b=AXjeFXzscSkAvOKeGU6msJj7aB/TYiNHMwPOUtYHYPyFOMWk91/Ku/Kcr8wWPbPeuX 6eoVlnFn3eLf9gfjgojEL8PQ50eX2rdKCVQDoqeBEuC+z97WVFmAd4v3/5JjdPzj/4lq XCBxVdsiWQM0iEWUWgsnYZSNNNb62M5+TY8DBDBgQrF+29ozEnIt3doBn2DtbhEigwe3 TZJ2ZDqvG9/tu5arPzr6gBy5ZRCG0J3uENicLYgABHO7XbzbS57aMFDPtcaABzD+VHP4 JJzH1drkOYGvuDNADPWhMBNkXF19KesxIur1s+GcR0tLY6c8Zddnu8jv/vvNnv7T6l/C JORA== X-Gm-Message-State: AOAM533HeIEGaulpyRq4ter5bZDk742ktubz8fleP+IkARV5dJKAvIkv EUe8GIoA3t6L/bXBqyvjew== X-Google-Smtp-Source: ABdhPJxLVUkyLr5K9Jth1KPAM7TMJsJ9wGQtyn4evi3+a6WwLPinzkeFbOB9l+rfCrvEzu15f2MLgg== X-Received: by 2002:a05:6870:6296:: with SMTP id s22mr1124414oan.338.1644428928376; Wed, 09 Feb 2022 09:48:48 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id r41sm6103687oap.2.2022.02.09.09.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 09:48:47 -0800 (PST) Received: (nullmailer pid 581562 invoked by uid 1000); Wed, 09 Feb 2022 17:48:46 -0000 Date: Wed, 9 Feb 2022 11:48:46 -0600 From: Rob Herring To: Heiko =?iso-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v5 1/5] dt-bindings: gpu: mali-bifrost: describe clocks for the rk356x gpu Message-ID: References: <20220209085110.3588035-1-michael.riesch@wolfvision.net> <1644420908.380944.391811.nullmailer@robh.at.kernel.org> <01b78d95-fdf3-060a-831d-dae2abbc7109@wolfvision.net> <3297396.uCXnvZdJcx@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3297396.uCXnvZdJcx@diego> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Peter Geis , David Airlie , Sascha Hauer , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Bee , Nicolas Frattaroli , linux-rockchip@lists.infradead.org, Michael Riesch , Liang Chen , linux-arm-kernel@lists.infradead.org, Ezequiel Garcia Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Feb 09, 2022 at 05:28:05PM +0100, Heiko Stübner wrote: > Hi Michael, > > Am Mittwoch, 9. Februar 2022, 16:46:28 CET schrieb Michael Riesch: > > Hi Rob, > > > > On 2/9/22 16:35, Rob Herring wrote: > > > On Wed, 09 Feb 2022 09:51:06 +0100, Michael Riesch wrote: > > >> From: Alex Bee > > >> > > >> The Bifrost GPU in Rockchip RK356x SoCs has a core and a bus clock. > > >> Reflect this in the SoC specific part of the binding. > > >> > > >> Signed-off-by: Alex Bee > > >> [move the changes to the SoC section] > > >> Signed-off-by: Michael Riesch > > >> --- > > >> .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 15 +++++++++++++++ > > >> 1 file changed, 15 insertions(+) > > >> > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > yamllint warnings/errors: > > > ./Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml:173:12: [warning] wrong indentation: expected 12 but found 11 (indentation) > > > > D'oh! Sorry for the stupid mistake, I found that yamllint was indeed > > missing. > > > > Lines 173 and 174 need an extra space. In the case that a v6 is required > > I'll fix this. But of course I wouldn't say no if this could be fixed > > when the patch is applied :-) > > My guess is, Rob's bot filters out the easy wrongs, so I'm not sure if he > actually looks at these in person. I do because there are sometimes false positives. It's not a free testing service. (Well, it might be free beer for you, but that's because I'm buying. :) ) For just indentation I will still review them (eventually). > So doing a v6 might actually be better for a Review :-) Resending just moves you to the back of the line (usually). Rob