From: Andrew Lunn <andrew@lunn.ch>
To: DENG Qingfang <dqfext@gmail.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531
Date: Wed, 9 Feb 2022 16:53:38 +0100 [thread overview]
Message-ID: <YgPjgvlVkykx1e1G@lunn.ch> (raw)
In-Reply-To: <20220209143948.445823-1-dqfext@gmail.com>
On Wed, Feb 09, 2022 at 10:39:47PM +0800, DENG Qingfang wrote:
> The function mt7531_phy_mode_supported in the DSA driver set supported
> mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
> for the internal PHY, so this check breaks the PHY initialization:
Is the PHY actually internal? If so PHY_INTERFACE_MODE_INTERNAL would
be correct.
Are you fixing the wrong thing here?
Andrew
next prev parent reply other threads:[~2022-02-09 15:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 14:39 [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531 DENG Qingfang
2022-02-09 14:39 ` DENG Qingfang
2022-02-09 14:39 ` DENG Qingfang
2022-02-09 14:47 ` Arınç ÜNAL
2022-02-09 14:47 ` Arınç ÜNAL
2022-02-09 14:47 ` Arınç ÜNAL
2022-02-09 15:53 ` Andrew Lunn [this message]
2022-02-11 1:24 ` DENG Qingfang
2022-02-09 22:11 ` Hauke Mehrtens
2022-02-09 22:11 ` Hauke Mehrtens
2022-02-09 22:11 ` Hauke Mehrtens
2022-02-15 14:30 ` patchwork-bot+netdevbpf
2022-02-15 14:30 ` patchwork-bot+netdevbpf
2022-02-15 14:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgPjgvlVkykx1e1G@lunn.ch \
--to=andrew@lunn.ch \
--cc=dqfext@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.