All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, kernel@axis.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: Add bindings for TPS62864x
Date: Wed, 9 Feb 2022 12:05:33 -0600	[thread overview]
Message-ID: <YgQCbVwMe69MHMaX@robh.at.kernel.org> (raw)
In-Reply-To: <20220204155241.576342-2-vincent.whitchurch@axis.com>

On Fri, Feb 04, 2022 at 04:52:40PM +0100, Vincent Whitchurch wrote:
> Add bindings for the TPS62864/TPS6286/TPS62868/TPS62869 voltage
> regulators.
> 
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> ---
>  .../bindings/regulator/ti,tps62864.yaml       | 62 +++++++++++++++++++
>  include/dt-bindings/regulator/ti,tps62864.h   |  9 +++
>  2 files changed, 71 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps62864.yaml
>  create mode 100644 include/dt-bindings/regulator/ti,tps62864.h
> 
> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps62864.yaml b/Documentation/devicetree/bindings/regulator/ti,tps62864.yaml
> new file mode 100644
> index 000000000000..e3d739a37ab0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps62864.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/ti,tps62864.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI TPS62864/TPS6286/TPS62868/TPS62869 voltage regulator
> +
> +maintainers:
> +  - Vincent Whitchurch <vincent.whitchurch@axis.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tps62864
> +      - ti,tps62866
> +      - ti,tps62868
> +      - ti,tps62869
> +
> +  reg:
> +    maxItems: 1
> +
> +  regulators:
> +    type: object
> +
> +    patternProperties:
> +      "SW":

Not a pattern, use 'properties'. Actually it is a pattern, so 'fooSWbar' 
would be a valid node name.

> +        type: object
> +        $ref: regulator.yaml#

           unevaluatedProperties: false

> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - regulators
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/regulator/ti,tps62864.h>
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      regulator@48 {
> +        compatible = "ti,tps62864";
> +        reg = <0x48>;
> +
> +        regulators {
> +          SW {
> +            regulator-name = "+0.85V";
> +            regulator-min-microvolt = <800000>;
> +            regulator-max-microvolt = <890000>;
> +            regulator-initial-mode = <TPS62864_MODE_FPWM>;
> +          };
> +        };
> +      };
> +    };
> +
> +...
> diff --git a/include/dt-bindings/regulator/ti,tps62864.h b/include/dt-bindings/regulator/ti,tps62864.h
> new file mode 100644
> index 000000000000..8db31f23d956
> --- /dev/null
> +++ b/include/dt-bindings/regulator/ti,tps62864.h
> @@ -0,0 +1,9 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +
> +#ifndef _DT_BINDINGS_REGULATOR_TI_TPS62864_H
> +#define _DT_BINDINGS_REGULATOR_TI_TPS62864_H
> +
> +#define TPS62864_MODE_NORMAL			0
> +#define TPS62864_MODE_FPWM			1
> +
> +#endif
> -- 
> 2.34.1
> 
> 

  reply	other threads:[~2022-02-09 18:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 15:52 [PATCH 0/2] regulator: Add support for TPS6286x Vincent Whitchurch
2022-02-04 15:52 ` [PATCH 1/2] regulator: Add bindings for TPS62864x Vincent Whitchurch
2022-02-09 18:05   ` Rob Herring [this message]
2022-02-04 15:52 ` [PATCH 2/2] regulator: Add support for TPS6286x Vincent Whitchurch
2022-02-08 19:00 ` [PATCH 0/2] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgQCbVwMe69MHMaX@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@axis.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vincent.whitchurch@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.