From: Sean Christopherson <seanjc@google.com>
To: Zhenzhong Duan <zhenzhong.duan@intel.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH] x86 UEFI: Fix broken build for UEFI
Date: Thu, 10 Feb 2022 16:30:44 +0000 [thread overview]
Message-ID: <YgU9tBiSdF1u1+c7@google.com> (raw)
In-Reply-To: <20220210092044.18808-1-zhenzhong.duan@intel.com>
On Thu, Feb 10, 2022, Zhenzhong Duan wrote:
> UEFI loads EFI applications to dynamic runtime addresses, so it requires
> all applications to be compiled as PIC (position independent code).
>
> The new introduced single-step #DB tests series bring some compile time
> absolute address, fixed it with RIP relative address.
>
> Fixes: 9734b4236294 ("x86/debug: Add framework for single-step #DB tests")
> Fixes: 6bfb9572ec04 ("x86/debug: Test IN instead of RDMSR for single-step #DB emulation test")
> Fixes: bc0dd8bdc627 ("x86/debug: Add single-step #DB + STI/MOVSS blocking tests")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> ---
Hrm. It would be nice if we could enabled -fPIC by default for tests that support
it, having to compile twice is going to be annoying...
Reviewed-and-tested-by: Sean Christopherson <seanjc@google.com>
next prev parent reply other threads:[~2022-02-10 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 9:20 [PATCH] x86 UEFI: Fix broken build for UEFI Zhenzhong Duan
2022-02-10 16:30 ` Sean Christopherson [this message]
2022-02-11 3:07 ` Duan, Zhenzhong
2022-02-14 11:14 ` Alexandru Elisei
2022-02-14 12:42 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgU9tBiSdF1u1+c7@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.