From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 394B1C433EF for ; Thu, 10 Feb 2022 19:28:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344003AbiBJT2o (ORCPT ); Thu, 10 Feb 2022 14:28:44 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343987AbiBJT2n (ORCPT ); Thu, 10 Feb 2022 14:28:43 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEEA8D83 for ; Thu, 10 Feb 2022 11:28:43 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id v4so6092166pjh.2 for ; Thu, 10 Feb 2022 11:28:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MkCAJcsgDnZ4AMQg0YJZxLL5mg72sPEcPDTYT76wphA=; b=VITXk2hMcSEjC+OZoOeI41UdOAsXXnSae+vIO1t5uiJUDG3f+W8Ujvo0MzRncXcGSg USTmlZSg0keVqVzjOeEZQixEP8Pgeq2dITc6QO3lghqqFZQJxwqFTif5bEsHgDSzNkCQ 2eE8SKwMDCYSs2aXYXFc+5kXVC2grvOSWZ9IMP+RmFomSSXp/fpnKoid/djrG+9ci/6+ l5iMO0ARPss2aCLOgxxHGPRXtXwq90RSu87KgTi6DFizS3nL3ZLpvWb0tjEZ17BsVgSy 52BW03EP4lmL4Hg/sREOKFYcn0GlisUdJyuwbMTWxFOmIkab9YrI1eHTWrNQ6y6lfoL4 Hg0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MkCAJcsgDnZ4AMQg0YJZxLL5mg72sPEcPDTYT76wphA=; b=Z/M6024N1z2axyT6GdLKmuvxn7+9LS/SyZfdnzSDvnhStRFSE48WAuL3iyX21627TV Axh29E32R2i1Qy3zcoFj/GyLKsdFXd79IIC6N734QmtNuljlZ5aW7Yd2uwpqHBnvSw4E BGTJRCNpl+gI0/GviGWUUjj2MRun4vDmHegxCcSBiEAxAFr8riblWfu4Ik3zCJupTjef WEU9gQfdBEM0OEoEafQjPTuWIePeOUkw6oRSTBm8GEWu9/uUioxdPkx6MFvBJACjfLN1 OH97cNNA4/heiwo/WufjhFNwkAng7aLbWY9u4H46MZcnJAYAtpmyyvTLsHV1gPyGiOEB 1Mqg== X-Gm-Message-State: AOAM531yGM7ET4RjfNqhy9gRbYr4iXWpFKYOJUV5ORAqBML44pph28Tf uzpGcYjd82SpEwPnSAaHMUc4Yg== X-Google-Smtp-Source: ABdhPJyGxrYzqC6mAoU/J4x4uF4c35ZsHYMs9x0CCV7EjCPecYGBzI+BZ67c1YA0cq2S+zuo8KoMXw== X-Received: by 2002:a17:903:1c8:: with SMTP id e8mr8819514plh.75.1644521323208; Thu, 10 Feb 2022 11:28:43 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id d8sm17720591pfj.179.2022.02.10.11.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 11:28:42 -0800 (PST) Date: Thu, 10 Feb 2022 19:28:39 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: David Matlack , LKML , kvm list , Vitaly Kuznetsov Subject: Re: [PATCH 00/23] KVM: MMU: MMU role refactoring Message-ID: References: <20220204115718.14934-1-pbonzini@redhat.com> <40930834-8f54-4701-d3ec-f8287bc1333f@redhat.com> <344042cf-099e-5e26-026a-c42d0825488e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <344042cf-099e-5e26-026a-c42d0825488e@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Feb 10, 2022, Paolo Bonzini wrote: > On 2/10/22 17:55, Sean Christopherson wrote: > > > union kvm_mmu_page_role root_role; > > > union kvm_mmu_paging_mode cpu_mode; > > > > I'd prefer to not use "paging mode", the SDM uses that terminology to refer to > > the four paging modes. My expectation given the name is that the union would > > track only CR0.PG, EFER.LME, CR4.PAE, and CR4.PSE[*]. > > Yeah, I had started with kvm_mmu_paging_flags, but cpu_flags was an even > worse method than kvm_mmu_paging_mode. We could always do s/is_guest_mode/is_nested_mode or something to that effect. It would take some retraining, but I feel like we've been fighting the whole "guest mode" thing over and over. > Anyway, now that I have done _some_ replacement, it's a matter of sed -i on > the patch files once you or someone else come up with a good moniker. > > I take it that "root_role" passed your filter successfully. Yep, works for me. I almost suggested it, too, but decided I liked mmu_role marginally better. I like root_role because it ties in with root_hpa and root_pga.