From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51E59C433F5 for ; Fri, 11 Feb 2022 12:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AoU/GiiAeFpZjL0xyQZNlDlGhP2R6X5a5nAy3nfKjoM=; b=Nd+n2j87kAv+hT Ll/ZcR0uR9/ilfFPm/WzkqYjzPVpiT0g5b/DLJm9yhqsEIdlP6vBYIimOvCLF6GiD88mBE6vluHbQ fRyatzatWKFGXNXRgNAUxpo+9DXm0nD+JRmq8Cvsll2VoYA+ABSKsr/JjuVKeKOyffsWprCRjc1Ek 5R2pChc0k18ecMY17RqlOyRY+7HAGTiHX4p9AxFxGm88ZHxh5ilcOmM1QcUa2xTM9HBA67xJKhwgh XokhlI8hVNUjTlagKvNs8YEJ8VkFGWPx06sopMQ3TkUySPyx9/4e/2OmpzBtl6echCUQJ3s/OWXGN Qy0hCjlzkMK+G+GLJ4nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIVIk-007Dqd-JK; Fri, 11 Feb 2022 12:45:26 +0000 Received: from mail-oo1-f44.google.com ([209.85.161.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIVId-007DoF-Jd for linux-arm-kernel@lists.infradead.org; Fri, 11 Feb 2022 12:45:20 +0000 Received: by mail-oo1-f44.google.com with SMTP id 189-20020a4a03c6000000b003179d7b30d8so10141805ooi.2 for ; Fri, 11 Feb 2022 04:45:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=1ZmE/JWwkWWP/1u0tD/CxpUFw+p6UWTWhaQ4GN/9I4g=; b=SprmLHUYHI26nF6Gmaz5zd53EGy5pjlz+VnSiJ2oe6AKW9dPCDm2CA9Eiuj1UUnGIW jEYAdEADtONdv7lh6jGhJQatX3ImAqNFZIKkHXYidq/Zmy554rJe0PhuBWtYiEO7VP+W Z/BMyUMqiIXA4jh1xJ4IDFqu5+L6K5WRcMC2y90lnHAk+nIYJCBNmAHqw2qThodSU4cI OawF+VxoSefwksYfAzJkxYZAkz+ygi0aOzTcNIi5UPKBd2aSXXVq6ptmMg2/Y1iyQxaI 12WXd6IbtZ15QMhn+/Fy0bmiCNT9z0yTiBx6qAGRtDTqWnKr5GNVoIj70fsu5px5iNsm LmZA== X-Gm-Message-State: AOAM530jgwvK0yE2iMafbXQF/Lihpk4BxM4HUPHMAzEBnhXL3oxZdZKk sGkFsNa+r3OD6uX7HnQ9og== X-Google-Smtp-Source: ABdhPJxLLzBy4UD9XD8/7SJRsKiYhGphIJQmrnQkOk0M0IRZ8p8MucQvJeMkW5n7bTSiceZG6ayJ3g== X-Received: by 2002:a05:6870:a701:: with SMTP id g1mr59208oam.96.1644583518219; Fri, 11 Feb 2022 04:45:18 -0800 (PST) Received: from robh.at.kernel.org ([2607:fb90:20d4:10b7:69a2:33cd:1782:fb47]) by smtp.gmail.com with ESMTPSA id t4sm9461269oie.14.2022.02.11.04.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Feb 2022 04:45:17 -0800 (PST) Received: (nullmailer pid 192847 invoked by uid 1000); Fri, 11 Feb 2022 12:45:13 -0000 Date: Fri, 11 Feb 2022 06:45:13 -0600 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Srinivas Kandagatla , Florian Fainelli , Hauke Mehrtens , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH 2/3] dt-bindings: nvmem: brcm,nvram: add NVMEM cell to example Message-ID: References: <20220124160300.25131-1-zajec5@gmail.com> <20220124160300.25131-3-zajec5@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220124160300.25131-3-zajec5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220211_044519_683330_C27CC194 X-CRM114-Status: GOOD ( 20.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKYW4gMjQsIDIwMjIgYXQgMDU6MDI6NTlQTSArMDEwMCwgUmFmYcWCIE1pxYJlY2tp IHdyb3RlOgo+IEZyb206IFJhZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNraS5wbD4KPiAKPiBO VlJBTSBkb2Vzbid0IGhhdmUgY2VsbHMgYXQgaGFyZGNvZGVkIGFkZHJlc3Nlcy4gVGhleSBhcmUg c3RvcmVkIGluCj4gaW50ZXJuYWwgc3RydWN0IChjdXN0b20gJiBkeW5hbWljIGZvcm1hdCkgLiBJ dCdzIHN0aWxsIGltcG9ydGFudCB0bwo+IGRlZmluZSByZWxldmFudCBjZWxscyBpbiBEVCBzbyBO Vk1FTSBjb25zdW1lcnMgY2FuIHJlZmVyZW5jZSB0aGVtLgo+IAo+IE9uZSBvZiBjZWxscyBzZXQg aW4gYWxtb3N0IGV2ZXJ5IGRldmljZSBpcyAiZXQwbWFjYWRkciIgY29udGFpbmluZyBNQUMKPiBh ZGRyZXNzLiBBZGQgaXQgdG8gZXhhbXBsZSB0byBzaG93IGhvdyBpdCBjYW4gYmUgcmVmZXJlbmNl ZC4KCiJldDBtYWNhZGRyIiBpcyBkZWZpbmVkIGluIHRoZSBpbnRlcm5hbCBzdHJ1Y3Q/IENhbiB5 b3UgbWFrZSB0aGlzIApleHBsaWNpdCBpbiB0aGUgdGhlIHNjaGVtYSB0aGF0J3Mgd2hlcmUgdGhl IGNoaWxkIG5vZGUgbmFtZXMgY29tZSBmcm9tLiAKUGVyaGFwcyBnbyBhcyBmYXIgYXMgZG9jdW1l bnRpbmcgd2hhdCBzb21lIG9mIHRoZSBuYW1lcyBhcmUgaWYgdGhleSBhcmUgCmNvbW1vbiBhbmQg bm90IGRvY3VtZW50ZWQgZWxzZXdoZXJlLgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBSYWZhxYIgTWnF gmVja2kgPHJhZmFsQG1pbGVja2kucGw+Cj4gLS0tCj4gIERvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9udm1lbS9icmNtLG52cmFtLnlhbWwgfCA3ICsrKysrLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL252bWVtL2JyY20sbnZyYW0ueWFtbCBi L0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9udm1lbS9icmNtLG52cmFtLnlhbWwK PiBpbmRleCA4YzNmMGNkMjI4MjEuLmFiMTRlM2FlNDVjOCAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbnZtZW0vYnJjbSxudnJhbS55YW1sCj4gKysrIGIv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL252bWVtL2JyY20sbnZyYW0ueWFtbAo+ IEBAIC0zMiw2ICszMiw5IEBAIHVuZXZhbHVhdGVkUHJvcGVydGllczogZmFsc2UKPiAgZXhhbXBs ZXM6Cj4gICAgLSB8Cj4gICAgICBudnJhbUAxZWZmMDAwMCB7Cj4gLSAgICAgICAgICAgIGNvbXBh dGlibGUgPSAiYnJjbSxudnJhbSI7Cj4gLSAgICAgICAgICAgIHJlZyA9IDwweDFlZmYwMDAwIDB4 MTAwMDA+Owo+ICsgICAgICAgIGNvbXBhdGlibGUgPSAiYnJjbSxudnJhbSI7Cj4gKyAgICAgICAg cmVnID0gPDB4MWVmZjAwMDAgMHgxMDAwMD47Cj4gKwo+ICsgICAgICAgIG1hYzogZXQwbWFjYWRk ciB7Cj4gKyAgICAgICAgfTsKPiAgICAgIH07Cj4gLS0gCj4gMi4zMS4xCj4gCj4gCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C679CC433F5 for ; Fri, 11 Feb 2022 12:45:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350238AbiBKMpV (ORCPT ); Fri, 11 Feb 2022 07:45:21 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345089AbiBKMpT (ORCPT ); Fri, 11 Feb 2022 07:45:19 -0500 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8C0CF6E; Fri, 11 Feb 2022 04:45:18 -0800 (PST) Received: by mail-oo1-f47.google.com with SMTP id i10-20020a4aab0a000000b002fccf890d5fso10139484oon.5; Fri, 11 Feb 2022 04:45:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=1ZmE/JWwkWWP/1u0tD/CxpUFw+p6UWTWhaQ4GN/9I4g=; b=f/SlicSjSG8wt2ieEbC6gsaDqQEpAxrCopetb/afHefyuSBcRVvfNipjH3G/vWJOj/ anPB3T0cf5KtOVIlNTUUrgwnXLdlY5ouCWTH7QTaMMH9JVI9Z2kNtTJGESDz7cuJOqsS WoccEgYNiWy08r8foeVNhoiebrwWlnN5vOlOX5WK6zXqvnEVqn4UIOpseKWVaIB4kacz H/OecSTZi4kkWjsudoTyr/LveeaubXD/vU4jyzoDXAb+c9Vq9EM+gz6x3JIVMNxVZ3/S 8q33whMgAwNnOihgnIWrs4Qz06HYtt6xmeO0vPvitnYgjPgWjOfJ8S86+/juXB33Y4yn W0xA== X-Gm-Message-State: AOAM533Wi3Tp4ZOwFtGlAW2+4+PIqjEKPuBpIHLKjweZMiI4AZjJVORp aD6oexd3v/onOrq55CqjsQ== X-Google-Smtp-Source: ABdhPJxLLzBy4UD9XD8/7SJRsKiYhGphIJQmrnQkOk0M0IRZ8p8MucQvJeMkW5n7bTSiceZG6ayJ3g== X-Received: by 2002:a05:6870:a701:: with SMTP id g1mr59208oam.96.1644583518219; Fri, 11 Feb 2022 04:45:18 -0800 (PST) Received: from robh.at.kernel.org ([2607:fb90:20d4:10b7:69a2:33cd:1782:fb47]) by smtp.gmail.com with ESMTPSA id t4sm9461269oie.14.2022.02.11.04.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Feb 2022 04:45:17 -0800 (PST) Received: (nullmailer pid 192847 invoked by uid 1000); Fri, 11 Feb 2022 12:45:13 -0000 Date: Fri, 11 Feb 2022 06:45:13 -0600 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Srinivas Kandagatla , Florian Fainelli , Hauke Mehrtens , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH 2/3] dt-bindings: nvmem: brcm,nvram: add NVMEM cell to example Message-ID: References: <20220124160300.25131-1-zajec5@gmail.com> <20220124160300.25131-3-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220124160300.25131-3-zajec5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jan 24, 2022 at 05:02:59PM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > NVRAM doesn't have cells at hardcoded addresses. They are stored in > internal struct (custom & dynamic format) . It's still important to > define relevant cells in DT so NVMEM consumers can reference them. > > One of cells set in almost every device is "et0macaddr" containing MAC > address. Add it to example to show how it can be referenced. "et0macaddr" is defined in the internal struct? Can you make this explicit in the the schema that's where the child node names come from. Perhaps go as far as documenting what some of the names are if they are common and not documented elsewhere. > > Signed-off-by: Rafał Miłecki > --- > Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > index 8c3f0cd22821..ab14e3ae45c8 100644 > --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > @@ -32,6 +32,9 @@ unevaluatedProperties: false > examples: > - | > nvram@1eff0000 { > - compatible = "brcm,nvram"; > - reg = <0x1eff0000 0x10000>; > + compatible = "brcm,nvram"; > + reg = <0x1eff0000 0x10000>; > + > + mac: et0macaddr { > + }; > }; > -- > 2.31.1 > >