From: Cyril Hrubis <chrubis@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] Terminate leftover subprocesses when main test process crashes
Date: Fri, 11 Feb 2022 13:55:23 +0100 [thread overview]
Message-ID: <YgZcu4frLBaKVXL2@yuki> (raw)
In-Reply-To: <20220211114401.24663-1-mdoucha@suse.cz>
Hi!
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -1495,6 +1495,9 @@ static int fork_testrun(void)
> return TFAIL;
> }
>
> + if (tst_test->forks_child)
> + kill(-test_pid, SIGKILL);
> +
Maybe we can even print a message here if the kill() returns with 0,
which would mean that there were any leftover child processes killed.
Either way this is a nice and clean solution:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
> if (WIFEXITED(status) && WEXITSTATUS(status))
> return WEXITSTATUS(status);
>
> --
> 2.34.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-11 12:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 11:44 [LTP] [PATCH v2] Terminate leftover subprocesses when main test process crashes Martin Doucha
2022-02-11 12:55 ` Cyril Hrubis [this message]
2022-02-11 13:29 ` Martin Doucha
2022-02-12 3:03 ` Li Wang
2022-02-18 12:30 ` [LTP] 72b1728674 causing regressions [ [PATCH v2] Terminate leftover subprocesses when main test process crashes] Petr Vorel
2022-02-18 12:42 ` Cyril Hrubis
2022-02-18 14:42 ` Petr Vorel
2022-02-18 14:48 ` Cyril Hrubis
2022-02-18 15:32 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgZcu4frLBaKVXL2@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.