From: Andrew Lunn <andrew@lunn.ch>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: netdev@vger.kernel.org, linus.walleij@linaro.org,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org,
alsi@bang-olufsen.dk, arinc.unal@arinc9.com,
Frank Wunderlich <frank-w@public-files.de>
Subject: Re: [PATCH net-next] net: dsa: realtek: realtek-mdio: reset before setup
Date: Fri, 11 Feb 2022 20:44:48 +0100 [thread overview]
Message-ID: <Yga8sFBosiRpfofp@lunn.ch> (raw)
In-Reply-To: <20220211051403.3952-1-luizluca@gmail.com>
> diff --git a/drivers/net/dsa/realtek/realtek.h b/drivers/net/dsa/realtek/realtek.h
> index ed5abf6cb3d6..e7d3e1bcf8b8 100644
> --- a/drivers/net/dsa/realtek/realtek.h
> +++ b/drivers/net/dsa/realtek/realtek.h
> @@ -5,14 +5,17 @@
> * Copyright (C) 2009-2010 Gabor Juhos <juhosg@openwrt.org>
> */
>
> -#ifndef _REALTEK_SMI_H
> -#define _REALTEK_SMI_H
> +#ifndef _REALTEK_H
> +#define _REALTEK_H
> -#endif /* _REALTEK_SMI_H */
> +#endif /* _REALTEK_H */
These two hunks should probably be in a separate patch. At minimum,
please mention it is in the commit message.
Andrew
next prev parent reply other threads:[~2022-02-11 19:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 5:14 [PATCH net-next] net: dsa: realtek: realtek-mdio: reset before setup Luiz Angelo Daros de Luca
2022-02-11 6:09 ` Frank Wunderlich
2022-02-11 9:54 ` Alvin Šipraga
2022-02-11 10:30 ` Linus Walleij
2022-02-11 23:12 ` Luiz Angelo Daros de Luca
2022-02-11 10:28 ` Linus Walleij
2022-02-11 19:44 ` Andrew Lunn [this message]
2022-02-11 21:01 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yga8sFBosiRpfofp@lunn.ch \
--to=andrew@lunn.ch \
--cc=alsi@bang-olufsen.dk \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.