From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: netdev@vger.kernel.org, mw@semihalf.com, davem@davemloft.net,
kuba@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mvpp2: Check for null pcs in mvpp2_acpi_start()
Date: Sat, 12 Feb 2022 09:58:08 +0000 [thread overview]
Message-ID: <YgeEsF/cr8pfeUR4@shell.armlinux.org.uk> (raw)
In-Reply-To: <0e5f1807-22f1-ec5b-0b18-8bc02ad99760@arm.com>
On Fri, Feb 11, 2022 at 06:18:22PM -0600, Jeremy Linton wrote:
> Hi,
>
> On 2/11/22 17:49, Russell King (Oracle) wrote:
> > On Fri, Feb 11, 2022 at 05:42:35PM -0600, Jeremy Linton wrote:
> > > Booting a MACCHIATObin with 5.17 the system OOPs with
> > > a null pointer deref when the network is started. This
> > > is caused by the pcs->ops structure being null on this
> > > particular platform/firmware.
> >
> > pcs->ops should never be NULL. I'm surprised this fix results in any
> > kind of working networking.
> >
> > Instead, the initialilsation of port->pcs_*.ops needs to be moved out
> > of the if (!mvpp2_use_acpi_compat_mode(..)) block. Please try this:
>
> That appears to fix it as well, shall I re-post this with your fix, or will
> you?
I see you re-posted it anyway - that's fine. Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2022-02-12 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 23:42 [PATCH] net: mvpp2: Check for null pcs in mvpp2_acpi_start() Jeremy Linton
2022-02-11 23:49 ` Russell King (Oracle)
2022-02-12 0:18 ` Jeremy Linton
2022-02-12 9:58 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgeEsF/cr8pfeUR4@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=davem@davemloft.net \
--cc=jeremy.linton@arm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.