Re: m68k: ERROR: "usb_hid_driver" [drivers/hid/wacom.ko] undefined

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Feb 13, 2022 at 11:59:28AM -0800, Jason Self wrote:
> Since version 4.9.293 I have been getting this USB error when building
> the kernel. m68k is too old to have USB.
> 
> cp vmlinux vmlinux.tmp
> m68k-linux-strip vmlinux.tmp
>   Building modules, stage 2.
> gzip -9c vmlinux.tmp >vmlinux.gz
>   MODPOST 894 modules
> rm vmlinux.tmp
> ERROR: "usb_hid_driver" [drivers/hid/wacom.ko] undefined!
> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> make[1]: *** [__modpost] Error 1
> Makefile:1251: recipe for target 'modules' failed
> make: *** [modules] Error 2
> 
> Version 4.9.292 works. Running git bisect tells me:
> 
> 1309eb2ef1001c4cc7e07b867ad9576d2cfeab47 is the first bad commit
> commit 1309eb2ef1001c4cc7e07b867ad9576d2cfeab47
> Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Date:   Wed Dec 1 19:35:02 2021 +0100
> 
>     HID: wacom: fix problems when device is not a valid USB device
>     
>     commit 720ac467204a70308bd687927ed475afb904e11b upstream.
>     
>     The wacom driver accepts devices of more than just USB types, but
>     some code paths can cause problems if the device being controlled
>     is not a USB device due to a lack of checking.  Add the needed
>     checks to ensure that the USB device accesses are only happening on
>     a "real" USB device, and not one on some other bus.
>     
>     Cc: Jiri Kosina <jikos@kernel.org>
>     Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>     Cc: linux-input@vger.kernel.org
>     Cc: stable@vger.kernel.org
>     Tested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>     Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>     Link:
>     https://lore.kernel.org/r/20211201183503.2373082-2-gregkh@linuxfoundation.org
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
>  drivers/hid/wacom_sys.c | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)



Ah, looks like I need to backport 9d14201c7444 ("HID: wacom: add USB_HID
dependency") to the 4.9 tree.  I'll go do that now.

thanks,

greg k-h