From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EFCCC433EF for ; Mon, 14 Feb 2022 15:28:30 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-539-UdWpxegfOai3ydKlRLx1Pw-1; Mon, 14 Feb 2022 10:28:25 -0500 X-MC-Unique: UdWpxegfOai3ydKlRLx1Pw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 34F121091DA2; Mon, 14 Feb 2022 15:28:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F3B3F752C6; Mon, 14 Feb 2022 15:28:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 517E54BB7C; Mon, 14 Feb 2022 15:28:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21EFSDkQ019308 for ; Mon, 14 Feb 2022 10:28:14 -0500 Received: by smtp.corp.redhat.com (Postfix) id B062F7AD3; Mon, 14 Feb 2022 15:28:13 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AC7C77AD1 for ; Mon, 14 Feb 2022 15:28:10 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C20E018A6581 for ; Mon, 14 Feb 2022 15:28:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-361-zmueZICOO1uW6klBpzTUdw-1; Mon, 14 Feb 2022 10:28:09 -0500 X-MC-Unique: zmueZICOO1uW6klBpzTUdw-1 Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJbwJ-00FYY2-PT; Mon, 14 Feb 2022 14:02:51 +0000 Date: Mon, 14 Feb 2022 06:02:51 -0800 From: Christoph Hellwig To: Mike Snitzer Message-ID: References: <20220211214057.40612-1-snitzer@redhat.com> <20220211214057.40612-11-snitzer@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220211214057.40612-11-snitzer@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: dm-devel@redhat.com Cc: linux-block@vger.kernel.org, dm-devel@redhat.com Subject: Re: [dm-devel] [PATCH v2 10/14] block: add bio_start_io_acct_remapped for the benefit of DM X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Feb 11, 2022 at 04:40:53PM -0500, Mike Snitzer wrote: > DM needs the ability to account a clone bio's IO to the original > block_device. So add @orig_bdev argument to bio_start_io_acct_time. > > Rename bio_start_io_acct_time to bio_start_io_acct_remapped. > > Also, follow bio_end_io_acct and bio_end_io_acct_remapped pattern by > moving bio_start_io_acct to blkdev.h and have it call > bio_start_io_acct_remapped. Looks good: Reviewed-by: Christoph Hellwig -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 797C6C433F5 for ; Mon, 14 Feb 2022 14:02:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237179AbiBNODB (ORCPT ); Mon, 14 Feb 2022 09:03:01 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354852AbiBNOC7 (ORCPT ); Mon, 14 Feb 2022 09:02:59 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D2219D for ; Mon, 14 Feb 2022 06:02:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rj6C33iz9CPtFnBqhCCaHdbyPr4QjpyN8OA7hTDTqik=; b=q2G074nXQa2o7b+Lb7V5ARhs72 fkRghjHw09wK1ZGmtXCF1TR8p5W3njdCpR0RBtCX9AR3og6rr2uBBJA4gTaJ1Y35uevjnPfkb4yWZ aYzyo0Tp9PZ2mY2Z64YEbJTgRcmBeahFFP/xthmrXmWLGL85sDPE31xbqpWKuQxP8RqgpOjj0YzUe 8igx6bSe7lb/NENwMc5lOTevMDSKfggBv5pRX1GXoweuc7MWMvfW5ro479oCoYE/zL8m0U0mgYl2d dqempMFR32w/N49k2usikHbWYHy3qX4euQWKd4fExmvxuQf0DdbSfFWaSqdvHe0MUVjvniGTaVPU5 dbNQwvtw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJbwJ-00FYY2-PT; Mon, 14 Feb 2022 14:02:51 +0000 Date: Mon, 14 Feb 2022 06:02:51 -0800 From: Christoph Hellwig To: Mike Snitzer Cc: dm-devel@redhat.com, linux-block@vger.kernel.org Subject: Re: [PATCH v2 10/14] block: add bio_start_io_acct_remapped for the benefit of DM Message-ID: References: <20220211214057.40612-1-snitzer@redhat.com> <20220211214057.40612-11-snitzer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220211214057.40612-11-snitzer@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Feb 11, 2022 at 04:40:53PM -0500, Mike Snitzer wrote: > DM needs the ability to account a clone bio's IO to the original > block_device. So add @orig_bdev argument to bio_start_io_acct_time. > > Rename bio_start_io_acct_time to bio_start_io_acct_remapped. > > Also, follow bio_end_io_acct and bio_end_io_acct_remapped pattern by > moving bio_start_io_acct to blkdev.h and have it call > bio_start_io_acct_remapped. Looks good: Reviewed-by: Christoph Hellwig