From: Peter Zijlstra <peterz@infradead.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Suren Baghdasaryan <surenb@google.com>,
Huangzhaoyang <huangzhaoyang@gmail.com>,
Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
Ingo Molnar <mingo@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4] psi: fix possible trigger missing in the window
Date: Mon, 14 Feb 2022 16:09:53 +0100 [thread overview]
Message-ID: <YgpwwZvTU/llBMeC@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <YgpvwTbakWSI4TWK@cmpxchg.org>
On Mon, Feb 14, 2022 at 10:05:37AM -0500, Johannes Weiner wrote:
> On Tue, Jan 25, 2022 at 02:56:58PM +0800, Huangzhaoyang wrote:
> > From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> >
> > When a new threshold breaching stall happens after a psi event was
> > generated and within the window duration, the new event is not
> > generated because the events are rate-limited to one per window. If
> > after that no new stall is recorded then the event will not be
> > generated even after rate-limiting duration has passed. This is
> > happening because with no new stall, window_update will not be called
> > even though threshold was previously breached. To fix this, record
> > threshold breaching occurrence and generate the event once window
> > duration is passed.
> >
> > Suggested-by: Suren Baghdasaryan <surenb@google.com>
> > Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>
> Hey Peter, would you mind taking this through the scheduler tree? It's
> got my and Suren's acks. It's not a recent regression so I'm thinking
> for 5.18 is fine. Thanks!
Sorry, missed it, got it now. Thanks!
prev parent reply other threads:[~2022-02-14 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 6:56 [PATCHv4] psi: fix possible trigger missing in the window Huangzhaoyang
2022-01-25 14:40 ` Johannes Weiner
2022-01-26 16:44 ` Suren Baghdasaryan
2022-02-14 15:05 ` Johannes Weiner
2022-02-14 15:09 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgpwwZvTU/llBMeC@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=hannes@cmpxchg.org \
--cc=huangzhaoyang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=surenb@google.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.